* [PATCH v2 1/4] arm64: dts: rockchip: list all CPU supplies on ArmSoM Sige5
2025-06-14 18:14 [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5 Alexey Charkov
@ 2025-06-14 18:14 ` Alexey Charkov
2025-06-14 18:14 ` [PATCH v2 2/4] arm64: dts: rockchip: add SDIO controller on RK3576 Alexey Charkov
` (4 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Alexey Charkov @ 2025-06-14 18:14 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Detlev Casanova
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
Alexey Charkov, stable, Nicolas Frattaroli
List both CPU supply regulators which drive the little and big CPU
clusters, respectively, so that cpufreq can pick them up.
Without this patch the cpufreq governor attempts to raise the big CPU
frequency under high load, while its supply voltage stays at 850000 uV.
This causes system instability and, in my case, random reboots.
With this patch, supply voltages are adjusted in step with frequency
changes from 700000-737000 uV in idle to 950000 uV under full load,
and the system appears to be stable.
While at this, list all CPU supplies for completeness.
Cc: stable@vger.kernel.org
Fixes: 40f742b07ab2 ("arm64: dts: rockchip: Add rk3576-armsom-sige5 board")
Reviewed-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Tested-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Signed-off-by: Alexey Charkov <alchark@gmail.com>
---
.../boot/dts/rockchip/rk3576-armsom-sige5.dts | 28 ++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
index b09e789c75c47fec7cf7e9810ab0dcca32d9404a..801b40fea4e8808c3f889ddd3ed3aa875a377567 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
@@ -211,10 +211,38 @@ &combphy0_ps {
status = "okay";
};
+&cpu_b0 {
+ cpu-supply = <&vdd_cpu_big_s0>;
+};
+
+&cpu_b1 {
+ cpu-supply = <&vdd_cpu_big_s0>;
+};
+
+&cpu_b2 {
+ cpu-supply = <&vdd_cpu_big_s0>;
+};
+
+&cpu_b3 {
+ cpu-supply = <&vdd_cpu_big_s0>;
+};
+
&cpu_l0 {
cpu-supply = <&vdd_cpu_lit_s0>;
};
+&cpu_l1 {
+ cpu-supply = <&vdd_cpu_lit_s0>;
+};
+
+&cpu_l2 {
+ cpu-supply = <&vdd_cpu_lit_s0>;
+};
+
+&cpu_l3 {
+ cpu-supply = <&vdd_cpu_lit_s0>;
+};
+
&gmac0 {
phy-mode = "rgmii-id";
clock_in_out = "output";
--
2.49.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 2/4] arm64: dts: rockchip: add SDIO controller on RK3576
2025-06-14 18:14 [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5 Alexey Charkov
2025-06-14 18:14 ` [PATCH v2 1/4] arm64: dts: rockchip: list all CPU supplies " Alexey Charkov
@ 2025-06-14 18:14 ` Alexey Charkov
2025-06-14 18:14 ` [PATCH v2 3/4] arm64: dts: rockchip: add version-independent WiFi/BT nodes on Sige5 Alexey Charkov
` (3 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Alexey Charkov @ 2025-06-14 18:14 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Detlev Casanova
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
Alexey Charkov
RK3576 has one more SD/MMC controller than are currently listed in its
.dtsi, with the missing one intended as an SDIO controller. Add the
missing node (tested with the onboard WiFi module on ArmSoM Sige5 v1.2)
Signed-off-by: Alexey Charkov <alchark@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3576.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
index 1086482f04792325dc4c22fb8ceeb27eef59afe4..d3225d20baadd56364655fdde6b33113b65484ad 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
@@ -1695,6 +1695,22 @@ sdmmc: mmc@2a310000 {
status = "disabled";
};
+ sdio: mmc@2a320000 {
+ compatible = "rockchip,rk3576-dw-mshc";
+ reg = <0x0 0x2a320000 0x0 0x4000>;
+ clocks = <&cru HCLK_SDIO>, <&cru CCLK_SRC_SDIO>;
+ clock-names = "biu", "ciu";
+ fifo-depth = <0x100>;
+ interrupts = <GIC_SPI 252 IRQ_TYPE_LEVEL_HIGH>;
+ max-frequency = <200000000>;
+ pinctrl-0 = <&sdmmc1m0_clk &sdmmc1m0_cmd &sdmmc1m0_bus4>;
+ pinctrl-names = "default";
+ power-domains = <&power RK3576_PD_SDGMAC>;
+ resets = <&cru SRST_H_SDIO>;
+ reset-names = "reset";
+ status = "disabled";
+ };
+
sdhci: mmc@2a330000 {
compatible = "rockchip,rk3576-dwcmshc", "rockchip,rk3588-dwcmshc";
reg = <0x0 0x2a330000 0x0 0x10000>;
--
2.49.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 3/4] arm64: dts: rockchip: add version-independent WiFi/BT nodes on Sige5
2025-06-14 18:14 [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5 Alexey Charkov
2025-06-14 18:14 ` [PATCH v2 1/4] arm64: dts: rockchip: list all CPU supplies " Alexey Charkov
2025-06-14 18:14 ` [PATCH v2 2/4] arm64: dts: rockchip: add SDIO controller on RK3576 Alexey Charkov
@ 2025-06-14 18:14 ` Alexey Charkov
2025-06-14 18:14 ` [PATCH v2 4/4] arm64: dts: rockchip: add overlay for the WiFi/BT module on Sige5 v1.2 Alexey Charkov
` (2 subsequent siblings)
5 siblings, 0 replies; 11+ messages in thread
From: Alexey Charkov @ 2025-06-14 18:14 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Detlev Casanova
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
Alexey Charkov
ArmSoM Sige5 uses a soldered-on WiFi/BT module with WiFi on SDIO and BT
on UART. However, board v1.1 uses a Realtek based BL-M8852BS2, while
v1.2 uses a Broadcom based BW3752-50B1. They use the same pins and
controllers, but require different DT properties to enable.
Thankfully, the WiFi part at least works without explicitly listing it in
the device tree, albeit without OOB interrupt functionality.
Add required device tree nodes that do not depend on the board version so
that at least the WiFi module can appear on the SDIO bus.
WiFi OOB interrupt and Bluetooth function support are not enabled here, as
they require module specific properties.
Signed-off-by: Alexey Charkov <alchark@gmail.com>
---
.../boot/dts/rockchip/rk3576-armsom-sige5.dts | 57 ++++++++++++++++++++++
1 file changed, 57 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
index 801b40fea4e8808c3f889ddd3ed3aa875a377567..fcc8b7d8c1cdc79efa7a37e9f0e5b0e6f3c8758c 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dts
@@ -205,6 +205,15 @@ vcc_3v3_ufs_s0: regulator-vcc-ufs-s0 {
regulator-max-microvolt = <3300000>;
vin-supply = <&vcc_5v0_sys>;
};
+
+ sdio_pwrseq: sdio-pwrseq {
+ compatible = "mmc-pwrseq-simple";
+ clocks = <&hym8563>;
+ clock-names = "ext_clock";
+ pinctrl-names = "default";
+ pinctrl-0 = <&wifi_reg_on>;
+ reset-gpios = <&gpio1 RK_PC6 GPIO_ACTIVE_LOW>;
+ };
};
&combphy0_ps {
@@ -757,6 +766,30 @@ pcie_reset: pcie-reset {
rockchip,pins = <2 RK_PB4 RK_FUNC_GPIO &pcfg_pull_up>;
};
};
+
+ wireless-bluetooth {
+ bt_reg_on: bt-reg-on {
+ rockchip,pins = <1 RK_PC7 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+
+ host_wake_bt: host-wake-bt {
+ rockchip,pins = <1 RK_PD4 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+
+ bt_wake_host: bt-wake-host {
+ rockchip,pins = <0 RK_PB1 RK_FUNC_GPIO &pcfg_pull_down>;
+ };
+ };
+
+ wireless-wlan {
+ wifi_wake_host: wifi-wake-host {
+ rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_down>;
+ };
+
+ wifi_reg_on: wifi-reg-on {
+ rockchip,pins = <1 RK_PC6 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
};
&sai1 {
@@ -784,6 +817,23 @@ &sdhci {
status = "okay";
};
+&sdio {
+ bus-width = <4>;
+ cap-sdio-irq;
+ disable-wp;
+ keep-power-in-suspend;
+ mmc-pwrseq = <&sdio_pwrseq>;
+ no-sd;
+ no-mmc;
+ non-removable;
+ sd-uhs-sdr50;
+ sd-uhs-sdr104;
+ vmmc-supply = <&vcc_3v3_s3>;
+ vqmmc-supply = <&vcc_1v8_s3>;
+ wakeup-source;
+ status = "okay";
+};
+
&sdmmc {
bus-width = <4>;
cap-mmc-highspeed;
@@ -803,6 +853,13 @@ &uart0 {
status = "okay";
};
+/* Used by Bluetooth modules, enabled in a version specific overlay */
+&uart4 {
+ pinctrl-0 = <&uart4m1_xfer &uart4m1_ctsn &uart4m1_rtsn>;
+ pinctrl-names = "default";
+ uart-has-rtscts;
+};
+
&vop {
status = "okay";
};
--
2.49.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH v2 4/4] arm64: dts: rockchip: add overlay for the WiFi/BT module on Sige5 v1.2
2025-06-14 18:14 [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5 Alexey Charkov
` (2 preceding siblings ...)
2025-06-14 18:14 ` [PATCH v2 3/4] arm64: dts: rockchip: add version-independent WiFi/BT nodes on Sige5 Alexey Charkov
@ 2025-06-14 18:14 ` Alexey Charkov
2025-06-16 21:46 ` [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5 Rob Herring (Arm)
2025-06-19 21:17 ` Heiko Stuebner
5 siblings, 0 replies; 11+ messages in thread
From: Alexey Charkov @ 2025-06-14 18:14 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Detlev Casanova
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
Alexey Charkov
Add support for the Broadcom based WiFi/Bluetooth module (BW3752-50B1)
found in ArmSoM Sige5 boards version 1.2. This includes SDIO connected
WiFi with OOB interrupt support, as well as UART connected Bluetooth
with its respective interrupts.
PCM support for Bluetooth SCO audio is left out for now. It is connected
to SAI2 in M0 pin mode in case someone needs to enable it.
Note that v1.1 boards used a Realtek based module which is incompatible
with these DT nodes, so v1.1 would need a different overlay.
Signed-off-by: Alexey Charkov <alchark@gmail.com>
---
arch/arm64/boot/dts/rockchip/Makefile | 5 +++
.../rockchip/rk3576-armsom-sige5-v1.2-wifibt.dtso | 49 ++++++++++++++++++++++
2 files changed, 54 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
index 4bf84622db473696f64b157ba94560f476d4f52f..26533be1dd865972b681d133aad6fbbbf4e64bce 100644
--- a/arch/arm64/boot/dts/rockchip/Makefile
+++ b/arch/arm64/boot/dts/rockchip/Makefile
@@ -143,6 +143,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-display-vz.dtbo
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-io-expander.dtbo
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-armsom-sige5.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-armsom-sige5-v1.2-wifibt.dtbo
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-evb1-v10.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-roc-pc.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-rock-4d.dtb
@@ -225,6 +226,10 @@ rk3568-wolfvision-pf5-vz-2-uhd-dtbs := rk3568-wolfvision-pf5.dtb \
rk3568-wolfvision-pf5-display-vz.dtbo \
rk3568-wolfvision-pf5-io-expander.dtbo
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-armsom-sige5-v1.2-wifibt.dtb
+rk3576-armsom-sige5-v1.2-wifibt-dtbs := rk3576-armsom-sige5.dtb \
+ rk3576-armsom-sige5-v1.2-wifibt.dtbo
+
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-edgeble-neu6a-wifi.dtb
rk3588-edgeble-neu6a-wifi-dtbs := rk3588-edgeble-neu6a-io.dtb \
rk3588-edgeble-neu6a-wifi.dtbo
diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5-v1.2-wifibt.dtso b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5-v1.2-wifibt.dtso
new file mode 100644
index 0000000000000000000000000000000000000000..6985c3b22ebe4efcc7e7b7370f527838a557cf2b
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5-v1.2-wifibt.dtso
@@ -0,0 +1,49 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * DT-overlay to enable the onboard WiFi and Bluetooth module present in v1.2
+ * boards. Note that v1.1 boards use a different module, so this probably won't
+ * work there.
+ */
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/pinctrl/rockchip.h>
+
+&sdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ wifi@1 {
+ compatible = "brcm,bcm4329-fmac";
+ reg = <1>;
+ clock-names = "lpo";
+ clocks = <&hym8563>;
+ interrupt-names = "host-wake";
+ interrupt-parent = <&gpio0>;
+ interrupts = <RK_PB0 IRQ_TYPE_LEVEL_HIGH>;
+ pinctrl-0 = <&wifi_wake_host>;
+ pinctrl-names = "default";
+ };
+};
+
+&uart4 {
+ status = "okay";
+
+ bluetooth {
+ compatible = "brcm,bcm43438-bt";
+ clock-names = "lpo";
+ clocks = <&hym8563>;
+ device-wakeup-gpios = <&gpio1 RK_PD7 GPIO_ACTIVE_HIGH>;
+ interrupt-names = "host-wakeup";
+ interrupt-parent = <&gpio0>;
+ interrupts = <RK_PB1 IRQ_TYPE_LEVEL_HIGH>;
+ pinctrl-0 = <&bt_reg_on>, <&bt_wake_host>, <&host_wake_bt>;
+ pinctrl-names = "default";
+ shutdown-gpios = <&gpio0 RK_PC6 GPIO_ACTIVE_HIGH>;
+ vbat-supply = <&vcc_3v3_s3>;
+ vddio-supply = <&vcc_1v8_s3>;
+ };
+};
--
2.49.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5
2025-06-14 18:14 [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5 Alexey Charkov
` (3 preceding siblings ...)
2025-06-14 18:14 ` [PATCH v2 4/4] arm64: dts: rockchip: add overlay for the WiFi/BT module on Sige5 v1.2 Alexey Charkov
@ 2025-06-16 21:46 ` Rob Herring (Arm)
2025-06-17 6:54 ` Alexey Charkov
2025-06-19 21:17 ` Heiko Stuebner
5 siblings, 1 reply; 11+ messages in thread
From: Rob Herring (Arm) @ 2025-06-16 21:46 UTC (permalink / raw)
To: Alexey Charkov
Cc: Detlev Casanova, linux-kernel, Krzysztof Kozlowski,
Nicolas Frattaroli, Heiko Stuebner, Conor Dooley, linux-rockchip,
stable, linux-arm-kernel, devicetree
On Sat, 14 Jun 2025 22:14:32 +0400, Alexey Charkov wrote:
> Link up the CPU regulators for DVFS, enable WiFi and Bluetooth.
>
> Different board versions use different incompatible WiFi/Bluetooth modules
> so split the version-specific bits out into an overlay. Basic WiFi
> functionality works even without an overlay, but OOB interrupts and
> all Bluetooth stuff requires one.
>
> My board is v1.2, so the overlay is only provided for it.
>
> Signed-off-by: Alexey Charkov <alchark@gmail.com>
> ---
> Changes in v2:
> - Expand the commit message for the patch linking CPU regulators and add
> tags for stable (thanks Nicolas)
> - Fix the ordering of cpu_b* nodes vs. combphy0_ps (thanks Diederik)
> - Drop the USB patch, as Nicolas has already posted a more comprehensive
> series including also the Type-C stuff (thanks Nicolas)
> - Pick up Nicolas' tags
> - Split out board version specific WiFi/Bluetooth stuff into an overlay
> - Link to v1: https://lore.kernel.org/r/20250603-sige5-updates-v1-0-717e8ce4ab77@gmail.com
>
> ---
> Alexey Charkov (4):
> arm64: dts: rockchip: list all CPU supplies on ArmSoM Sige5
> arm64: dts: rockchip: add SDIO controller on RK3576
> arm64: dts: rockchip: add version-independent WiFi/BT nodes on Sige5
> arm64: dts: rockchip: add overlay for the WiFi/BT module on Sige5 v1.2
>
> arch/arm64/boot/dts/rockchip/Makefile | 5 ++
> .../rockchip/rk3576-armsom-sige5-v1.2-wifibt.dtso | 49 +++++++++++++
> .../boot/dts/rockchip/rk3576-armsom-sige5.dts | 85 ++++++++++++++++++++++
> arch/arm64/boot/dts/rockchip/rk3576.dtsi | 16 ++++
> 4 files changed, 155 insertions(+)
> ---
> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> change-id: 20250602-sige5-updates-a162b501a1b1
>
> Best regards,
> --
> Alexey Charkov <alchark@gmail.com>
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: using specified base-commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250614-sige5-updates-v2-0-3bb31b02623c@gmail.com:
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm0:pwm0m1-ch1:rockchip,pins:0:2: 14 is greater than the maximum of 13
from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch1:rockchip,pins:0:2: 14 is greater than the maximum of 13
from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch0:rockchip,pins:0:2: 14 is greater than the maximum of 13
from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m0-ch4:rockchip,pins:0:2: 14 is greater than the maximum of 13
from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch2:rockchip,pins:0:2: 14 is greater than the maximum of 13
from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m0-ch2:rockchip,pins:0:2: 14 is greater than the maximum of 13
from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m0-ch3:rockchip,pins:0:2: 14 is greater than the maximum of 13
from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch3:rockchip,pins:0:2: 14 is greater than the maximum of 13
from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch5:rockchip,pins:0:2: 14 is greater than the maximum of 13
from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch6:rockchip,pins:0:2: 14 is greater than the maximum of 13
from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): i3c1_sda:i3c1_sdam1-pu:rockchip,pins:0:2: 14 is greater than the maximum of 13
from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm1:pwm1m1-ch5:rockchip,pins:0:2: 14 is greater than the maximum of 13
from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): i3c1:i3c1m1-xfer:rockchip,pins:0:2: 14 is greater than the maximum of 13
from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): i3c1:i3c1m1-xfer:rockchip,pins:1:2: 14 is greater than the maximum of 13
from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5
2025-06-16 21:46 ` [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5 Rob Herring (Arm)
@ 2025-06-17 6:54 ` Alexey Charkov
0 siblings, 0 replies; 11+ messages in thread
From: Alexey Charkov @ 2025-06-17 6:54 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Detlev Casanova, linux-kernel, Krzysztof Kozlowski,
Nicolas Frattaroli, Heiko Stuebner, Conor Dooley, linux-rockchip,
stable, linux-arm-kernel, devicetree
On Tue, Jun 17, 2025 at 1:46 AM Rob Herring (Arm) <robh@kernel.org> wrote:
>
>
> On Sat, 14 Jun 2025 22:14:32 +0400, Alexey Charkov wrote:
> > Link up the CPU regulators for DVFS, enable WiFi and Bluetooth.
> >
> > Different board versions use different incompatible WiFi/Bluetooth modules
> > so split the version-specific bits out into an overlay. Basic WiFi
> > functionality works even without an overlay, but OOB interrupts and
> > all Bluetooth stuff requires one.
> >
> > My board is v1.2, so the overlay is only provided for it.
> >
> > Signed-off-by: Alexey Charkov <alchark@gmail.com>
> > ---
> > Changes in v2:
> > - Expand the commit message for the patch linking CPU regulators and add
> > tags for stable (thanks Nicolas)
> > - Fix the ordering of cpu_b* nodes vs. combphy0_ps (thanks Diederik)
> > - Drop the USB patch, as Nicolas has already posted a more comprehensive
> > series including also the Type-C stuff (thanks Nicolas)
> > - Pick up Nicolas' tags
> > - Split out board version specific WiFi/Bluetooth stuff into an overlay
> > - Link to v1: https://lore.kernel.org/r/20250603-sige5-updates-v1-0-717e8ce4ab77@gmail.com
> >
> > ---
> > Alexey Charkov (4):
> > arm64: dts: rockchip: list all CPU supplies on ArmSoM Sige5
> > arm64: dts: rockchip: add SDIO controller on RK3576
> > arm64: dts: rockchip: add version-independent WiFi/BT nodes on Sige5
> > arm64: dts: rockchip: add overlay for the WiFi/BT module on Sige5 v1.2
> >
> > arch/arm64/boot/dts/rockchip/Makefile | 5 ++
> > .../rockchip/rk3576-armsom-sige5-v1.2-wifibt.dtso | 49 +++++++++++++
> > .../boot/dts/rockchip/rk3576-armsom-sige5.dts | 85 ++++++++++++++++++++++
> > arch/arm64/boot/dts/rockchip/rk3576.dtsi | 16 ++++
> > 4 files changed, 155 insertions(+)
> > ---
> > base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
> > change-id: 20250602-sige5-updates-a162b501a1b1
> >
> > Best regards,
> > --
> > Alexey Charkov <alchark@gmail.com>
> >
> >
> >
>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
> pip3 install dtschema --upgrade
>
>
> This patch series was applied (using b4) to base:
> Base: using specified base-commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
>
> If this is not the correct base, please add 'base-commit' tag
> (or use b4 which does this automatically)
>
> New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/rockchip/' for 20250614-sige5-updates-v2-0-3bb31b02623c@gmail.com:
>
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm0:pwm0m1-ch1:rockchip,pins:0:2: 14 is greater than the maximum of 13
> from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch1:rockchip,pins:0:2: 14 is greater than the maximum of 13
> from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch0:rockchip,pins:0:2: 14 is greater than the maximum of 13
> from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m0-ch4:rockchip,pins:0:2: 14 is greater than the maximum of 13
> from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch2:rockchip,pins:0:2: 14 is greater than the maximum of 13
> from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m0-ch2:rockchip,pins:0:2: 14 is greater than the maximum of 13
> from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m0-ch3:rockchip,pins:0:2: 14 is greater than the maximum of 13
> from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch3:rockchip,pins:0:2: 14 is greater than the maximum of 13
> from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch5:rockchip,pins:0:2: 14 is greater than the maximum of 13
> from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm2:pwm2m1-ch6:rockchip,pins:0:2: 14 is greater than the maximum of 13
> from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): i3c1_sda:i3c1_sdam1-pu:rockchip,pins:0:2: 14 is greater than the maximum of 13
> from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): pwm1:pwm1m1-ch5:rockchip,pins:0:2: 14 is greater than the maximum of 13
> from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): i3c1:i3c1m1-xfer:rockchip,pins:0:2: 14 is greater than the maximum of 13
> from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
> arch/arm64/boot/dts/rockchip/rk3576-armsom-sige5.dtb: pinctrl (rockchip,rk3576-pinctrl): i3c1:i3c1m1-xfer:rockchip,pins:1:2: 14 is greater than the maximum of 13
> from schema $id: http://devicetree.org/schemas/pinctrl/rockchip,pinctrl.yaml#
N.B.: these are unrelated to my series, and fixed by Nicolas' patch at
[1], already in -next.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=86491c2b99e5adbb56d76286d6668effb36d3c90
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5
2025-06-14 18:14 [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5 Alexey Charkov
` (4 preceding siblings ...)
2025-06-16 21:46 ` [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5 Rob Herring (Arm)
@ 2025-06-19 21:17 ` Heiko Stuebner
2025-06-20 8:40 ` Alexey Charkov
5 siblings, 1 reply; 11+ messages in thread
From: Heiko Stuebner @ 2025-06-19 21:17 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Detlev Casanova,
Alexey Charkov
Cc: Heiko Stuebner, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel, stable, Nicolas Frattaroli
On Sat, 14 Jun 2025 22:14:32 +0400, Alexey Charkov wrote:
> Link up the CPU regulators for DVFS, enable WiFi and Bluetooth.
>
> Different board versions use different incompatible WiFi/Bluetooth modules
> so split the version-specific bits out into an overlay. Basic WiFi
> functionality works even without an overlay, but OOB interrupts and
> all Bluetooth stuff requires one.
>
> [...]
Applied, thanks!
[1/4] arm64: dts: rockchip: list all CPU supplies on ArmSoM Sige5
commit: c76bcc7d1f24e90a2d7b98d1e523d7524269fc56
[2/4] arm64: dts: rockchip: add SDIO controller on RK3576
commit: e490f854b46369b096f3d09c0c6a00f340425136
[3/4] arm64: dts: rockchip: add version-independent WiFi/BT nodes on Sige5
commit: 358ccc1d8b242b8c659e5e177caef174624e8cb6
[4/4] arm64: dts: rockchip: add overlay for the WiFi/BT module on Sige5 v1.2
commit: a8cdcbe6a9f64f56ee24c9e8325fb89cf41a5d63
Patch 1 as fix for v6.16
I've also fixed the wifi@1 node in the overlay - which was using
spaces instead of tabs.
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5
2025-06-19 21:17 ` Heiko Stuebner
@ 2025-06-20 8:40 ` Alexey Charkov
2025-06-20 8:44 ` Heiko Stuebner
0 siblings, 1 reply; 11+ messages in thread
From: Alexey Charkov @ 2025-06-20 8:40 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Detlev Casanova,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
stable, Nicolas Frattaroli
On Fri, Jun 20, 2025 at 1:17 AM Heiko Stuebner <heiko@sntech.de> wrote:
>
>
> On Sat, 14 Jun 2025 22:14:32 +0400, Alexey Charkov wrote:
> > Link up the CPU regulators for DVFS, enable WiFi and Bluetooth.
> >
> > Different board versions use different incompatible WiFi/Bluetooth modules
> > so split the version-specific bits out into an overlay. Basic WiFi
> > functionality works even without an overlay, but OOB interrupts and
> > all Bluetooth stuff requires one.
> >
> > [...]
>
> Applied, thanks!
>
> [1/4] arm64: dts: rockchip: list all CPU supplies on ArmSoM Sige5
> commit: c76bcc7d1f24e90a2d7b98d1e523d7524269fc56
> [2/4] arm64: dts: rockchip: add SDIO controller on RK3576
> commit: e490f854b46369b096f3d09c0c6a00f340425136
> [3/4] arm64: dts: rockchip: add version-independent WiFi/BT nodes on Sige5
> commit: 358ccc1d8b242b8c659e5e177caef174624e8cb6
> [4/4] arm64: dts: rockchip: add overlay for the WiFi/BT module on Sige5 v1.2
> commit: a8cdcbe6a9f64f56ee24c9e8325fb89cf41a5d63
>
> Patch 1 as fix for v6.16
>
> I've also fixed the wifi@1 node in the overlay - which was using
> spaces instead of tabs.
Thanks Heiko! It's annoying that YAML doesn't like tabs, so copying
from binding examples is not a universally good idea :)
By the way, is there any tool that helps catch those?
Best regards,
Alexey
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5
2025-06-20 8:40 ` Alexey Charkov
@ 2025-06-20 8:44 ` Heiko Stuebner
2025-06-20 10:10 ` Diederik de Haas
0 siblings, 1 reply; 11+ messages in thread
From: Heiko Stuebner @ 2025-06-20 8:44 UTC (permalink / raw)
To: Alexey Charkov
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Detlev Casanova,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel,
stable, Nicolas Frattaroli
Am Freitag, 20. Juni 2025, 10:40:49 Mitteleuropäische Sommerzeit schrieb Alexey Charkov:
> On Fri, Jun 20, 2025 at 1:17 AM Heiko Stuebner <heiko@sntech.de> wrote:
> >
> >
> > On Sat, 14 Jun 2025 22:14:32 +0400, Alexey Charkov wrote:
> > > Link up the CPU regulators for DVFS, enable WiFi and Bluetooth.
> > >
> > > Different board versions use different incompatible WiFi/Bluetooth modules
> > > so split the version-specific bits out into an overlay. Basic WiFi
> > > functionality works even without an overlay, but OOB interrupts and
> > > all Bluetooth stuff requires one.
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/4] arm64: dts: rockchip: list all CPU supplies on ArmSoM Sige5
> > commit: c76bcc7d1f24e90a2d7b98d1e523d7524269fc56
> > [2/4] arm64: dts: rockchip: add SDIO controller on RK3576
> > commit: e490f854b46369b096f3d09c0c6a00f340425136
> > [3/4] arm64: dts: rockchip: add version-independent WiFi/BT nodes on Sige5
> > commit: 358ccc1d8b242b8c659e5e177caef174624e8cb6
> > [4/4] arm64: dts: rockchip: add overlay for the WiFi/BT module on Sige5 v1.2
> > commit: a8cdcbe6a9f64f56ee24c9e8325fb89cf41a5d63
> >
> > Patch 1 as fix for v6.16
> >
> > I've also fixed the wifi@1 node in the overlay - which was using
> > spaces instead of tabs.
>
> Thanks Heiko! It's annoying that YAML doesn't like tabs, so copying
> from binding examples is not a universally good idea :)
>
> By the way, is there any tool that helps catch those?
checkpatch.pl would be the tool to do that, but I'm not sure it handles
this at this time.
I also only saw things when I looked at the patch in "mcedit", because
it nicely distinguishes between tabs and spaces :-) .
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 0/4] arm64: dts: rockchip: enable further peripherals on ArmSoM Sige5
2025-06-20 8:44 ` Heiko Stuebner
@ 2025-06-20 10:10 ` Diederik de Haas
0 siblings, 0 replies; 11+ messages in thread
From: Diederik de Haas @ 2025-06-20 10:10 UTC (permalink / raw)
To: Heiko Stuebner, Alexey Charkov
Cc: Rob Herring, Conor Dooley, devicetree, Detlev Casanova, stable,
linux-kernel, linux-rockchip, Krzysztof Kozlowski,
linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 826 bytes --]
On Fri Jun 20, 2025 at 10:44 AM CEST, Heiko Stuebner wrote:
> Am Freitag, 20. Juni 2025, 10:40:49 Mitteleuropäische Sommerzeit schrieb Alexey Charkov:
>> On Fri, Jun 20, 2025 at 1:17 AM Heiko Stuebner <heiko@sntech.de> wrote:
>> >
>> > I've also fixed the wifi@1 node in the overlay - which was using
>> > spaces instead of tabs.
>>
>> Thanks Heiko! It's annoying that YAML doesn't like tabs, so copying
>> from binding examples is not a universally good idea :)
>>
>> By the way, is there any tool that helps catch those?
>
> checkpatch.pl would be the tool to do that, but I'm not sure it handles
> this at this time.
>
> I also only saw things when I looked at the patch in "mcedit", because
> it nicely distinguishes between tabs and spaces :-) .
In vim, ``:set list`` makes them visible as well.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread