* [PATCH] dt-bindings: Move sophgo,cv1800b-rtc to rtc directory
@ 2025-06-08 22:42 Rob Herring (Arm)
2025-06-08 22:49 ` Inochi Amaoto
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Rob Herring (Arm) @ 2025-06-08 22:42 UTC (permalink / raw)
To: Alexandre Belloni, Krzysztof Kozlowski, Conor Dooley, Chen Wang,
Inochi Amaoto, sophgo, Jingbao Qiu, Alexander Sverdlin
Cc: Krzysztof Kozlowski, linux-rtc, devicetree, linux-kernel
The $id path for the sophgo,cv1800b-rtc binding was missing part of the
path 'soc'. However, the correct place for RTC bindings (even if it's
also a "syscon") is the rtc directory, so move the binding there while
fixing the $id value.
Fixes: 76517429dbfd ("dt-bindings: soc: sophgo: add RTC support for Sophgo CV1800 series")
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../bindings/{soc/sophgo => rtc}/sophgo,cv1800b-rtc.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
rename Documentation/devicetree/bindings/{soc/sophgo => rtc}/sophgo,cv1800b-rtc.yaml (96%)
diff --git a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
similarity index 96%
rename from Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml
rename to Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
index 5cf186c396c9..c695d2ff9fcc 100644
--- a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
%YAML 1.2
---
-$id: http://devicetree.org/schemas/sophgo/sophgo,cv1800b-rtc.yaml#
+$id: http://devicetree.org/schemas/rtc/sophgo,cv1800b-rtc.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#
title: Real Time Clock of the Sophgo CV1800 SoC
--
2.47.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: Move sophgo,cv1800b-rtc to rtc directory
2025-06-08 22:42 [PATCH] dt-bindings: Move sophgo,cv1800b-rtc to rtc directory Rob Herring (Arm)
@ 2025-06-08 22:49 ` Inochi Amaoto
2025-06-17 13:09 ` Rob Herring
2025-07-03 7:49 ` Krzysztof Kozlowski
2025-07-07 21:43 ` Alexandre Belloni
2 siblings, 1 reply; 8+ messages in thread
From: Inochi Amaoto @ 2025-06-08 22:49 UTC (permalink / raw)
To: Rob Herring (Arm), Alexandre Belloni, Krzysztof Kozlowski,
Conor Dooley, Chen Wang, Inochi Amaoto, sophgo, Jingbao Qiu,
Alexander Sverdlin
Cc: Krzysztof Kozlowski, linux-rtc, devicetree, linux-kernel
On Sun, Jun 08, 2025 at 05:42:51PM -0500, Rob Herring (Arm) wrote:
> The $id path for the sophgo,cv1800b-rtc binding was missing part of the
> path 'soc'. However, the correct place for RTC bindings (even if it's
> also a "syscon") is the rtc directory, so move the binding there while
> fixing the $id value.
>
> Fixes: 76517429dbfd ("dt-bindings: soc: sophgo: add RTC support for Sophgo CV1800 series")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../bindings/{soc/sophgo => rtc}/sophgo,cv1800b-rtc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> rename Documentation/devicetree/bindings/{soc/sophgo => rtc}/sophgo,cv1800b-rtc.yaml (96%)
>
> diff --git a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> similarity index 96%
> rename from Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml
> rename to Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> index 5cf186c396c9..c695d2ff9fcc 100644
> --- a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> @@ -1,7 +1,7 @@
> # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> %YAML 1.2
> ---
> -$id: http://devicetree.org/schemas/sophgo/sophgo,cv1800b-rtc.yaml#
> +$id: http://devicetree.org/schemas/rtc/sophgo,cv1800b-rtc.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> title: Real Time Clock of the Sophgo CV1800 SoC
> --
> 2.47.2
>
As the rtc syscon has a sub function for remoteproc, is it proper to
move this binding into rtc subsystem?
Regards,
Inochi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: Move sophgo,cv1800b-rtc to rtc directory
2025-06-08 22:49 ` Inochi Amaoto
@ 2025-06-17 13:09 ` Rob Herring
2025-06-17 23:18 ` Inochi Amaoto
0 siblings, 1 reply; 8+ messages in thread
From: Rob Herring @ 2025-06-17 13:09 UTC (permalink / raw)
To: Inochi Amaoto
Cc: Alexandre Belloni, Krzysztof Kozlowski, Conor Dooley, Chen Wang,
sophgo, Jingbao Qiu, Alexander Sverdlin, Krzysztof Kozlowski,
linux-rtc, devicetree, linux-kernel
On Mon, Jun 09, 2025 at 06:49:38AM +0800, Inochi Amaoto wrote:
> On Sun, Jun 08, 2025 at 05:42:51PM -0500, Rob Herring (Arm) wrote:
> > The $id path for the sophgo,cv1800b-rtc binding was missing part of the
> > path 'soc'. However, the correct place for RTC bindings (even if it's
> > also a "syscon") is the rtc directory, so move the binding there while
> > fixing the $id value.
> >
> > Fixes: 76517429dbfd ("dt-bindings: soc: sophgo: add RTC support for Sophgo CV1800 series")
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > ---
> > .../bindings/{soc/sophgo => rtc}/sophgo,cv1800b-rtc.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > rename Documentation/devicetree/bindings/{soc/sophgo => rtc}/sophgo,cv1800b-rtc.yaml (96%)
> >
> > diff --git a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> > similarity index 96%
> > rename from Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml
> > rename to Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> > index 5cf186c396c9..c695d2ff9fcc 100644
> > --- a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> > @@ -1,7 +1,7 @@
> > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > %YAML 1.2
> > ---
> > -$id: http://devicetree.org/schemas/sophgo/sophgo,cv1800b-rtc.yaml#
> > +$id: http://devicetree.org/schemas/rtc/sophgo,cv1800b-rtc.yaml#
> > $schema: http://devicetree.org/meta-schemas/core.yaml#
> >
> > title: Real Time Clock of the Sophgo CV1800 SoC
> > --
> > 2.47.2
> >
>
> As the rtc syscon has a sub function for remoteproc, is it proper to
> move this binding into rtc subsystem?
Does that affect the binding (is there more to add)? Looks like an RTC
from the binding.
Rob
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: Move sophgo,cv1800b-rtc to rtc directory
2025-06-17 13:09 ` Rob Herring
@ 2025-06-17 23:18 ` Inochi Amaoto
2025-07-03 7:49 ` Krzysztof Kozlowski
0 siblings, 1 reply; 8+ messages in thread
From: Inochi Amaoto @ 2025-06-17 23:18 UTC (permalink / raw)
To: Rob Herring, Inochi Amaoto
Cc: Alexandre Belloni, Krzysztof Kozlowski, Conor Dooley, Chen Wang,
sophgo, Jingbao Qiu, Alexander Sverdlin, Krzysztof Kozlowski,
linux-rtc, devicetree, linux-kernel
On Tue, Jun 17, 2025 at 08:09:24AM -0500, Rob Herring wrote:
> On Mon, Jun 09, 2025 at 06:49:38AM +0800, Inochi Amaoto wrote:
> > On Sun, Jun 08, 2025 at 05:42:51PM -0500, Rob Herring (Arm) wrote:
> > > The $id path for the sophgo,cv1800b-rtc binding was missing part of the
> > > path 'soc'. However, the correct place for RTC bindings (even if it's
> > > also a "syscon") is the rtc directory, so move the binding there while
> > > fixing the $id value.
> > >
> > > Fixes: 76517429dbfd ("dt-bindings: soc: sophgo: add RTC support for Sophgo CV1800 series")
> > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > > ---
> > > .../bindings/{soc/sophgo => rtc}/sophgo,cv1800b-rtc.yaml | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > rename Documentation/devicetree/bindings/{soc/sophgo => rtc}/sophgo,cv1800b-rtc.yaml (96%)
> > >
> > > diff --git a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> > > similarity index 96%
> > > rename from Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml
> > > rename to Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> > > index 5cf186c396c9..c695d2ff9fcc 100644
> > > --- a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml
> > > +++ b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> > > @@ -1,7 +1,7 @@
> > > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > %YAML 1.2
> > > ---
> > > -$id: http://devicetree.org/schemas/sophgo/sophgo,cv1800b-rtc.yaml#
> > > +$id: http://devicetree.org/schemas/rtc/sophgo,cv1800b-rtc.yaml#
> > > $schema: http://devicetree.org/meta-schemas/core.yaml#
> > >
> > > title: Real Time Clock of the Sophgo CV1800 SoC
> > > --
> > > 2.47.2
> > >
> >
> > As the rtc syscon has a sub function for remoteproc, is it proper to
> > move this binding into rtc subsystem?
>
> Does that affect the binding (is there more to add)? Looks like an RTC
> from the binding.
>
I think at least "resets" property may be added for the this, but I am
not sure whether there will be more.
Regards,
Inochi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: Move sophgo,cv1800b-rtc to rtc directory
2025-06-17 23:18 ` Inochi Amaoto
@ 2025-07-03 7:49 ` Krzysztof Kozlowski
2025-07-07 8:14 ` Inochi Amaoto
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-03 7:49 UTC (permalink / raw)
To: Inochi Amaoto
Cc: Rob Herring, Alexandre Belloni, Krzysztof Kozlowski, Conor Dooley,
Chen Wang, sophgo, Jingbao Qiu, Alexander Sverdlin, linux-rtc,
devicetree, linux-kernel
On Wed, Jun 18, 2025 at 07:18:32AM +0800, Inochi Amaoto wrote:
> On Tue, Jun 17, 2025 at 08:09:24AM -0500, Rob Herring wrote:
> > On Mon, Jun 09, 2025 at 06:49:38AM +0800, Inochi Amaoto wrote:
> > > On Sun, Jun 08, 2025 at 05:42:51PM -0500, Rob Herring (Arm) wrote:
> > > > The $id path for the sophgo,cv1800b-rtc binding was missing part of the
> > > > path 'soc'. However, the correct place for RTC bindings (even if it's
> > > > also a "syscon") is the rtc directory, so move the binding there while
> > > > fixing the $id value.
> > > >
> > > > Fixes: 76517429dbfd ("dt-bindings: soc: sophgo: add RTC support for Sophgo CV1800 series")
> > > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > > > ---
> > > > .../bindings/{soc/sophgo => rtc}/sophgo,cv1800b-rtc.yaml | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > rename Documentation/devicetree/bindings/{soc/sophgo => rtc}/sophgo,cv1800b-rtc.yaml (96%)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> > > > similarity index 96%
> > > > rename from Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml
> > > > rename to Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> > > > index 5cf186c396c9..c695d2ff9fcc 100644
> > > > --- a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml
> > > > +++ b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> > > > @@ -1,7 +1,7 @@
> > > > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > > %YAML 1.2
> > > > ---
> > > > -$id: http://devicetree.org/schemas/sophgo/sophgo,cv1800b-rtc.yaml#
> > > > +$id: http://devicetree.org/schemas/rtc/sophgo,cv1800b-rtc.yaml#
> > > > $schema: http://devicetree.org/meta-schemas/core.yaml#
> > > >
> > > > title: Real Time Clock of the Sophgo CV1800 SoC
> > > > --
> > > > 2.47.2
> > > >
> > >
> > > As the rtc syscon has a sub function for remoteproc, is it proper to
> > > move this binding into rtc subsystem?
> >
> > Does that affect the binding (is there more to add)? Looks like an RTC
> > from the binding.
> >
>
> I think at least "resets" property may be added for the this, but I am
> not sure whether there will be more.
Just post complete bindings - see writing bindings...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: Move sophgo,cv1800b-rtc to rtc directory
2025-06-08 22:42 [PATCH] dt-bindings: Move sophgo,cv1800b-rtc to rtc directory Rob Herring (Arm)
2025-06-08 22:49 ` Inochi Amaoto
@ 2025-07-03 7:49 ` Krzysztof Kozlowski
2025-07-07 21:43 ` Alexandre Belloni
2 siblings, 0 replies; 8+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-03 7:49 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Alexandre Belloni, Krzysztof Kozlowski, Conor Dooley, Chen Wang,
Inochi Amaoto, sophgo, Jingbao Qiu, Alexander Sverdlin, linux-rtc,
devicetree, linux-kernel
On Sun, Jun 08, 2025 at 05:42:51PM -0500, Rob Herring (Arm) wrote:
> The $id path for the sophgo,cv1800b-rtc binding was missing part of the
> path 'soc'. However, the correct place for RTC bindings (even if it's
> also a "syscon") is the rtc directory, so move the binding there while
> fixing the $id value.
>
> Fixes: 76517429dbfd ("dt-bindings: soc: sophgo: add RTC support for Sophgo CV1800 series")
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> .../bindings/{soc/sophgo => rtc}/sophgo,cv1800b-rtc.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> rename Documentation/devicetree/bindings/{soc/sophgo => rtc}/sophgo,cv1800b-rtc.yaml (96%)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: Move sophgo,cv1800b-rtc to rtc directory
2025-07-03 7:49 ` Krzysztof Kozlowski
@ 2025-07-07 8:14 ` Inochi Amaoto
0 siblings, 0 replies; 8+ messages in thread
From: Inochi Amaoto @ 2025-07-07 8:14 UTC (permalink / raw)
To: Krzysztof Kozlowski, Inochi Amaoto
Cc: Rob Herring, Alexandre Belloni, Krzysztof Kozlowski, Conor Dooley,
Chen Wang, sophgo, Jingbao Qiu, Alexander Sverdlin, linux-rtc,
devicetree, linux-kernel
On Thu, Jul 03, 2025 at 09:49:37AM +0200, Krzysztof Kozlowski wrote:
> On Wed, Jun 18, 2025 at 07:18:32AM +0800, Inochi Amaoto wrote:
> > On Tue, Jun 17, 2025 at 08:09:24AM -0500, Rob Herring wrote:
> > > On Mon, Jun 09, 2025 at 06:49:38AM +0800, Inochi Amaoto wrote:
> > > > On Sun, Jun 08, 2025 at 05:42:51PM -0500, Rob Herring (Arm) wrote:
> > > > > The $id path for the sophgo,cv1800b-rtc binding was missing part of the
> > > > > path 'soc'. However, the correct place for RTC bindings (even if it's
> > > > > also a "syscon") is the rtc directory, so move the binding there while
> > > > > fixing the $id value.
> > > > >
> > > > > Fixes: 76517429dbfd ("dt-bindings: soc: sophgo: add RTC support for Sophgo CV1800 series")
> > > > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > > > > ---
> > > > > .../bindings/{soc/sophgo => rtc}/sophgo,cv1800b-rtc.yaml | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > rename Documentation/devicetree/bindings/{soc/sophgo => rtc}/sophgo,cv1800b-rtc.yaml (96%)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> > > > > similarity index 96%
> > > > > rename from Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml
> > > > > rename to Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> > > > > index 5cf186c396c9..c695d2ff9fcc 100644
> > > > > --- a/Documentation/devicetree/bindings/soc/sophgo/sophgo,cv1800b-rtc.yaml
> > > > > +++ b/Documentation/devicetree/bindings/rtc/sophgo,cv1800b-rtc.yaml
> > > > > @@ -1,7 +1,7 @@
> > > > > # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > > > %YAML 1.2
> > > > > ---
> > > > > -$id: http://devicetree.org/schemas/sophgo/sophgo,cv1800b-rtc.yaml#
> > > > > +$id: http://devicetree.org/schemas/rtc/sophgo,cv1800b-rtc.yaml#
> > > > > $schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > >
> > > > > title: Real Time Clock of the Sophgo CV1800 SoC
> > > > > --
> > > > > 2.47.2
> > > > >
> > > >
> > > > As the rtc syscon has a sub function for remoteproc, is it proper to
> > > > move this binding into rtc subsystem?
> > >
> > > Does that affect the binding (is there more to add)? Looks like an RTC
> > > from the binding.
> > >
> >
> > I think at least "resets" property may be added for the this, but I am
> > not sure whether there will be more.
>
> Just post complete bindings - see writing bindings...
>
Ignore my guess, I have confirmed the binding is complete,
so free to move.
Regards,
Inochi
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] dt-bindings: Move sophgo,cv1800b-rtc to rtc directory
2025-06-08 22:42 [PATCH] dt-bindings: Move sophgo,cv1800b-rtc to rtc directory Rob Herring (Arm)
2025-06-08 22:49 ` Inochi Amaoto
2025-07-03 7:49 ` Krzysztof Kozlowski
@ 2025-07-07 21:43 ` Alexandre Belloni
2 siblings, 0 replies; 8+ messages in thread
From: Alexandre Belloni @ 2025-07-07 21:43 UTC (permalink / raw)
To: Krzysztof Kozlowski, Conor Dooley, Chen Wang, Inochi Amaoto,
sophgo, Jingbao Qiu, Alexander Sverdlin, Rob Herring (Arm)
Cc: Krzysztof Kozlowski, linux-rtc, devicetree, linux-kernel
On Sun, 08 Jun 2025 17:42:51 -0500, Rob Herring (Arm) wrote:
> The $id path for the sophgo,cv1800b-rtc binding was missing part of the
> path 'soc'. However, the correct place for RTC bindings (even if it's
> also a "syscon") is the rtc directory, so move the binding there while
> fixing the $id value.
>
>
Applied, thanks!
[1/1] dt-bindings: Move sophgo,cv1800b-rtc to rtc directory
https://git.kernel.org/abelloni/c/590951f908f2
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-07-07 21:43 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-08 22:42 [PATCH] dt-bindings: Move sophgo,cv1800b-rtc to rtc directory Rob Herring (Arm)
2025-06-08 22:49 ` Inochi Amaoto
2025-06-17 13:09 ` Rob Herring
2025-06-17 23:18 ` Inochi Amaoto
2025-07-03 7:49 ` Krzysztof Kozlowski
2025-07-07 8:14 ` Inochi Amaoto
2025-07-03 7:49 ` Krzysztof Kozlowski
2025-07-07 21:43 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).