Re: [PATCH v5 18/20] mfd: adp5585: support getting vdd regulator

[Lee Jones <lee@kernel.org>]

On Sat, 14 Jun 2025, Nuno Sá via B4 Relay wrote:

> From: Nuno Sá <nuno.sa@analog.com>
> 
> Make sure we get and enable the VDD supply (if available).
> 
> Reviewed-by: Lee Jones <lee@kernel.org>
> Signed-off-by: Nuno Sá <nuno.sa@analog.com>
> ---
>  drivers/mfd/adp5585.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/mfd/adp5585.c b/drivers/mfd/adp5585.c
> index 3a53bc895e60e6a10f797aebcc29b722906ff087..e4a725b9e1475be03cd26898faa7a7bb8de4319b 100644
> --- a/drivers/mfd/adp5585.c
> +++ b/drivers/mfd/adp5585.c
> @@ -17,6 +17,7 @@
>  #include <linux/mod_devicetable.h>
>  #include <linux/module.h>
>  #include <linux/regmap.h>
> +#include <linux/regulator/consumer.h>
>  #include <linux/types.h>
>  
>  enum {
> @@ -710,6 +711,10 @@ static int adp5585_i2c_probe(struct i2c_client *i2c)
>  	if (IS_ERR(regmap_config))
>  		return PTR_ERR(regmap_config);
>  
> +	ret = devm_regulator_get_enable(&i2c->dev, "vdd");
> +	if (ret)
> +		return ret;
> +
>  	adp5585->regmap = devm_regmap_init_i2c(i2c, regmap_config);
>  	if (IS_ERR(adp5585->regmap))
>  		return dev_err_probe(&i2c->dev, PTR_ERR(adp5585->regmap),
> @@ -726,6 +731,7 @@ static int adp5585_i2c_probe(struct i2c_client *i2c)
>  				     "Invalid device ID 0x%02x\n", id);
>  
>  	adp5585->pin_usage = devm_bitmap_zalloc(&i2c->dev, adp5585->n_pins, GFP_KERNEL);
> +

This looks like a mistake.

>  	if (!adp5585->pin_usage)
>  		return -ENOMEM;
>  
> 
> -- 
> 2.49.0
> 
> 

-- 
Lee Jones [李琼斯]