From: Olivier Benjamin <olivier.benjamin@bootlin.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Nicholas Roth <nicholas@rothemail.net>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
imx@lists.linux.dev,
Olivier Benjamin <olivier.benjamin@bootlin.com>,
~diederik/pine64-discuss@lists.sr.ht,
Dragan Simic <dsimic@manjaro.org>, Ondrej Jirman <megi@xff.cz>
Subject: [PATCH v4 0/4] Describe the cameras in the PinePhone Pro dts
Date: Fri, 20 Jun 2025 17:21:31 +0200 [thread overview]
Message-ID: <20250620-camera-v4-0-0201a8ed5fae@bootlin.com> (raw)
This series adds support for the Pine64 PinePhone Pro's rear and front
cameras in Device Tree.
This is based on some of Ondrej Jirman's patches hosted in his tree at
https://codeberg.org/megi/linux, but I have also fully reviewed and
re-written the code from the RK3399 datasheet, the PinePhone Pro
schematic, and the IMX258-0AQH5 software reference manual.
I have tested these changes on my PinePhone Pro and am able to take
photos from both cameras using libcamera's cam.
This series has raised a question about the proper label name for the
front/user camera and rear/world camera for phones.
This series is using "ucam" and "wcam", which is used in a few other
Rockship DTBs:
- arch/arm64/boot/dts/rockchip/px30-evb.dts
- rk3399-gru-scarlet.dtsi
Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com>
---
Changes in v4:
- Dropped "clock-names" property from IM258 as it is absent from the binding.
- Renamed pinctrl definitions to match the names in the PinePhone Pro datasheet.
- Collected Rob Herring's acked-by for patches 1 and 2
- Link to v3: https://lore.kernel.org/r/20250509-camera-v3-0-dab2772d229a@bootlin.com
Changes in v3:
- Fixed new DTB warnings reported by Rob Herring's bot
- Link to v2: https://lore.kernel.org/r/20250302-camera-v2-0-312b44b4a89c@bootlin.com
Changes in v2:
- Rebase on mainline
- Change patch subject to arm64: dts: rockchip
- Rename new regulators to fit preferred form for fixed regulators
- Link to v1: https://lore.kernel.org/r/20250228-camera-v1-0-c51869f94e97@bootlin.com
---
Olivier Benjamin (4):
dt-bindings: media: ov8858: inherit video-interface-devices properties
dt-bindings: media: imx258: inherit video-interface-devices properties
arm64: dts: rockchip: describe I2c Bus 1 and IMX258 world camera on PinePhone Pro
arm64: dts: rockchip: describe the OV8858 user camera on PinePhone Pro
.../devicetree/bindings/media/i2c/ovti,ov8858.yaml | 4 +-
.../devicetree/bindings/media/i2c/sony,imx258.yaml | 4 +-
.../boot/dts/rockchip/rk3399-pinephone-pro.dts | 138 +++++++++++++++++++++
3 files changed, 144 insertions(+), 2 deletions(-)
---
--
Olivier Benjamin <olivier.benjamin@bootlin.com>
next reply other threads:[~2025-06-20 15:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 15:21 Olivier Benjamin [this message]
2025-06-20 15:21 ` [PATCH v4 1/4] dt-bindings: media: ov8858: inherit video-interface-devices properties Olivier Benjamin
2025-06-20 15:21 ` [PATCH v4 2/4] dt-bindings: media: imx258: " Olivier Benjamin
2025-06-20 15:21 ` [PATCH v4 3/4] arm64: dts: rockchip: describe I2c Bus 1 and IMX258 world camera on PinePhone Pro Olivier Benjamin
2025-08-02 8:40 ` Kieran Bingham
2025-08-02 8:57 ` Kieran Bingham
2025-06-20 15:21 ` [PATCH v4 4/4] arm64: dts: rockchip: describe the OV8858 user " Olivier Benjamin
2025-06-23 6:47 ` [PATCH v4 0/4] Describe the cameras in the PinePhone Pro dts Sakari Ailus
2025-06-23 10:05 ` Heiko Stuebner
2025-06-23 10:08 ` Sakari Ailus
2025-06-30 9:50 ` Heiko Stübner
2025-07-10 11:01 ` (subset) " Heiko Stuebner
2025-07-30 14:35 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250620-camera-v4-0-0201a8ed5fae@bootlin.com \
--to=olivier.benjamin@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=imx@lists.linux.dev \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=megi@xff.cz \
--cc=nicholas@rothemail.net \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnguo@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=~diederik/pine64-discuss@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).