Re: [PATCH 1/3] dt-bindings: net: cdns,macb: Add external REFCLK property

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1631 bytes --]

On Thu, Jun 19, 2025 at 10:04:13AM -0700, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
> 
> REFCLK can be provided by an external source so this should be exposed
> by a DT property. The REFCLK is used for RMII and in some SoCs that use
> this driver the RGMII 125MHz clk can also be provided by an external
> source.
> 
> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
> ---
>  Documentation/devicetree/bindings/net/cdns,macb.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> index 8d69846b2e09..e69f60c37793 100644
> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
> @@ -114,6 +114,13 @@ properties:
>    power-domains:
>      maxItems: 1
>  
> +  cdns,refclk-ext:
> +    type: boolean
> +    description:
> +      This selects if the REFCLK for RMII is provided by an external source.
> +      For RGMII mode this selects if the 125MHz REF clock is provided by an external
> +      source.

If this gets a v2, is the distinction between RMII and RGMII worth
mentioning? Or is that mentioned because the property has no effect for
!{RGMII,RMII} usecases?
I'm okay with the property existing, though so
Acked-by: Conor Dooley <conor.dooley@microchip.com>
if it's the latter or with an improved description for the former.

> +
>    cdns,rx-watermark:
>      $ref: /schemas/types.yaml#/definitions/uint32
>      description:
> -- 
> 2.43.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]