Re: [PATCH v5 01/11] dt-bindings: iio: adc: Add AD4170

[Jonathan Cameron <jic23@kernel.org>]

> 
> Otherwise, what you have here looks sane enough to me - but I'd like to
> see some comments from Jonathan or David etc about your approach to the
> excitation properties.

They look sane to me.  The complexity of devices that handle weigh cells and
similar are always a pain.  In theory we could have a go at describing
the weigh-cell in DT and then try to derive the 'right' settings but that
seems like a very complex thing to do.  Long time since I did anything with
weigh cells, but I think you mostly read the settings to use of a datasheet rather
than deriving them from first principles. Thermocouples are similar (I'm not
that familiar with RTDs)

As to the handling of the different sensor types - that seems like a sensible
way to constrain the binding and end up with sane readable combinations rather
than a bunch of excitation settings with no info on what is connected.

Not sure this is the perfect solution, but to me it looks good enough and
flexible / general enough to cover a wide range of other devices.

Jonathan

> 
> Cheers,
> Conor.