devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Romanov <romanov.alexey2000@gmail.com>
To: neil.armstrong@linaro.org, clabbe@baylibre.com,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	khilman@baylibre.com, jbrunet@baylibre.com,
	martin.blumenstingl@googlemail.com
Cc: linux-crypto@vger.kernel.org, linux-amlogic@lists.infradead.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Alexey Romanov <romanov.alexey2000@gmail.com>
Subject: [PATCH v12 02/22] crypto: amlogic - Add platform data
Date: Tue, 24 Jun 2025 16:51:54 +0300	[thread overview]
Message-ID: <20250624135214.1355051-3-romanov.alexey2000@gmail.com> (raw)
In-Reply-To: <20250624135214.1355051-1-romanov.alexey2000@gmail.com>

To support other Amlogic SoC's we have to
use platform data: descriptors and status registers
offsets are individual for each SoC series.

Signed-off-by: Alexey Romanov <romanov.alexey2000@gmail.com>
---
 drivers/crypto/amlogic/amlogic-gxl-cipher.c |  2 +-
 drivers/crypto/amlogic/amlogic-gxl-core.c   | 22 +++++++++++++++++----
 drivers/crypto/amlogic/amlogic-gxl.h        | 11 +++++++++++
 3 files changed, 30 insertions(+), 5 deletions(-)

diff --git a/drivers/crypto/amlogic/amlogic-gxl-cipher.c b/drivers/crypto/amlogic/amlogic-gxl-cipher.c
index b19032f92415..7eff3ae7356f 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-cipher.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-cipher.c
@@ -225,7 +225,7 @@ static int meson_cipher(struct skcipher_request *areq)
 
 	reinit_completion(&mc->chanlist[flow].complete);
 	mc->chanlist[flow].status = 0;
-	writel(mc->chanlist[flow].t_phy | 2, mc->base + (flow << 2));
+	writel(mc->chanlist[flow].t_phy | 2, mc->base + ((mc->pdata->descs_reg + flow) << 2));
 	wait_for_completion_interruptible_timeout(&mc->chanlist[flow].complete,
 						  msecs_to_jiffies(500));
 	if (mc->chanlist[flow].status == 0) {
diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c
index dc35d7304eb0..d7e455f73c04 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-core.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
@@ -18,6 +18,7 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/of.h>
+#include <linux/of_device.h>
 #include <linux/platform_device.h>
 
 #include "amlogic-gxl.h"
@@ -30,9 +31,10 @@ static irqreturn_t meson_irq_handler(int irq, void *data)
 
 	for (flow = 0; flow < mc->flow_cnt; flow++) {
 		if (mc->chanlist[flow].irq == irq) {
-			p = readl(mc->base + ((0x04 + flow) << 2));
+			p = readl(mc->base + ((mc->pdata->status_reg + flow) << 2));
 			if (p) {
-				writel_relaxed(0xF, mc->base + ((0x4 + flow) << 2));
+				writel_relaxed(0xF, mc->base +
+					      ((mc->pdata->status_reg + flow) << 2));
 				mc->chanlist[flow].status = 1;
 				complete(&mc->chanlist[flow].complete);
 				return IRQ_HANDLED;
@@ -254,6 +256,10 @@ static int meson_crypto_probe(struct platform_device *pdev)
 	if (!mc)
 		return -ENOMEM;
 
+	mc->pdata = of_device_get_match_data(&pdev->dev);
+	if (!mc->pdata)
+		return -EINVAL;
+
 	mc->dev = &pdev->dev;
 	platform_set_drvdata(pdev, mc);
 
@@ -317,9 +323,17 @@ static void meson_crypto_remove(struct platform_device *pdev)
 	clk_disable_unprepare(mc->busclk);
 }
 
+static const struct meson_pdata meson_gxl_pdata = {
+	.descs_reg = 0x0,
+	.status_reg = 0x4,
+};
+
 static const struct of_device_id meson_crypto_of_match_table[] = {
-	{ .compatible = "amlogic,gxl-crypto", },
-	{}
+	{
+		.compatible = "amlogic,gxl-crypto",
+		.data = &meson_gxl_pdata,
+	},
+	{},
 };
 MODULE_DEVICE_TABLE(of, meson_crypto_of_match_table);
 
diff --git a/drivers/crypto/amlogic/amlogic-gxl.h b/drivers/crypto/amlogic/amlogic-gxl.h
index 9f1ef87333ae..e0bc5c39bf2c 100644
--- a/drivers/crypto/amlogic/amlogic-gxl.h
+++ b/drivers/crypto/amlogic/amlogic-gxl.h
@@ -78,6 +78,16 @@ struct meson_flow {
 #endif
 };
 
+/*
+ * struct meson_pdata - SoC series dependent data.
+ * @reg_descs:	offset to descriptors register
+ * @reg_status:	offset to status register
+ */
+struct meson_pdata {
+	u32 descs_reg;
+	u32 status_reg;
+};
+
 /*
  * struct meson_dev - main container for all this driver information
  * @base:	base address of amlogic-crypto
@@ -93,6 +103,7 @@ struct meson_dev {
 	void __iomem *base;
 	struct clk *busclk;
 	struct device *dev;
+	const struct meson_pdata *pdata;
 	struct meson_flow *chanlist;
 	atomic_t flow;
 	int flow_cnt;
-- 
2.34.1


  parent reply	other threads:[~2025-06-24 13:53 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-24 13:51 [PATCH v12 00/22] Support more Amlogic SoC families in crypto driver Alexey Romanov
2025-06-24 13:51 ` [PATCH v12 01/22] crypto: amlogic - Don't hardcode IRQ count Alexey Romanov
2025-06-24 13:51 ` Alexey Romanov [this message]
2025-06-24 13:51 ` [PATCH v12 03/22] crypto: amlogic - Remove clock input Alexey Romanov
2025-06-24 13:51 ` [PATCH v12 04/22] crypto: amlogic - Add MMIO helpers Alexey Romanov
2025-06-24 13:51 ` [PATCH v12 05/22] crypto: amlogic - Move get_engine_number() Alexey Romanov
2025-06-24 13:51 ` [PATCH v12 06/22] crypto: amlogic - Drop status field from meson_flow Alexey Romanov
2025-06-24 13:51 ` [PATCH v12 07/22] crypto: amlogic - Move algs definition and cipher API to cipher.c Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 08/22] crypto: amlogic - Cleanup defines Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 09/22] crypto: amlogic - Process more than MAXDESCS descriptors Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 10/22] crypto: amlogic - Avoid kzalloc in engine thread Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 11/22] crypto: amlogic - Introduce hasher Alexey Romanov
2025-07-10  8:08   ` Herbert Xu
2025-06-24 13:52 ` [PATCH v12 12/22] crypto: amlogic - Use fallback for 192-bit keys Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 13/22] crypto: amlogic - Add support for G12-series Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 14/22] crypto: amlogic - Add support for AXG-series Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 15/22] crypto: amlogic - Add support for A1-series Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 16/22] dt-bindings: crypto: amlogic,gxl-crypto: correct clk and interrupt lines Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 17/22] dt-bindings: crypto: amlogic,gxl-crypto: support new SoC's Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 18/22] arm64: dts: amlogic: gxl: correct crypto node definition Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 19/22] arm64: dts: amlogic: a1: add crypto node Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 20/22] arm64: dts: amlogic: s4: " Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 21/22] arm64: dts: amlogic: g12: " Alexey Romanov
2025-06-24 13:52 ` [PATCH v12 22/22] arm64: dts: amlogic: axg: " Alexey Romanov
2025-07-03  5:47 ` [PATCH v12 00/22] Support more Amlogic SoC families in crypto driver Anand Moon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250624135214.1355051-3-romanov.alexey2000@gmail.com \
    --to=romanov.alexey2000@gmail.com \
    --cc=clabbe@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).