From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-174.mta0.migadu.com (out-174.mta0.migadu.com [91.218.175.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0FBA2E8E14 for ; Fri, 27 Jun 2025 15:27:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751038023; cv=none; b=AO8xVK9k5/El0AJyIxAKg2/oictkS+xyc3+XhnD8Blm0st8HCSkIMWH/T7vjL/LXlpusIeYSY+Nuq4SdBGmvdFmpi96H8G02poenjWKJFEALkuS0SUrK61n3eCJJM0WnGYq4cci0uPdLNpyxSUInCHtl+0hPmy+caTSDWwPfioI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751038023; c=relaxed/simple; bh=QdWPQwZ258Ab/VZrY6VldT/YJcJLb2BH+Pd02n6KAVc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EdjTpmjJz27Ekle3VmTSiFXo7wKdlcvXQsku1DLJWrOm5W4aegZ91lc29HvTk8cyY/jiTRFUmoNltJHCOZa9YvWMNzLPCCt2TsyG0NPYoV/75ESbDiRGB8ibZ1sb0WCSyOKdQ4lHL9YFukSutpMI8ZrVoiwCXMh/37BazD0qiEQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org; spf=pass smtp.mailfrom=cknow.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b=EAo49fA0; arc=none smtp.client-ip=91.218.175.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=cknow.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cknow.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cknow.org header.i=@cknow.org header.b="EAo49fA0" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cknow.org; s=key1; t=1751038018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Wj/6Y49cGnCGvWUR5KcgCT6qJh/Cr23hC+RaEqDcaIo=; b=EAo49fA0xMK8ES/V94l1Hk1DWaZx3MuabqUD2R+mtfqVz/YOuKB23817ppMo3m6rPnT6uj 22wyCu/uf2rXh7PY4u6qEZZD6CVHsZEs80cpcp3nb1J3pj78OzQMFjqOKjbFLjyd476/DS ipVyQgmHL8RxyFajkdjEi0ygt7jB5NMwOuRjh3JGa4Sa/r1j5cBcqe/wasElpdBGlwU5lx vKRTuC2fM+ynw5REjtD+D/7ED4ylZSKmH5A0+R3FlaNGevw3mpXmdOX/PSllPBNp5GPJLn uQL0tt0CmtfBAPaCNTGyzPQugtCT5YUZkdkHYkqWxUIbm3DMZoHtF4+4CAJHrA== From: Diederik de Haas To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner Cc: Dragan Simic , Quentin Schulz , Johan Jonker , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Diederik de Haas Subject: [PATCH 0/8] Fix several DTB validation issues Date: Fri, 27 Jun 2025 17:16:19 +0200 Message-ID: <20250627152645.740981-1-didi.debian@cknow.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT This patch set to fix several DTB validation issues consists of 2 parts: 1) dsi refactoring 2) various low-hanging fruit ad 1) The display/rockchip/rockchip,dw-mipi-dsi.yaml binding had: - #address-cells - #size-cells My guess is that those properties were added for panel(s) which could be connected. While convenient, it's not a property of the DSI controller (in the SoC). And caused DTB validation issues when a panel was not connected to the board. So add the #address/#size-cells properties to the board dts[i] file where there is a panel and then remove the properties from the SoC dtsi file ... and then from the binding file as well. Another part of the DSI refactoring had to do with the declaration of endpoints in which various properties got redefined ... to the same values they had in the SoC dsi node. The SoC dsi node already defined the structure where each port got a label/phandle. That allows for a simplification of the endpoint by referencing that label/phandle. ad 2) There were a number of issues which were obvious to me how to fix, so I fixed those as well My changes were based on yesterday's v6.17-armsoc/dts64 branch: 7f9509791507 ("arm64: dts: rockchip: add DTs for Firefly ROC-RK3588S-PC") Then applied the following patches: 86491c2b99e5 ("dt-bindings: pinctrl: rockchip: increase max amount of device functions") 6f446bbe412a ("dt-bindings: gpu: mali-utgard: Add Rockchip RK3528 compatible") ab9be0b75af5 ("dt-bindings: display: himax-hx8394: Add Huiling hl055fhav028c") 8358102806c6 ("dt-bindings: power: rockchip: Add support for RK3528") 233eda069994 ("dt-bindings: rockchip: pmu: Add compatible for RK3528") And then validated it with W=1 using dtschema-2025.6.1. The validation log file sizes: - base: 99.8 KiB - dsi: 82.1 KiB - low-hanging-fruit: 68.9 KiB I then checked whether dmesg wouldn't indicate problem on these boards: - Rock64 (rk3328) - RockPro64 (rk3399) - PineTab2 (rk3566) Even with removing timestamps there were quite some differences, but that seems related to different boots (and thus the exact order in which things are probed/configured. But I didn't spot difference due to this patch set. I don't have any px30 or rk3399-gru-* based boards, so I couldn't test with those. I also identified some other items which could reduce the DTB validation 'noise' substantially: "failed to match any schema with compatible" errors: - 'mps,mp8859': regulator/mp8859.txt - 'realtek,rt5651': sound/rt5651.txt - 'rockchip,rk3368-mailbox': mailbox/rockchip-mailbox.txt - 'rockchip,rk3399-gru-sound': sound/rockchip,rk3399-gru-sound.txt - 'ti,tsc2007': input/touchscreen/tsc2007.txt Other issues where a (small?) fix may help a lot: px30: - /isp@ff4a0000/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary - /syscon@ff140000/lvds/ports/port@0: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary - /dsi@ff450000/ports/port@0: graph node has single child node 'endpoint@0', #address-cells/#size-cells are not necessary rk3399: - /usb@fe800000: node has a unit name, but no reg or ranges property - /usb@fe900000: node has a unit name, but no reg or ranges property Cheers, Diederik Diederik de Haas (8): arm64: dts: rockchip: Refactor DSI nodes on px30 boards arm64: dts: rockchip: Refactor DSI nodes on rk3399 boards dt-bindings: display: rockchip,dw-mipi-dsi: Drop address/size cells arm64: dts: rockchip: Simplify VOP port definition on rk3328 arm64: dts: rockchip: Simplify edp endpoints on several rk3399 boards arm64: dts: rockchip: Fix LCD panel port on rk3566-pinetab2 arm64: dts: rockchip: Drop unneeded address+size-cells on px30 arm64: dts: rockchip: Drop regulator-compatible property on rk3399 .../rockchip/rockchip,dw-mipi-dsi.yaml | 6 ---- .../rockchip/px30-cobra-ltk050h3146w-a2.dts | 2 ++ .../dts/rockchip/px30-cobra-ltk050h3146w.dts | 2 ++ .../dts/rockchip/px30-cobra-ltk050h3148w.dts | 2 ++ .../dts/rockchip/px30-cobra-ltk500hd1829.dts | 2 ++ arch/arm64/boot/dts/rockchip/px30-evb.dts | 2 ++ .../rockchip/px30-pp1516-ltk050h3146w-a2.dts | 2 ++ .../dts/rockchip/px30-pp1516-ltk050h3148w.dts | 2 ++ arch/arm64/boot/dts/rockchip/px30.dtsi | 6 ---- .../dts/rockchip/rk3326-anbernic-rg351m.dtsi | 2 ++ .../dts/rockchip/rk3326-gameforce-chi.dts | 2 ++ .../boot/dts/rockchip/rk3326-odroid-go.dtsi | 2 ++ arch/arm64/boot/dts/rockchip/rk3328.dtsi | 6 +--- arch/arm64/boot/dts/rockchip/rk3399-base.dtsi | 4 --- .../dts/rockchip/rk3399-gru-chromebook.dtsi | 15 +++------- .../boot/dts/rockchip/rk3399-gru-scarlet.dtsi | 30 ++++++++----------- .../boot/dts/rockchip/rk3399-hugsun-x99.dts | 2 -- .../boot/dts/rockchip/rk3399-pinebook-pro.dts | 15 +++------- .../dts/rockchip/rk3399-pinephone-pro.dts | 2 ++ .../rk3399-puma-haikou-video-demo.dtso | 12 ++++---- .../boot/dts/rockchip/rk3399-rock-4c-plus.dts | 2 -- .../dts/rockchip/rk3399-rockpro64-screen.dtso | 21 ++++--------- .../rockchip/rk3399-sapphire-excavator.dts | 16 +++------- .../boot/dts/rockchip/rk3566-pinetab2.dtsi | 6 ++-- 24 files changed, 62 insertions(+), 101 deletions(-) -- 2.50.0