[PATCH 0/4] allwinner: a523: Add power controllers

[PATCH 0/4] allwinner: a523: Add power controllers

[Chen-Yu Tsai]

From: Chen-Yu Tsai <wens@csie.org>

Hi folks,

This series adds the power controllers found in the Allwinner A523
family of SoCs. There are two power controllers. One is the same type
as those found in the D1 SoC, just with a different number of valid
power domains. The second is (I assume) a unit based on ARM's PCK-600
power controller. Some of the registers and values match up, but there
are extra registers for delay controls in the PCK-600's reserved
register range.

Patch 1 adds new compatible string entries for both of these
controllers.

Patch 2 adds support for the A523 PPU to the existing D1 PPU driver.

Patch 3 adds a new driver of the PCK-600 unit in the A523 SoC.

Patch 4 adds device nodes for both of these controllers.


Please have a look. The power controllers are critical for enabling more
peripherals, such as display output, camera input, video codecs, the NPU,
and a second DWMAC-compatible ethernet interface.


Thanks
ChenYu


Chen-Yu Tsai (4):
  dt-bindings: power: Add A523 PPU and PCK600 power controllers
  pmdomain: sunxi: sun20i-ppu: add A523 support
  pmdomain: sunxi: add driver for Allwinner A523's PCK-600 power
    controller
  arm64: dts: allwinner: a523: Add power controller device nodes

 .../power/allwinner,sun20i-d1-ppu.yaml        |   2 +
 .../arm64/boot/dts/allwinner/sun55i-a523.dtsi |  18 ++
 drivers/pmdomain/sunxi/Kconfig                |   8 +
 drivers/pmdomain/sunxi/Makefile               |   1 +
 drivers/pmdomain/sunxi/sun20i-ppu.c           |  17 ++
 drivers/pmdomain/sunxi/sun55i-pck600.c        | 225 ++++++++++++++++++
 .../power/allwinner,sun55i-a523-pck600.h      |  15 ++
 .../power/allwinner,sun55i-a523-ppu.h         |  12 +
 8 files changed, 298 insertions(+)
 create mode 100644 drivers/pmdomain/sunxi/sun55i-pck600.c
 create mode 100644 include/dt-bindings/power/allwinner,sun55i-a523-pck600.h
 create mode 100644 include/dt-bindings/power/allwinner,sun55i-a523-ppu.h

-- 
2.39.5

[PATCH 1/4] dt-bindings: power: Add A523 PPU and PCK600 power controllers

[Chen-Yu Tsai]

From: Chen-Yu Tsai <wens@csie.org>

The A523 PPU is likely the same kind of hardware seen on previous SoCs.

The A523 PCK600, as the name suggests, is likely a customized version
of ARM's PCK-600 power controller. Comparing the BSP driver against
ARM's PPU datasheet shows that the basic registers line up, but
Allwinner's hardware has some additional delay controls in the reserved
register range. As such it is likely not fully compatible with the
standard ARM version.

Document A523 PPU and PCK600 compatibles.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 .../bindings/power/allwinner,sun20i-d1-ppu.yaml   |  2 ++
 .../power/allwinner,sun55i-a523-pck600.h          | 15 +++++++++++++++
 .../dt-bindings/power/allwinner,sun55i-a523-ppu.h | 12 ++++++++++++
 3 files changed, 29 insertions(+)
 create mode 100644 include/dt-bindings/power/allwinner,sun55i-a523-pck600.h
 create mode 100644 include/dt-bindings/power/allwinner,sun55i-a523-ppu.h

diff --git a/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml
index f578be6a3bc8..b9f550994512 100644
--- a/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml
+++ b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml
@@ -18,6 +18,8 @@ properties:
     enum:
       - allwinner,sun20i-d1-ppu
       - allwinner,sun8i-v853-ppu
+      - allwinner,sun55i-a523-ppu
+      - allwinner,sun55i-a523-pck-600
 
   reg:
     maxItems: 1
diff --git a/include/dt-bindings/power/allwinner,sun55i-a523-pck600.h b/include/dt-bindings/power/allwinner,sun55i-a523-pck600.h
new file mode 100644
index 000000000000..6b3d8ea7bb69
--- /dev/null
+++ b/include/dt-bindings/power/allwinner,sun55i-a523-pck600.h
@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+
+#ifndef _DT_BINDINGS_POWER_SUN55I_A523_PCK600_H_
+#define _DT_BINDINGS_POWER_SUN55I_A523_PCK600_H_
+
+#define PD_VE			0
+#define PD_GPU			1
+#define PD_VI			2
+#define PD_VO0			3
+#define PD_VO1			4
+#define PD_DE			5
+#define PD_NAND			6
+#define PD_PCIE			7
+
+#endif /* _DT_BINDINGS_POWER_SUN55I_A523_PCK600_H_ */
diff --git a/include/dt-bindings/power/allwinner,sun55i-a523-ppu.h b/include/dt-bindings/power/allwinner,sun55i-a523-ppu.h
new file mode 100644
index 000000000000..bc9aba73c19a
--- /dev/null
+++ b/include/dt-bindings/power/allwinner,sun55i-a523-ppu.h
@@ -0,0 +1,12 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+
+#ifndef _DT_BINDINGS_POWER_SUN55I_A523_PPU_H_
+#define _DT_BINDINGS_POWER_SUN55I_A523_PPU_H_
+
+#define PD_DSP			0
+#define PD_NPU			1
+#define PD_AUDIO		2
+#define PD_SRAM			3
+#define PD_RISCV		4
+
+#endif /* _DT_BINDINGS_POWER_SUN55I_A523_PPU_H_ */
-- 
2.39.5

[PATCH 2/4] pmdomain: sunxi: sun20i-ppu: add A523 support

[Chen-Yu Tsai]

From: Chen-Yu Tsai <wens@csie.org>

A523 has a PPU like the one in the Allwinner D1 SoC.

Add a compatible entry and a list of power domain names for it.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 drivers/pmdomain/sunxi/sun20i-ppu.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/drivers/pmdomain/sunxi/sun20i-ppu.c b/drivers/pmdomain/sunxi/sun20i-ppu.c
index 9f002748d224..b65876a68cc1 100644
--- a/drivers/pmdomain/sunxi/sun20i-ppu.c
+++ b/drivers/pmdomain/sunxi/sun20i-ppu.c
@@ -193,6 +193,19 @@ static const struct sun20i_ppu_desc sun8i_v853_ppu_desc = {
 	.num_domains	= ARRAY_SIZE(sun8i_v853_ppu_pd_names),
 };
 
+static const char *const sun55i_a523_ppu_pd_names[] = {
+	"DSP",
+	"NPU",
+	"AUDIO",
+	"SRAM",
+	"RISCV",
+};
+
+static const struct sun20i_ppu_desc sun55i_a523_ppu_desc = {
+	.names		= sun55i_a523_ppu_pd_names,
+	.num_domains	= ARRAY_SIZE(sun55i_a523_ppu_pd_names),
+};
+
 static const struct of_device_id sun20i_ppu_of_match[] = {
 	{
 		.compatible	= "allwinner,sun20i-d1-ppu",
@@ -202,6 +215,10 @@ static const struct of_device_id sun20i_ppu_of_match[] = {
 		.compatible	= "allwinner,sun8i-v853-ppu",
 		.data		= &sun8i_v853_ppu_desc,
 	},
+	{
+		.compatible	= "allwinner,sun55i-a523-ppu",
+		.data		= &sun55i_a523_ppu_desc,
+	},
 	{ }
 };
 MODULE_DEVICE_TABLE(of, sun20i_ppu_of_match);
-- 
2.39.5

[PATCH 3/4] pmdomain: sunxi: add driver for Allwinner A523's PCK-600 power controller

[Chen-Yu Tsai]

From: Chen-Yu Tsai <wens@csie.org>

Allwinner A523 family has a second power controller, named PCK-600 in
the datasheets and BSP. It is likely based on ARM's PCK-600 hardware
block, with some additional delay controls. The only documentation for
this hardware is the BSP driver. The standard registers defined in ARM's
Power Policy Unit Architecture Specification line up. Some extra delay
controls are found in the reserved range of registers.

Add a driver for this power controller. Delay control register values
and power domain names are from the BSP driver.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 drivers/pmdomain/sunxi/Kconfig         |   8 +
 drivers/pmdomain/sunxi/Makefile        |   1 +
 drivers/pmdomain/sunxi/sun55i-pck600.c | 225 +++++++++++++++++++++++++
 3 files changed, 234 insertions(+)
 create mode 100644 drivers/pmdomain/sunxi/sun55i-pck600.c

diff --git a/drivers/pmdomain/sunxi/Kconfig b/drivers/pmdomain/sunxi/Kconfig
index 43eecb3ea981..3e2b77cd9a2b 100644
--- a/drivers/pmdomain/sunxi/Kconfig
+++ b/drivers/pmdomain/sunxi/Kconfig
@@ -18,3 +18,11 @@ config SUN50I_H6_PRCM_PPU
 	  Say y to enable the Allwinner H6/H616 PRCM power domain driver.
 	  This is required to enable the Mali GPU in the H616 SoC, it is
 	  optional for the H6.
+
+config SUN55I_PCK600
+	bool "Allwinner A523 PCK-600 power domain driver"
+	depends on PM
+	select PM_GENERIC_DOMAINS
+	help
+	  Say y to enable the PCK-600 power domain driver. This saves power
+	  when certain peripherals, such as the video engine, are idle.
diff --git a/drivers/pmdomain/sunxi/Makefile b/drivers/pmdomain/sunxi/Makefile
index c1343e123759..e344b232fc9f 100644
--- a/drivers/pmdomain/sunxi/Makefile
+++ b/drivers/pmdomain/sunxi/Makefile
@@ -1,3 +1,4 @@
 # SPDX-License-Identifier: GPL-2.0-only
 obj-$(CONFIG_SUN20I_PPU)		+= sun20i-ppu.o
 obj-$(CONFIG_SUN50I_H6_PRCM_PPU)	+= sun50i-h6-prcm-ppu.o
+obj-$(CONFIG_SUN55I_PCK600)		+= sun55i-pck600.o
diff --git a/drivers/pmdomain/sunxi/sun55i-pck600.c b/drivers/pmdomain/sunxi/sun55i-pck600.c
new file mode 100644
index 000000000000..7248f6113665
--- /dev/null
+++ b/drivers/pmdomain/sunxi/sun55i-pck600.c
@@ -0,0 +1,225 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Allwinner PCK-600 power domain support
+ *
+ * Copyright (c) 2025 Chen-Yu Tsai <wens@csie.org>
+ */
+
+#include <linux/bitfield.h>
+#include <linux/clk.h>
+#include <linux/container_of.h>
+#include <linux/device.h>
+#include <linux/dev_printk.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <linux/iopoll.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
+#include <linux/pm_domain.h>
+#include <linux/reset.h>
+#include <linux/slab.h>
+#include <linux/string_choices.h>
+
+#define PPU_PWPR    0x0
+#define PPU_PWSR    0x8
+#define	PPU_DCDR0   0x170
+#define PPU_DCDR1   0x174
+
+#define PPU_PWSR_PWR_STATUS	GENMASK(3, 0)
+#define PPU_POWER_MODE_ON	0x8
+#define PPU_POWER_MODE_OFF	0x0
+
+#define PPU_REG_SIZE	0x1000
+
+struct sunxi_pck600_desc {
+	const char * const *pd_names;
+	unsigned int num_domains;
+	u32 logic_power_switch0_delay_offset;
+	u32 logic_power_switch1_delay_offset;
+	u32 off2on_delay_offset;
+	u32 device_ctrl0_delay;
+	u32 device_ctrl1_delay;
+	u32 logic_power_switch0_delay;
+	u32 logic_power_switch1_delay;
+	u32 off2on_delay;
+};
+
+struct sunxi_pck600_pd {
+	struct generic_pm_domain genpd;
+	struct sunxi_pck600 *pck;
+	void __iomem *base;
+};
+
+struct sunxi_pck600 {
+	struct device *dev;
+	struct genpd_onecell_data genpd_data;
+	struct sunxi_pck600_pd pds[];
+};
+
+#define to_sunxi_pd(gpd) container_of(gpd, struct sunxi_pck600_pd, genpd)
+
+static int sunxi_pck600_pd_set_power(struct sunxi_pck600_pd *pd, bool on)
+{
+	struct sunxi_pck600 *pck = pd->pck;
+	struct generic_pm_domain *genpd = &pd->genpd;
+	int ret;
+	u32 val, reg;
+
+	val = on ? PPU_POWER_MODE_ON : PPU_POWER_MODE_OFF;
+
+	reg = readl(pd->base + PPU_PWPR);
+	FIELD_MODIFY(PPU_PWSR_PWR_STATUS, &reg, val);
+	writel(reg, pd->base + PPU_PWPR);
+
+	/* push write out to hardware */
+	reg = readl(pd->base + PPU_PWPR);
+
+	ret = readl_poll_timeout_atomic(pd->base + PPU_PWSR, reg,
+					FIELD_GET(PPU_PWSR_PWR_STATUS, reg) == val,
+					0, 10000);
+	if (ret)
+		dev_err(pck->dev, "failed to turn domain \"%s\" %s: %d\n",
+			genpd->name, str_on_off(on), ret);
+
+	return ret;
+}
+
+static int sunxi_pck600_power_on(struct generic_pm_domain *domain)
+{
+	struct sunxi_pck600_pd *pd = to_sunxi_pd(domain);
+
+	return sunxi_pck600_pd_set_power(pd, true);
+}
+
+static int sunxi_pck600_power_off(struct generic_pm_domain *domain)
+{
+	struct sunxi_pck600_pd *pd = to_sunxi_pd(domain);
+
+	return sunxi_pck600_pd_set_power(pd, false);
+}
+
+static void sunxi_pck600_pd_setup(struct sunxi_pck600_pd *pd,
+				  const struct sunxi_pck600_desc *desc)
+{
+	writel(desc->device_ctrl0_delay, pd->base + PPU_DCDR0);
+	writel(desc->device_ctrl1_delay, pd->base + PPU_DCDR1);
+	writel(desc->logic_power_switch0_delay,
+	       pd->base + desc->logic_power_switch0_delay_offset);
+	writel(desc->logic_power_switch1_delay,
+	       pd->base + desc->logic_power_switch1_delay_offset);
+	writel(desc->off2on_delay, pd->base + desc->off2on_delay_offset);
+}
+
+static int sunxi_pck600_probe(struct platform_device *pdev)
+{
+	struct device *dev = &pdev->dev;
+	const struct sunxi_pck600_desc *desc;
+	struct genpd_onecell_data *genpds;
+	struct sunxi_pck600 *pck;
+	struct reset_control *rst;
+	struct clk *clk;
+	void __iomem *base;
+	int i, ret;
+
+	desc = of_device_get_match_data(dev);
+
+	pck = devm_kzalloc(dev, struct_size(pck, pds, desc->num_domains), GFP_KERNEL);
+	if (!pck)
+		return -ENOMEM;
+
+	pck->dev = &pdev->dev;
+	platform_set_drvdata(pdev, pck);
+
+	genpds = &pck->genpd_data;
+	genpds->num_domains = desc->num_domains;
+	genpds->domains = devm_kcalloc(dev, desc->num_domains,
+				       sizeof(*genpds->domains), GFP_KERNEL);
+	if (!genpds->domains)
+		return -ENOMEM;
+
+	base = devm_platform_ioremap_resource(pdev, 0);
+	if (IS_ERR(base))
+		return PTR_ERR(base);
+
+	rst = devm_reset_control_get_exclusive_released(dev, NULL);
+	if (IS_ERR(rst))
+		return dev_err_probe(dev, PTR_ERR(rst), "failed to get reset control\n");
+
+	clk = devm_clk_get_enabled(dev, NULL);
+	if (IS_ERR(clk))
+		return dev_err_probe(dev, PTR_ERR(clk), "failed to get clock\n");
+
+	for (i = 0; i < desc->num_domains; i++) {
+		struct sunxi_pck600_pd *pd = &pck->pds[i];
+
+		pd->genpd.name = desc->pd_names[i];
+		pd->genpd.power_off = sunxi_pck600_power_off;
+		pd->genpd.power_on = sunxi_pck600_power_on;
+		pd->base = base + PPU_REG_SIZE * i;
+
+		sunxi_pck600_pd_setup(pd, desc);
+		ret = pm_genpd_init(&pd->genpd, NULL, false);
+		if (ret) {
+			dev_err_probe(dev, ret, "failed to initialize power domain\n");
+			goto err_remove_pds;
+		}
+
+		genpds->domains[i] = &pd->genpd;
+	}
+
+	ret = of_genpd_add_provider_onecell(dev_of_node(dev), genpds);
+	if (ret) {
+		dev_err_probe(dev, ret, "failed to add PD provider\n");
+		goto err_remove_pds;
+	}
+
+	return 0;
+
+err_remove_pds:
+	for (i--; i >= 0; i--)
+		pm_genpd_remove(genpds->domains[i]);
+
+	return ret;
+}
+
+static const char * const sun55i_a523_pck600_pd_names[] = {
+	"VE", "GPU", "VI", "VO0", "VO1", "DE", "NAND", "PCIE"
+};
+
+static const struct sunxi_pck600_desc sun55i_a523_pck600_desc = {
+	.pd_names = sun55i_a523_pck600_pd_names,
+	.num_domains = ARRAY_SIZE(sun55i_a523_pck600_pd_names),
+	.logic_power_switch0_delay_offset = 0xc00,
+	.logic_power_switch1_delay_offset = 0xc04,
+	.off2on_delay_offset = 0xc10,
+	.device_ctrl0_delay = 0xffffff,
+	.device_ctrl1_delay = 0xffff,
+	.logic_power_switch0_delay = 0x8080808,
+	.logic_power_switch1_delay = 0x808,
+	.off2on_delay = 0x8
+};
+
+static const struct of_device_id sunxi_pck600_of_match[] = {
+	{
+		.compatible	= "allwinner,sun55i-a523-pck-600",
+		.data		= &sun55i_a523_pck600_desc,
+	},
+	{}
+};
+MODULE_DEVICE_TABLE(of, sunxi_pck600_of_match);
+
+static struct platform_driver sunxi_pck600_driver = {
+	.probe = sunxi_pck600_probe,
+	.driver = {
+		.name   = "sunxi-pck-600",
+		.of_match_table = sunxi_pck600_of_match,
+		/* Power domains cannot be removed if in use. */
+		.suppress_bind_attrs = true,
+	},
+};
+module_platform_driver(sunxi_pck600_driver);
+
+MODULE_DESCRIPTION("Allwinner PCK-600 power domain driver");
+MODULE_AUTHOR("Chen-Yu Tsai <wens@csie.org>");
+MODULE_LICENSE("GPL");
-- 
2.39.5

[PATCH 4/4] arm64: dts: allwinner: a523: Add power controller device nodes

[Chen-Yu Tsai]

From: Chen-Yu Tsai <wens@csie.org>

The A523 SoC family has two power controllers, one based on the existing
PPU, and one newer one based on ARM's PCK-600.

Add device nodes for both of them.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
index 6f62201fd739..255e0ef98219 100644
--- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
@@ -7,6 +7,8 @@
 #include <dt-bindings/clock/sun55i-a523-r-ccu.h>
 #include <dt-bindings/reset/sun55i-a523-ccu.h>
 #include <dt-bindings/reset/sun55i-a523-r-ccu.h>
+#include <dt-bindings/power/allwinner,sun55i-a523-ppu.h>
+#include <dt-bindings/power/allwinner,sun55i-a523-pck600.h>
 
 / {
 	interrupt-parent = <&gic>;
@@ -576,6 +578,14 @@ mdio0: mdio {
 			};
 		};
 
+		ppu: power-controller@7001400 {
+			compatible = "allwinner,sun55i-a523-ppu";
+			reg = <0x07001400 0x400>;
+			clocks = <&r_ccu CLK_BUS_R_PPU1>;
+			resets = <&r_ccu RST_BUS_R_PPU1>;
+			#power-domain-cells = <1>;
+		};
+
 		r_ccu: clock-controller@7010000 {
 			compatible = "allwinner,sun55i-a523-r-ccu";
 			reg = <0x7010000 0x250>;
@@ -622,6 +632,14 @@ r_i2c_pins: r-i2c-pins {
 			};
 		};
 
+		pck600: power-controller@7060000 {
+			compatible = "allwinner,sun55i-a523-pck-600";
+			reg = <0x07060000 0x8000>;
+			clocks = <&r_ccu CLK_BUS_R_PPU0>;
+			resets = <&r_ccu RST_BUS_R_PPU0>;
+			#power-domain-cells = <1>;
+		};
+
 		r_i2c0: i2c@7081400 {
 			compatible = "allwinner,sun55i-a523-i2c",
 				     "allwinner,sun8i-v536-i2c",
-- 
2.39.5

Re: [PATCH 1/4] dt-bindings: power: Add A523 PPU and PCK600 power controllers

[Andre Przywara]

On Fri, 27 Jun 2025 23:29:15 +0800
Chen-Yu Tsai <wens@kernel.org> wrote:

> From: Chen-Yu Tsai <wens@csie.org>
> 
> The A523 PPU is likely the same kind of hardware seen on previous SoCs.
> 
> The A523 PCK600, as the name suggests, is likely a customized version
> of ARM's PCK-600 power controller. Comparing the BSP driver against
> ARM's PPU datasheet shows that the basic registers line up, but
> Allwinner's hardware has some additional delay controls in the reserved
> register range. As such it is likely not fully compatible with the
> standard ARM version.
> 
> Document A523 PPU and PCK600 compatibles.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Both PPUs are merely mentioned in the user manual, but do not have a
register description. But the BSP source code confirms the mapping of
the power domains used below, so:

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>  .../bindings/power/allwinner,sun20i-d1-ppu.yaml   |  2 ++
>  .../power/allwinner,sun55i-a523-pck600.h          | 15 +++++++++++++++
>  .../dt-bindings/power/allwinner,sun55i-a523-ppu.h | 12 ++++++++++++
>  3 files changed, 29 insertions(+)
>  create mode 100644 include/dt-bindings/power/allwinner,sun55i-a523-pck600.h
>  create mode 100644 include/dt-bindings/power/allwinner,sun55i-a523-ppu.h
> 
> diff --git a/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml
> index f578be6a3bc8..b9f550994512 100644
> --- a/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml
> +++ b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml
> @@ -18,6 +18,8 @@ properties:
>      enum:
>        - allwinner,sun20i-d1-ppu
>        - allwinner,sun8i-v853-ppu
> +      - allwinner,sun55i-a523-ppu
> +      - allwinner,sun55i-a523-pck-600
>  
>    reg:
>      maxItems: 1
> diff --git a/include/dt-bindings/power/allwinner,sun55i-a523-pck600.h b/include/dt-bindings/power/allwinner,sun55i-a523-pck600.h
> new file mode 100644
> index 000000000000..6b3d8ea7bb69
> --- /dev/null
> +++ b/include/dt-bindings/power/allwinner,sun55i-a523-pck600.h
> @@ -0,0 +1,15 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +
> +#ifndef _DT_BINDINGS_POWER_SUN55I_A523_PCK600_H_
> +#define _DT_BINDINGS_POWER_SUN55I_A523_PCK600_H_
> +
> +#define PD_VE			0
> +#define PD_GPU			1
> +#define PD_VI			2
> +#define PD_VO0			3
> +#define PD_VO1			4
> +#define PD_DE			5
> +#define PD_NAND			6
> +#define PD_PCIE			7
> +
> +#endif /* _DT_BINDINGS_POWER_SUN55I_A523_PCK600_H_ */
> diff --git a/include/dt-bindings/power/allwinner,sun55i-a523-ppu.h b/include/dt-bindings/power/allwinner,sun55i-a523-ppu.h
> new file mode 100644
> index 000000000000..bc9aba73c19a
> --- /dev/null
> +++ b/include/dt-bindings/power/allwinner,sun55i-a523-ppu.h
> @@ -0,0 +1,12 @@
> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
> +
> +#ifndef _DT_BINDINGS_POWER_SUN55I_A523_PPU_H_
> +#define _DT_BINDINGS_POWER_SUN55I_A523_PPU_H_
> +
> +#define PD_DSP			0
> +#define PD_NPU			1
> +#define PD_AUDIO		2
> +#define PD_SRAM			3
> +#define PD_RISCV		4
> +
> +#endif /* _DT_BINDINGS_POWER_SUN55I_A523_PPU_H_ */

Re: [PATCH 2/4] pmdomain: sunxi: sun20i-ppu: add A523 support

[Andre Przywara]

On Fri, 27 Jun 2025 23:29:16 +0800
Chen-Yu Tsai <wens@kernel.org> wrote:

> From: Chen-Yu Tsai <wens@csie.org>
> 
> A523 has a PPU like the one in the Allwinner D1 SoC.
> 
> Add a compatible entry and a list of power domain names for it.

The user manual does not describe this PPU, but the BSP code confirms
the order of the domains, so:

> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

One suggestion below, but only if you respin anyway:

> ---
>  drivers/pmdomain/sunxi/sun20i-ppu.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/drivers/pmdomain/sunxi/sun20i-ppu.c b/drivers/pmdomain/sunxi/sun20i-ppu.c
> index 9f002748d224..b65876a68cc1 100644
> --- a/drivers/pmdomain/sunxi/sun20i-ppu.c
> +++ b/drivers/pmdomain/sunxi/sun20i-ppu.c
> @@ -193,6 +193,19 @@ static const struct sun20i_ppu_desc sun8i_v853_ppu_desc = {
>  	.num_domains	= ARRAY_SIZE(sun8i_v853_ppu_pd_names),
>  };
>  
> +static const char *const sun55i_a523_ppu_pd_names[] = {
> +	"DSP",

I wonder if we should enforce the relation between the DT binding
symbols and the names here, like:

	[PD_DSP] = "DSP",
	[PD_NPU] = "NPU",
	...

Cheers,
Andre


> +	"NPU",
> +	"AUDIO",
> +	"SRAM",
> +	"RISCV",
> +};
> +
> +static const struct sun20i_ppu_desc sun55i_a523_ppu_desc = {
> +	.names		= sun55i_a523_ppu_pd_names,
> +	.num_domains	= ARRAY_SIZE(sun55i_a523_ppu_pd_names),
> +};
> +
>  static const struct of_device_id sun20i_ppu_of_match[] = {
>  	{
>  		.compatible	= "allwinner,sun20i-d1-ppu",
> @@ -202,6 +215,10 @@ static const struct of_device_id sun20i_ppu_of_match[] = {
>  		.compatible	= "allwinner,sun8i-v853-ppu",
>  		.data		= &sun8i_v853_ppu_desc,
>  	},
> +	{
> +		.compatible	= "allwinner,sun55i-a523-ppu",
> +		.data		= &sun55i_a523_ppu_desc,
> +	},
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, sun20i_ppu_of_match);

Re: [PATCH 4/4] arm64: dts: allwinner: a523: Add power controller device nodes

[Andre Przywara]

On Fri, 27 Jun 2025 23:29:18 +0800
Chen-Yu Tsai <wens@kernel.org> wrote:

> From: Chen-Yu Tsai <wens@csie.org>
> 
> The A523 SoC family has two power controllers, one based on the existing
> PPU, and one newer one based on ARM's PCK-600.
> 
> Add device nodes for both of them.

Compared against the manual, that matches up. Might be worth to mention
the reliance on your RST_BUS_R_PPU0 patch, otherwise some bots might
scream.

> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>  arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> index 6f62201fd739..255e0ef98219 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> @@ -7,6 +7,8 @@
>  #include <dt-bindings/clock/sun55i-a523-r-ccu.h>
>  #include <dt-bindings/reset/sun55i-a523-ccu.h>
>  #include <dt-bindings/reset/sun55i-a523-r-ccu.h>
> +#include <dt-bindings/power/allwinner,sun55i-a523-ppu.h>
> +#include <dt-bindings/power/allwinner,sun55i-a523-pck600.h>
>  
>  / {
>  	interrupt-parent = <&gic>;
> @@ -576,6 +578,14 @@ mdio0: mdio {
>  			};
>  		};
>  
> +		ppu: power-controller@7001400 {
> +			compatible = "allwinner,sun55i-a523-ppu";
> +			reg = <0x07001400 0x400>;
> +			clocks = <&r_ccu CLK_BUS_R_PPU1>;
> +			resets = <&r_ccu RST_BUS_R_PPU1>;
> +			#power-domain-cells = <1>;
> +		};
> +
>  		r_ccu: clock-controller@7010000 {
>  			compatible = "allwinner,sun55i-a523-r-ccu";
>  			reg = <0x7010000 0x250>;
> @@ -622,6 +632,14 @@ r_i2c_pins: r-i2c-pins {
>  			};
>  		};
>  
> +		pck600: power-controller@7060000 {
> +			compatible = "allwinner,sun55i-a523-pck-600";
> +			reg = <0x07060000 0x8000>;
> +			clocks = <&r_ccu CLK_BUS_R_PPU0>;
> +			resets = <&r_ccu RST_BUS_R_PPU0>;
> +			#power-domain-cells = <1>;
> +		};
> +
>  		r_i2c0: i2c@7081400 {
>  			compatible = "allwinner,sun55i-a523-i2c",
>  				     "allwinner,sun8i-v536-i2c",

Re: [PATCH 1/4] dt-bindings: power: Add A523 PPU and PCK600 power controllers

[Krzysztof Kozlowski]

On Fri, Jun 27, 2025 at 11:29:15PM +0800, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens@csie.org>
> 
> The A523 PPU is likely the same kind of hardware seen on previous SoCs.
> 
> The A523 PCK600, as the name suggests, is likely a customized version
> of ARM's PCK-600 power controller. Comparing the BSP driver against
> ARM's PPU datasheet shows that the basic registers line up, but
> Allwinner's hardware has some additional delay controls in the reserved
> register range. As such it is likely not fully compatible with the
> standard ARM version.
> 
> Document A523 PPU and PCK600 compatibles.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>  .../bindings/power/allwinner,sun20i-d1-ppu.yaml   |  2 ++
>  .../power/allwinner,sun55i-a523-pck600.h          | 15 +++++++++++++++
>  .../dt-bindings/power/allwinner,sun55i-a523-ppu.h | 12 ++++++++++++
>  3 files changed, 29 insertions(+)
>  create mode 100644 include/dt-bindings/power/allwinner,sun55i-a523-pck600.h
>  create mode 100644 include/dt-bindings/power/allwinner,sun55i-a523-ppu.h
> 
> diff --git a/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml
> index f578be6a3bc8..b9f550994512 100644
> --- a/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml
> +++ b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml
> @@ -18,6 +18,8 @@ properties:
>      enum:
>        - allwinner,sun20i-d1-ppu
>        - allwinner,sun8i-v853-ppu
> +      - allwinner,sun55i-a523-ppu
> +      - allwinner,sun55i-a523-pck-600

Don't add items at the end, but placed in alphabetical order. Could be
natural sort if you insist, but binding does not use it.

>  
>    reg:
>      maxItems: 1
> diff --git a/include/dt-bindings/power/allwinner,sun55i-a523-pck600.h b/include/dt-bindings/power/allwinner,sun55i-a523-pck600.h
> new file mode 100644
> index 000000000000..6b3d8ea7bb69
> --- /dev/null
> +++ b/include/dt-bindings/power/allwinner,sun55i-a523-pck600.h

Filename matching compatible (which ever one is correct).

Best regards,
Krzysztof

Re: [PATCH 1/4] dt-bindings: power: Add A523 PPU and PCK600 power controllers

[Chen-Yu Tsai]

On Tue, Jul 8, 2025 at 4:47 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Fri, Jun 27, 2025 at 11:29:15PM +0800, Chen-Yu Tsai wrote:
> > From: Chen-Yu Tsai <wens@csie.org>
> >
> > The A523 PPU is likely the same kind of hardware seen on previous SoCs.
> >
> > The A523 PCK600, as the name suggests, is likely a customized version
> > of ARM's PCK-600 power controller. Comparing the BSP driver against
> > ARM's PPU datasheet shows that the basic registers line up, but
> > Allwinner's hardware has some additional delay controls in the reserved
> > register range. As such it is likely not fully compatible with the
> > standard ARM version.
> >
> > Document A523 PPU and PCK600 compatibles.
> >
> > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> > ---
> >  .../bindings/power/allwinner,sun20i-d1-ppu.yaml   |  2 ++
> >  .../power/allwinner,sun55i-a523-pck600.h          | 15 +++++++++++++++
> >  .../dt-bindings/power/allwinner,sun55i-a523-ppu.h | 12 ++++++++++++
> >  3 files changed, 29 insertions(+)
> >  create mode 100644 include/dt-bindings/power/allwinner,sun55i-a523-pck600.h
> >  create mode 100644 include/dt-bindings/power/allwinner,sun55i-a523-ppu.h
> >
> > diff --git a/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml
> > index f578be6a3bc8..b9f550994512 100644
> > --- a/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml
> > +++ b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml
> > @@ -18,6 +18,8 @@ properties:
> >      enum:
> >        - allwinner,sun20i-d1-ppu
> >        - allwinner,sun8i-v853-ppu
> > +      - allwinner,sun55i-a523-ppu
> > +      - allwinner,sun55i-a523-pck-600
>
> Don't add items at the end, but placed in alphabetical order. Could be
> natural sort if you insist, but binding does not use it.

In our other bindings [1][2] we have them sorted by family (sunXYi)
then by SoC name. I can move sun20i-d1-ppu after sun8i-v853-ppu to get
that ordering. Obviously "-pck-600" would come before "-ppu".

Would that work for you?

[1] Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.yaml
[2] Documentation/devicetree/bindings/mmc/allwinner,sun4i-a10-mmc.yaml

(There are some out of order entries regardless.)

> >    reg:
> >      maxItems: 1
> > diff --git a/include/dt-bindings/power/allwinner,sun55i-a523-pck600.h b/include/dt-bindings/power/allwinner,sun55i-a523-pck600.h
> > new file mode 100644
> > index 000000000000..6b3d8ea7bb69
> > --- /dev/null
> > +++ b/include/dt-bindings/power/allwinner,sun55i-a523-pck600.h
>
> Filename matching compatible (which ever one is correct).

Ack. Will change to "allwinner,sun55i-a523-pck-600.h".

Thanks
ChenYu

Re: [PATCH 1/4] dt-bindings: power: Add A523 PPU and PCK600 power controllers

[Krzysztof Kozlowski]

On 08/07/2025 10:55, Chen-Yu Tsai wrote:
> On Tue, Jul 8, 2025 at 4:47 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Fri, Jun 27, 2025 at 11:29:15PM +0800, Chen-Yu Tsai wrote:
>>> From: Chen-Yu Tsai <wens@csie.org>
>>>
>>> The A523 PPU is likely the same kind of hardware seen on previous SoCs.
>>>
>>> The A523 PCK600, as the name suggests, is likely a customized version
>>> of ARM's PCK-600 power controller. Comparing the BSP driver against
>>> ARM's PPU datasheet shows that the basic registers line up, but
>>> Allwinner's hardware has some additional delay controls in the reserved
>>> register range. As such it is likely not fully compatible with the
>>> standard ARM version.
>>>
>>> Document A523 PPU and PCK600 compatibles.
>>>
>>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>>> ---
>>>  .../bindings/power/allwinner,sun20i-d1-ppu.yaml   |  2 ++
>>>  .../power/allwinner,sun55i-a523-pck600.h          | 15 +++++++++++++++
>>>  .../dt-bindings/power/allwinner,sun55i-a523-ppu.h | 12 ++++++++++++
>>>  3 files changed, 29 insertions(+)
>>>  create mode 100644 include/dt-bindings/power/allwinner,sun55i-a523-pck600.h
>>>  create mode 100644 include/dt-bindings/power/allwinner,sun55i-a523-ppu.h
>>>
>>> diff --git a/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml
>>> index f578be6a3bc8..b9f550994512 100644
>>> --- a/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml
>>> +++ b/Documentation/devicetree/bindings/power/allwinner,sun20i-d1-ppu.yaml
>>> @@ -18,6 +18,8 @@ properties:
>>>      enum:
>>>        - allwinner,sun20i-d1-ppu
>>>        - allwinner,sun8i-v853-ppu
>>> +      - allwinner,sun55i-a523-ppu
>>> +      - allwinner,sun55i-a523-pck-600
>>
>> Don't add items at the end, but placed in alphabetical order. Could be
>> natural sort if you insist, but binding does not use it.
> 
> In our other bindings [1][2] we have them sorted by family (sunXYi)

Sure, choose whatever sorting rule you want but then YOU must review
this on every binding, because we do not and we cannot know that family
information.

But if this is the sorting here, why "20" is before 8? In other places
it is after.

So yeah, you have chosen complicated sorting which no one from DT
maintainers gets and you do not enforce clarify...

Best regards,
Krzysztof

Re: [PATCH 3/4] pmdomain: sunxi: add driver for Allwinner A523's PCK-600 power controller

[Ulf Hansson]

On Fri, 27 Jun 2025 at 17:29, Chen-Yu Tsai <wens@kernel.org> wrote:
>
> From: Chen-Yu Tsai <wens@csie.org>
>
> Allwinner A523 family has a second power controller, named PCK-600 in
> the datasheets and BSP. It is likely based on ARM's PCK-600 hardware
> block, with some additional delay controls. The only documentation for
> this hardware is the BSP driver. The standard registers defined in ARM's
> Power Policy Unit Architecture Specification line up. Some extra delay
> controls are found in the reserved range of registers.
>
> Add a driver for this power controller. Delay control register values
> and power domain names are from the BSP driver.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

FYI, this looks good to me.

Kind regards
Uffe

> ---
>  drivers/pmdomain/sunxi/Kconfig         |   8 +
>  drivers/pmdomain/sunxi/Makefile        |   1 +
>  drivers/pmdomain/sunxi/sun55i-pck600.c | 225 +++++++++++++++++++++++++
>  3 files changed, 234 insertions(+)
>  create mode 100644 drivers/pmdomain/sunxi/sun55i-pck600.c
>
> diff --git a/drivers/pmdomain/sunxi/Kconfig b/drivers/pmdomain/sunxi/Kconfig
> index 43eecb3ea981..3e2b77cd9a2b 100644
> --- a/drivers/pmdomain/sunxi/Kconfig
> +++ b/drivers/pmdomain/sunxi/Kconfig
> @@ -18,3 +18,11 @@ config SUN50I_H6_PRCM_PPU
>           Say y to enable the Allwinner H6/H616 PRCM power domain driver.
>           This is required to enable the Mali GPU in the H616 SoC, it is
>           optional for the H6.
> +
> +config SUN55I_PCK600
> +       bool "Allwinner A523 PCK-600 power domain driver"
> +       depends on PM
> +       select PM_GENERIC_DOMAINS
> +       help
> +         Say y to enable the PCK-600 power domain driver. This saves power
> +         when certain peripherals, such as the video engine, are idle.
> diff --git a/drivers/pmdomain/sunxi/Makefile b/drivers/pmdomain/sunxi/Makefile
> index c1343e123759..e344b232fc9f 100644
> --- a/drivers/pmdomain/sunxi/Makefile
> +++ b/drivers/pmdomain/sunxi/Makefile
> @@ -1,3 +1,4 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  obj-$(CONFIG_SUN20I_PPU)               += sun20i-ppu.o
>  obj-$(CONFIG_SUN50I_H6_PRCM_PPU)       += sun50i-h6-prcm-ppu.o
> +obj-$(CONFIG_SUN55I_PCK600)            += sun55i-pck600.o
> diff --git a/drivers/pmdomain/sunxi/sun55i-pck600.c b/drivers/pmdomain/sunxi/sun55i-pck600.c
> new file mode 100644
> index 000000000000..7248f6113665
> --- /dev/null
> +++ b/drivers/pmdomain/sunxi/sun55i-pck600.c
> @@ -0,0 +1,225 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Allwinner PCK-600 power domain support
> + *
> + * Copyright (c) 2025 Chen-Yu Tsai <wens@csie.org>
> + */
> +
> +#include <linux/bitfield.h>
> +#include <linux/clk.h>
> +#include <linux/container_of.h>
> +#include <linux/device.h>
> +#include <linux/dev_printk.h>
> +#include <linux/err.h>
> +#include <linux/io.h>
> +#include <linux/iopoll.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/platform_device.h>
> +#include <linux/pm_domain.h>
> +#include <linux/reset.h>
> +#include <linux/slab.h>
> +#include <linux/string_choices.h>
> +
> +#define PPU_PWPR    0x0
> +#define PPU_PWSR    0x8
> +#define        PPU_DCDR0   0x170
> +#define PPU_DCDR1   0x174
> +
> +#define PPU_PWSR_PWR_STATUS    GENMASK(3, 0)
> +#define PPU_POWER_MODE_ON      0x8
> +#define PPU_POWER_MODE_OFF     0x0
> +
> +#define PPU_REG_SIZE   0x1000
> +
> +struct sunxi_pck600_desc {
> +       const char * const *pd_names;
> +       unsigned int num_domains;
> +       u32 logic_power_switch0_delay_offset;
> +       u32 logic_power_switch1_delay_offset;
> +       u32 off2on_delay_offset;
> +       u32 device_ctrl0_delay;
> +       u32 device_ctrl1_delay;
> +       u32 logic_power_switch0_delay;
> +       u32 logic_power_switch1_delay;
> +       u32 off2on_delay;
> +};
> +
> +struct sunxi_pck600_pd {
> +       struct generic_pm_domain genpd;
> +       struct sunxi_pck600 *pck;
> +       void __iomem *base;
> +};
> +
> +struct sunxi_pck600 {
> +       struct device *dev;
> +       struct genpd_onecell_data genpd_data;
> +       struct sunxi_pck600_pd pds[];
> +};
> +
> +#define to_sunxi_pd(gpd) container_of(gpd, struct sunxi_pck600_pd, genpd)
> +
> +static int sunxi_pck600_pd_set_power(struct sunxi_pck600_pd *pd, bool on)
> +{
> +       struct sunxi_pck600 *pck = pd->pck;
> +       struct generic_pm_domain *genpd = &pd->genpd;
> +       int ret;
> +       u32 val, reg;
> +
> +       val = on ? PPU_POWER_MODE_ON : PPU_POWER_MODE_OFF;
> +
> +       reg = readl(pd->base + PPU_PWPR);
> +       FIELD_MODIFY(PPU_PWSR_PWR_STATUS, &reg, val);
> +       writel(reg, pd->base + PPU_PWPR);
> +
> +       /* push write out to hardware */
> +       reg = readl(pd->base + PPU_PWPR);
> +
> +       ret = readl_poll_timeout_atomic(pd->base + PPU_PWSR, reg,
> +                                       FIELD_GET(PPU_PWSR_PWR_STATUS, reg) == val,
> +                                       0, 10000);
> +       if (ret)
> +               dev_err(pck->dev, "failed to turn domain \"%s\" %s: %d\n",
> +                       genpd->name, str_on_off(on), ret);
> +
> +       return ret;
> +}
> +
> +static int sunxi_pck600_power_on(struct generic_pm_domain *domain)
> +{
> +       struct sunxi_pck600_pd *pd = to_sunxi_pd(domain);
> +
> +       return sunxi_pck600_pd_set_power(pd, true);
> +}
> +
> +static int sunxi_pck600_power_off(struct generic_pm_domain *domain)
> +{
> +       struct sunxi_pck600_pd *pd = to_sunxi_pd(domain);
> +
> +       return sunxi_pck600_pd_set_power(pd, false);
> +}
> +
> +static void sunxi_pck600_pd_setup(struct sunxi_pck600_pd *pd,
> +                                 const struct sunxi_pck600_desc *desc)
> +{
> +       writel(desc->device_ctrl0_delay, pd->base + PPU_DCDR0);
> +       writel(desc->device_ctrl1_delay, pd->base + PPU_DCDR1);
> +       writel(desc->logic_power_switch0_delay,
> +              pd->base + desc->logic_power_switch0_delay_offset);
> +       writel(desc->logic_power_switch1_delay,
> +              pd->base + desc->logic_power_switch1_delay_offset);
> +       writel(desc->off2on_delay, pd->base + desc->off2on_delay_offset);
> +}
> +
> +static int sunxi_pck600_probe(struct platform_device *pdev)
> +{
> +       struct device *dev = &pdev->dev;
> +       const struct sunxi_pck600_desc *desc;
> +       struct genpd_onecell_data *genpds;
> +       struct sunxi_pck600 *pck;
> +       struct reset_control *rst;
> +       struct clk *clk;
> +       void __iomem *base;
> +       int i, ret;
> +
> +       desc = of_device_get_match_data(dev);
> +
> +       pck = devm_kzalloc(dev, struct_size(pck, pds, desc->num_domains), GFP_KERNEL);
> +       if (!pck)
> +               return -ENOMEM;
> +
> +       pck->dev = &pdev->dev;
> +       platform_set_drvdata(pdev, pck);
> +
> +       genpds = &pck->genpd_data;
> +       genpds->num_domains = desc->num_domains;
> +       genpds->domains = devm_kcalloc(dev, desc->num_domains,
> +                                      sizeof(*genpds->domains), GFP_KERNEL);
> +       if (!genpds->domains)
> +               return -ENOMEM;
> +
> +       base = devm_platform_ioremap_resource(pdev, 0);
> +       if (IS_ERR(base))
> +               return PTR_ERR(base);
> +
> +       rst = devm_reset_control_get_exclusive_released(dev, NULL);
> +       if (IS_ERR(rst))
> +               return dev_err_probe(dev, PTR_ERR(rst), "failed to get reset control\n");
> +
> +       clk = devm_clk_get_enabled(dev, NULL);
> +       if (IS_ERR(clk))
> +               return dev_err_probe(dev, PTR_ERR(clk), "failed to get clock\n");
> +
> +       for (i = 0; i < desc->num_domains; i++) {
> +               struct sunxi_pck600_pd *pd = &pck->pds[i];
> +
> +               pd->genpd.name = desc->pd_names[i];
> +               pd->genpd.power_off = sunxi_pck600_power_off;
> +               pd->genpd.power_on = sunxi_pck600_power_on;
> +               pd->base = base + PPU_REG_SIZE * i;
> +
> +               sunxi_pck600_pd_setup(pd, desc);
> +               ret = pm_genpd_init(&pd->genpd, NULL, false);
> +               if (ret) {
> +                       dev_err_probe(dev, ret, "failed to initialize power domain\n");
> +                       goto err_remove_pds;
> +               }
> +
> +               genpds->domains[i] = &pd->genpd;
> +       }
> +
> +       ret = of_genpd_add_provider_onecell(dev_of_node(dev), genpds);
> +       if (ret) {
> +               dev_err_probe(dev, ret, "failed to add PD provider\n");
> +               goto err_remove_pds;
> +       }
> +
> +       return 0;
> +
> +err_remove_pds:
> +       for (i--; i >= 0; i--)
> +               pm_genpd_remove(genpds->domains[i]);
> +
> +       return ret;
> +}
> +
> +static const char * const sun55i_a523_pck600_pd_names[] = {
> +       "VE", "GPU", "VI", "VO0", "VO1", "DE", "NAND", "PCIE"
> +};
> +
> +static const struct sunxi_pck600_desc sun55i_a523_pck600_desc = {
> +       .pd_names = sun55i_a523_pck600_pd_names,
> +       .num_domains = ARRAY_SIZE(sun55i_a523_pck600_pd_names),
> +       .logic_power_switch0_delay_offset = 0xc00,
> +       .logic_power_switch1_delay_offset = 0xc04,
> +       .off2on_delay_offset = 0xc10,
> +       .device_ctrl0_delay = 0xffffff,
> +       .device_ctrl1_delay = 0xffff,
> +       .logic_power_switch0_delay = 0x8080808,
> +       .logic_power_switch1_delay = 0x808,
> +       .off2on_delay = 0x8
> +};
> +
> +static const struct of_device_id sunxi_pck600_of_match[] = {
> +       {
> +               .compatible     = "allwinner,sun55i-a523-pck-600",
> +               .data           = &sun55i_a523_pck600_desc,
> +       },
> +       {}
> +};
> +MODULE_DEVICE_TABLE(of, sunxi_pck600_of_match);
> +
> +static struct platform_driver sunxi_pck600_driver = {
> +       .probe = sunxi_pck600_probe,
> +       .driver = {
> +               .name   = "sunxi-pck-600",
> +               .of_match_table = sunxi_pck600_of_match,
> +               /* Power domains cannot be removed if in use. */
> +               .suppress_bind_attrs = true,
> +       },
> +};
> +module_platform_driver(sunxi_pck600_driver);
> +
> +MODULE_DESCRIPTION("Allwinner PCK-600 power domain driver");
> +MODULE_AUTHOR("Chen-Yu Tsai <wens@csie.org>");
> +MODULE_LICENSE("GPL");
> --
> 2.39.5
>