From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F1B7289E0F; Fri, 27 Jun 2025 21:32:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751059964; cv=none; b=LFxC4nDQR/GiRm93Y07ZJ7KLw9Vgfmmi+htK6qjq69VvpbcBpxjANctN5yKWvepgDzBg7j/+BQqnTRQsmGnm6cy1SFb441fFBZHXJ6Jm7OExEEe/PzDnCwYEK/ijuqYePMDTe6kMHXDXBUDAcn36+iAdVzMFjHEfrsbGSXOJyng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751059964; c=relaxed/simple; bh=eESCjft7xsEYKmoabjp8my7YY1IIc+dHMAl27BLkGmw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TcfR4gLIE1sOTmuJgFMXRIcwumid9mF+RNn03RLfjDP4YrKQy8SY4nZz1aIpfv2jDP8cgB4c/n2quMP7MiilfMNQcQvljpubcaaVIsYB7hxq4g7zJxOfAXmWKlBYfad7N1T7sHYfdY8B2WLdhDA6gQ5bFYPyomBsGchHgo1mAd8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IXZJr6Cf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IXZJr6Cf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7D18C4CEE3; Fri, 27 Jun 2025 21:32:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751059962; bh=eESCjft7xsEYKmoabjp8my7YY1IIc+dHMAl27BLkGmw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IXZJr6CfuxBkcfN8mZSn9MAoIkUuXaEy2JhX2uh2CQ5+wDL6J6HIKYdf6QuRbb4Xq i5zffCh21MBYbP/lUKV+Jq8h4CnTNEoKpgTa7LaVp/m6V+GlE4ly/iWiZazEbfOQnX vu7DThsboBweTluoTrIY2DNsHHWx8j3LDJ1kBIGabVv4k/ML+/4BldBnY3LJo7uIpJ xkfLVlb6HHtTpXPZ8q31XLO+neTDlA1TUL27U4fZyMm3VG3Xv6xqe3sG6B6zhpCVru fuNDfwUXv83ckLLxitPDEPll6B5P1OiwUP6PagGLygGxjDJD5OppcRjEZbvA5JqOX7 DUw9qwaqbe5OQ== Date: Fri, 27 Jun 2025 16:32:41 -0500 From: Rob Herring To: Lorenzo Pieralisi Cc: Marc Zyngier , Thomas Gleixner , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Arnd Bergmann , Sascha Bischoff , Jonathan Cameron , Timothy Hayes , Bjorn Helgaas , "Liam R. Howlett" , Peter Maydell , Mark Rutland , Jiri Slaby , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v6 24/31] of/irq: Add of_msi_xlate() helper function Message-ID: <20250627213241.GA168190-robh@kernel.org> References: <20250626-gicv5-host-v6-0-48e046af4642@kernel.org> <20250626-gicv5-host-v6-24-48e046af4642@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250626-gicv5-host-v6-24-48e046af4642@kernel.org> On Thu, Jun 26, 2025 at 12:26:15PM +0200, Lorenzo Pieralisi wrote: > Add an of_msi_xlate() helper that maps a device ID and returns > the device node of the MSI controller the device ID is mapped to. > > Required by core functions that need an MSI controller device node > pointer at the same time as a mapped device ID, of_msi_map_id() is not > sufficient for that purpose. > > Signed-off-by: Lorenzo Pieralisi > Cc: Rob Herring > Cc: Marc Zyngier > --- > drivers/of/irq.c | 22 +++++++++++++++++----- > include/linux/of_irq.h | 5 +++++ > 2 files changed, 22 insertions(+), 5 deletions(-) > > diff --git a/drivers/of/irq.c b/drivers/of/irq.c > index f8ad79b9b1c9..74aaea61de13 100644 > --- a/drivers/of/irq.c > +++ b/drivers/of/irq.c > @@ -670,8 +670,20 @@ void __init of_irq_init(const struct of_device_id *matches) > } > } > > -static u32 __of_msi_map_id(struct device *dev, struct device_node **np, > - u32 id_in) > +/** > + * of_msi_xlate - map a MSI ID and find relevant MSI controller node > + * @dev: device for which the mapping is to be done. > + * @msi_np: Pointer to store the MSI controller node > + * @id_in: Device ID. > + * > + * Walk up the device hierarchy looking for devices with a "msi-map" > + * property. If found, apply the mapping to @id_in. @msi_np pointed > + * value must be NULL on entry, if an MSI controller is found @msi_np is > + * initialized to the MSI controller node with a reference held. > + * > + * Returns: The mapped MSI id. > + */ > +u32 of_msi_xlate(struct device *dev, struct device_node **msi_np, u32 id_in) > { > struct device *parent_dev; > u32 id_out = id_in; > @@ -682,7 +694,7 @@ static u32 __of_msi_map_id(struct device *dev, struct device_node **np, > */ > for (parent_dev = dev; parent_dev; parent_dev = parent_dev->parent) > if (!of_map_id(parent_dev->of_node, id_in, "msi-map", > - "msi-map-mask", np, &id_out)) > + "msi-map-mask", msi_np, &id_out)) > break; > return id_out; > } > @@ -700,7 +712,7 @@ static u32 __of_msi_map_id(struct device *dev, struct device_node **np, > */ > u32 of_msi_map_id(struct device *dev, struct device_node *msi_np, u32 id_in) Can we replace the 2 callers of of_msi_map_id() with of_msi_xlate()? The series is already big enough, so that can be a follow-up or do it for 6.17 if the series isn't going to make it. Rob