From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DA8222D4E2; Mon, 30 Jun 2025 22:54:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751324049; cv=none; b=YsP4+F1UldXC53afJHrZgc3+hFkZoTgAMpg/Ng9TQ9dslMAQweQrUGeDpu3sf9ttrAsmHbf188P3u/xE8rZTcl+KZqQJ0VlG5QCHWzgSEiOJMV/SiPjGlIESAU3bu45wuGGoXybSIyge18O1ZE0IS5BXlddIIpkxrd0Y2ky9F7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751324049; c=relaxed/simple; bh=PMwHxVkTMhzSzmWBoqtTU/1p6pXwdtTxDXDq548MxLg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kJDtHp6BD/EsUAObxCKHnZG22JrEYgcZAlTLFB9l8+ZsZfstLuE0V4Uuami/sa9FMdAG9GRsN9MAWIISDh1sRtSmBIeyHq0NFslUlPx7NVzwvBIkPA7KhIm33eyu56t010uZNTXYlsg3ivcYMaMNN1bqmn/VfBShx81O/2XTZE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=Aktzmh3p; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Aktzmh3p" Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 32AF0928; Tue, 1 Jul 2025 00:53:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1751324024; bh=PMwHxVkTMhzSzmWBoqtTU/1p6pXwdtTxDXDq548MxLg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Aktzmh3pruEQ9vIZp7+/i6bf3S2+zXIT5kJO25xsoAvYBiWrdNhIffZ7OCISRGxxH MjtuCZnm1nzC4SwtRrIRWscOpc2b/3kybtwCXq2wqqrnxbTOgvudscVGUcqMJZAbRb LdqzNy8uV/DcLeI+ED2xf79Kizju3H0tZpZq1R/c= Date: Tue, 1 Jul 2025 01:53:40 +0300 From: Laurent Pinchart To: Frank Li Cc: Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Alice Yuan Subject: Re: [PATCH 2/5] dt-bindings: media: add i.MX parallel csi support Message-ID: <20250630225340.GE15184@pendragon.ideasonboard.com> References: <20250630-imx8qxp_pcam-v1-0-eccd38d99201@nxp.com> <20250630-imx8qxp_pcam-v1-2-eccd38d99201@nxp.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250630-imx8qxp_pcam-v1-2-eccd38d99201@nxp.com> Hi Frank, Alice, Thank you for the patch. On Mon, Jun 30, 2025 at 06:28:18PM -0400, Frank Li wrote: > From: Alice Yuan > > Document the binding for parallel CSI controller found in i.MX8QXP, i.MX93 > and i.MX91 SoCs. > > Signed-off-by: Alice Yuan > Signed-off-by: Frank Li > --- > .../bindings/media/fsl,imx93-parallel-csi.yaml | 108 +++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 109 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/fsl,imx93-parallel-csi.yaml b/Documentation/devicetree/bindings/media/fsl,imx93-parallel-csi.yaml > new file mode 100644 > index 0000000000000..b4657c913adad > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/fsl,imx93-parallel-csi.yaml > @@ -0,0 +1,108 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/fsl,imx93-parallel-csi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: i.MX8/9 Parallel Camera Interface > + > +maintainers: > + - Frank Li > + > +description: | > + This is device node for the Parallel Camera Interface which enables the > + chip to connect directly to external Parallel CMOS image sensors. > + Supports up to 80MHz input clock from sensor. > + Supports the following input data formats > + - 8-bit/10-bit Camera Sensor Interface (CSI) > + - 8-bit data port for RGB, YCbCr, and YUV data input > + - 8-bit/10-bit data ports for Bayer data input > + Parallel Camera Interface is hooked to the Imaging subsystem via the > + Pixel Link. > + > +properties: > + compatible: > + oneOf: > + - const: fsl,imx8qxp-parallel-csi Is there any chance we could avoid calling this "csi", given that the whole block is called "Parallel Capture Interface" in the reference manual ? "CSI" is horribly confusing as it usually refers to MIPI CSI-2. I suppose calling it "PCI" for "Parallel Capture Interface" wouldn't help :-/ > + - items: > + - enum: > + - fsl,imx91-parallel-csi > + - const: fsl,imx93-parallel-csi > + - const: fsl,imx93-parallel-csi > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: pixel > + - const: ipg > + > + power-domains: > + maxItems: 1 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: > + Input port node. > + > + port@1: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: > + Output port node. > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - ports Patch 4/5 lists a power domain, and so does the example below for i.MX93. Should the power-domains property be mandatory ? > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + parallel-csi@4ac10070 { > + compatible = "fsl,imx93-parallel-csi"; > + reg = <0x4ac10070 0x10>; The i.MX93 reference manual doesn't document the register set for this block, so I have a hard time reviewing this. Is there a plan to publish a new version of the reference manual with the complete documentation for the parallel interface ? > + clocks = <&clk IMX93_CLK_MIPI_CSI_GATE>, > + <&clk IMX93_CLK_MEDIA_APB>; > + clock-names = "pixel", "ipg"; > + assigned-clocks = <&clk IMX93_CLK_CAM_PIX>; > + assigned-clock-parents = <&clk IMX93_CLK_VIDEO_PLL>; > + assigned-clock-rates = <140000000>; > + power-domains = <&media_blk_ctrl IMX93_MEDIABLK_PD_MIPI_CSI>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + endpoint { > + remote-endpoint = <&mt9m114_ep>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + endpoint { > + remote-endpoint = <&isi_in>; > + }; > + }; > + }; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 8dc0f6609d1fe..3bd6772c11539 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -15107,6 +15107,7 @@ L: linux-media@vger.kernel.org > S: Maintained > T: git git://linuxtv.org/media.git > F: Documentation/admin-guide/media/imx7.rst > +F: Documentation/devicetree/bindings/media/fsl,imx93-parallel-csi.yaml > F: Documentation/devicetree/bindings/media/nxp,imx-mipi-csi2.yaml > F: Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > F: Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml -- Regards, Laurent Pinchart