From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99C9C225A31; Wed, 2 Jul 2025 11:38:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751456326; cv=none; b=aI59W70qMYM4fQ3TIg/dsXQ+Vxt/0K/6URaqBzQCLuMUjks4ZZT+YQ19L4v/zOEjQ5nVAzRFui2NjW1LirwS6kmo012sscp8bC9sxKXuCVk3/slKtrPM6G3SOcYeF3yZk2ri1N+LX1qN5e8RE2pAM0+EVDP03amdZ1tTRH9fGzs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751456326; c=relaxed/simple; bh=6D65NQrcz7NwOKOr8hiTmabKhGb17NOweOxgq2rLoRU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SBpoKhhIHnqpggB+QTWl+9L9JA8BUXa5IFUAUlM/czuMEAe2UWa5R9qF3VrDoMtPzr5tRuiVgw5EEm3bJiYKTVju9oXV7qXWNGe5r1KhbJGmIUyn1tU2cG7Wnp4J2FXiKxzFZf647xDeWw4E09d17zQ5u5+7KOsedVnVbcQJKf0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oKuHx5Xm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oKuHx5Xm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01412C4CEED; Wed, 2 Jul 2025 11:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751456326; bh=6D65NQrcz7NwOKOr8hiTmabKhGb17NOweOxgq2rLoRU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oKuHx5XmFRNHZtV5pSfKZMRhbFK9Q/V8oBQttSQwv9h1BoZj2mm169T+YyXbMPl35 MkWW3EY3dKtbc8PrPx3G1R0Hz0CZYoKi1R8NejVaAjeAQBNFp1H67e0eSXN49NUzyU 8nWheZ/Z3Ej0ul4a/+WASK+txRA2lLb1VhQgkZ+OVdYhxvh+BpWMr88wnW7FyPmn0Y YwYHjIcQsY0BF3n/c7nHKDYuObm3MF0BchGYbyrLOXQUFsI7fOupP6s8YttGBDroTl C2Go5SyvImfXwciAAzFTpR5fLmc736by4kg3aDbnHQXBU8rCI/Q2gEvGnhQym960Mp LBq5wdH5IqiYg== Date: Wed, 2 Jul 2025 12:38:41 +0100 From: Conor Dooley To: Jorge Marques Cc: Krzysztof Kozlowski , Jorge Marques , Alexandre Belloni , Frank Li , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-i3c@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/2] dt-bindings: i3c: Add adi-i3c-master Message-ID: <20250702-armchair-favorite-c734b53444e2@spud> References: <20250626-adi-i3c-master-v4-0-3846a1f66d5e@analog.com> <20250626-adi-i3c-master-v4-1-3846a1f66d5e@analog.com> <20250627-steadfast-ferret-of-expertise-5c8ff2@krzk-bin> <41782ded-908b-46ef-8f75-4d2565476b7c@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AzTkVZ/OYZqMKI4S" Content-Disposition: inline In-Reply-To: --AzTkVZ/OYZqMKI4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 02, 2025 at 12:58:00PM +0200, Jorge Marques wrote: > On Fri, Jun 27, 2025 at 06:02:26PM +0200, Jorge Marques wrote: > > On Fri, Jun 27, 2025 at 04:49:19PM +0200, Krzysztof Kozlowski wrote: > > > On 27/06/2025 16:38, Jorge Marques wrote: > > > > On Fri, Jun 27, 2025 at 08:56:55AM +0200, Krzysztof Kozlowski wrote: > > > >> On Thu, Jun 26, 2025 at 12:07:36PM +0200, Jorge Marques wrote: > > > >>> Add bindings doc for ADI I3C Controller IP core, a FPGA synthesiz= able IP > > > >>> core that implements the MIPI I3C Basic controller specification. > > > >> > > > >> How did you resolve my last comment? I don't see any explanation - > > > >> neither here nor in the binding description. Binding description is > > > >> actually better place, I think now. > > > >> > > > >> Best regards, > > > >> Krzysztof > > > >> > > > >=20 > > > > Hi Krzysztof, > > > >=20 > > > > I forgot to condense out discussion on v4. > > > > What about this binding description: > > > >=20 > > > > description: | > > > > FPGA-based I3C controller designed to interface with I3C and I2C > > > > peripherals, implementing a subset of the I3C-basic specificati= on. > > > > The IP core is tested on arm, microblaze, and arm64 architectur= es. > > > > It takes one or two clocks, axi and i3c. If only axi is provide= d, > > > > then there is no clock signal to the i3c input clock pin and axi > > >=20 > > > This is obvious from the schema, drop. > > Ack. > >=20 > > >=20 > > > > clock drives the whole IP. The compatible is suffixed by 1.00.a > > > > foreseeing future controllers by Analog Devices Inc. and breaki= ng > > > > changes. > > >=20 > > > I don't understand that. How are you breaking any changes? And how > > > 1.00.a predicts future? I don't think this reflects previous discussi= on. > > > Why you were asked to go with v1.00.a? > > The -1.00.a suffix came from this discussion: > > =20 > > https://lore.kernel.org/linux-i3c/ildi2pup2zkyv4stuknkrjysex3yzsbrrsr= wbgcc4xgvdhwrdd@7qh4y6mutgy2/ > >=20 > > Other adi bindings use this suffix. I personally wouldn't add any suffix > > unless told otherwise, as I expressed on the thread. Should I drop it? > > or suffix it with something else? >=20 > I went after the reason of the historically -1.00.a suffix and > discovered that they came into existence due to AMD Xilinx auto > generation devicetree tool SDTGen > https://github.com/Xilinx/system-device-tree-xlnx > that would automatically suffix with the IP version, defaulting to 1.00.a, > and for a seamless experience, the were copied over to the dt-bindings. >=20 > The adi,axi-pwmgen dt-binding went more creative and suffixed with > -2.00.a, while never enforcing Vivado to yield the devicetree with such > value (Major version is asserted in the driver through reg access, the > current core version is v2.1.1) >=20 > Testing on my side (AMD Xilinx Vivado 2024.2), it seems Vivado now > defaults to 1.0, so the previous bindings from the other IPs are not > accurate anymore, either, (axi-pwmgen auto gens > `compatible =3D "xlnx,axi-pwm-gen-1.0";` (`xlnx` instead of `adi`, also)). >=20 > For fun, the current Vivado version thinks the devicetree node for the > i3c master should be as follows: >=20 > i3c_host_interface: i3c_controller_host_interface@44a00000 { > compatible =3D "xlnx,i3c-controller-host-interface-1.0"; > reg =3D <0x44a00000 0x10000>; > clocks =3D <&clkc 15>; > clock-names =3D "s_axi_aclk"; > }; >=20 > Let me know if we can drop the suffix, or replace with something else. > The current register defined core version is v0.1.0. Please, as I requested in the original thread, add versioning information. I'm clearly not asking you to make up some garbage version number, or to add "1.00a" if that's not an accurate version (and never did AFAICT). If 0.1.0 is the version of the IP core, I'd like you to use that. If other ADI IP cores are using crap version numbers that came from some Xilinx tooling that don't represent the actual versions of the IPs, that's probably something you should mention to your colleagues that maintain those bindings. --AzTkVZ/OYZqMKI4S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaGUaQQAKCRB4tDGHoIJi 0opmAP90ILv17HBwblHZxoE06P46Yei39DKWzTDARH4j+CqtygEA90BCiZRJSpUP Hnr5ERbaqQ4vUWt8259P3N6dpG43SAM= =0JJi -----END PGP SIGNATURE----- --AzTkVZ/OYZqMKI4S--