From: Krzysztof Kozlowski <krzk@kernel.org>
To: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, conor+dt@kernel.org, krzk+dt@kernel.org,
robh@kernel.org, jean-baptiste.maneyrol@tdk.com,
~lkcamp/patches@lists.sr.ht, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: iio: pressure: add invensense,icp10100
Date: Thu, 3 Jul 2025 09:38:14 +0200 [thread overview]
Message-ID: <20250703-rational-laughing-hedgehog-cc0eec@krzk-bin> (raw)
In-Reply-To: <20250701221700.34921-1-rodrigo.gobbi.7@gmail.com>
On Tue, Jul 01, 2025 at 07:05:43PM -0300, Rodrigo Gobbi wrote:
> +$id: http://devicetree.org/schemas/iio/pressure/invensense,icp10100.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: InvenSense ICP-101xx Barometric Pressure Sensors
> +
> +maintainers:
> + - Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
> +
> +description: |
> + Support for ICP-101xx family: ICP-10100, ICP-10101, ICP-10110, ICP-10111.
The problem with title and description here is that they do not match
compatible. oneOf:
1. Your statement is correct, but then compatibles are incomplete and
will encourage people to use incomplete compatibles for e.g. ICP-10111.
2. Compatible is correct but your statement is not correct, so then fix
the statement - drop other devices.
Assuming 1 is closer to truth, then I suggest to express it with
documenting these compatibles and using invensense,icp10100 as fallback.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-07-03 7:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 22:05 [PATCH v2] dt-bindings: iio: pressure: add invensense,icp10100 Rodrigo Gobbi
2025-07-03 7:38 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250703-rational-laughing-hedgehog-cc0eec@krzk-bin \
--to=krzk@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=rodrigo.gobbi.7@gmail.com \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox