Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>,
	 Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	 Stephen Boyd <sboyd@kernel.org>,
	Ajit Pandey <quic_ajipan@quicinc.com>,
	 Imran Shaik <quic_imrashai@quicinc.com>,
	Taniya Das <quic_tdas@quicinc.com>,
	 Jagadeesh Kona <quic_jkona@quicinc.com>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible
Date: Thu, 3 Jul 2025 09:25:24 +0200	[thread overview]
Message-ID: <20250703-robust-analytic-hummingbird-88eb3b@krzk-bin> (raw)
In-Reply-To: <mzmer4g7df7xqhnstpfhyzcm2irpmsk4iwtx6esjksp34lpkk5@76lrsoyb5cp6>

On Thu, Jul 03, 2025 at 01:29:06AM +0300, Dmitry Baryshkov wrote:
> > -      - qcom,sc7180-videocc
> > -      - qcom,sc7280-videocc
> > -      - qcom,sdm845-videocc
> > -      - qcom,sm6350-videocc
> > -      - qcom,sm8150-videocc
> > -      - qcom,sm8250-videocc
> > +    oneOf:
> > +      - enum:
> > +          - qcom,sc7180-videocc
> > +          - qcom,sc7280-videocc
> > +          - qcom,sdm845-videocc
> > +          - qcom,sm6350-videocc
> > +          - qcom,sm8150-videocc
> > +          - qcom,sm8250-videocc
> > +      - items:
> > +          - const: qcom,sc8180x-videocc
> > +          - const: qcom,sm8150-videocc
> >  
> >    clocks:
> >      minItems: 1
> > @@ -111,6 +115,7 @@ allOf:
> >        properties:
> >          compatible:
> >            enum:
> > +            - qcom,sc8180x-videocc
> 
> Is there a need for this? Isn't it already covered by the SM8150 entry?

Yes and no. Yes - some change here is needed as I explained. No - this
exact change does not work, so it is obviously redundant.

Best regards,
Krzysztof


  reply	other threads:[~2025-07-03  7:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02 15:13 [PATCH v3 0/2] Add video clock controller DT support for sc8180x Satya Priya Kakitapalli
2025-07-02 15:13 ` [PATCH v3 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible Satya Priya Kakitapalli
2025-07-02 16:24   ` Krzysztof Kozlowski
2025-07-02 22:29   ` Dmitry Baryshkov
2025-07-03  7:25     ` Krzysztof Kozlowski [this message]
2025-07-04 11:11       ` Satya Priya Kakitapalli
2025-07-08  6:52         ` Satya Priya Kakitapalli
2025-07-02 15:13 ` [PATCH v3 2/2] arm64: dts: qcom: sc8180x: Add video clock controller node Satya Priya Kakitapalli
2025-07-08 13:35   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250703-robust-analytic-hummingbird-88eb3b@krzk-bin \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_ajipan@quicinc.com \
    --cc=quic_imrashai@quicinc.com \
    --cc=quic_jkona@quicinc.com \
    --cc=quic_skakitap@quicinc.com \
    --cc=quic_tdas@quicinc.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox