Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
Cc: lee@kernel.org, pavel@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org,  conor+dt@kernel.org,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	bsp-development.geo@leica-geosystems.com
Subject: Re: [PATCH V6 0/2] leds: pwm: Add optional GPIO enable pin support
Date: Mon, 7 Jul 2025 08:18:00 +0200	[thread overview]
Message-ID: <20250707-lovely-practical-chinchilla-fe2d0e@krzk-bin> (raw)
In-Reply-To: <20250707020752.713372-1-Qing-wu.Li@leica-geosystems.com.cn>

On Mon, Jul 07, 2025 at 10:07:50AM +0800, LI Qingwu wrote:
> Add support for an optional GPIO enable pin to the PWM LED driver.
> Some LED controllers require an additional enable GPIO to be enabled
> on the device before PWM control can take effect.
> 
> Testing:
> - Tested on i.MX8MP EVK board with TPS92380 LED backlight driver
> - Verified GPIO enable/disable functionality works correctly
> - Confirmed both GPIO_ACTIVE_HIGH and GPIO_ACTIVE_LOW polarities
>   work properly
> 
> 
> Device tree configuration used for testing:
> 
> 	backlight_keypad: backlight-keypad {
> 		compatible = "pwm-leds";
> 
> 		led {
> 			color = <LED_COLOR_ID_WHITE>;
> 			enable-gpios = <&pca6416 11 GPIO_ACTIVE_HIGH>;
> 			function = LED_FUNCTION_KBD_BACKLIGHT;
> 			max-brightness = <100>;
> 			pwms = <&pwm3 0 2500 0>;
> 		};
> 	};
> 
> Changes in V6:
> - Collected Reviewed-by from Krzysztof Kozlowski on 1/2 patch. (Thanks!)

Don't send new versions for that. It's just unnecessary traffic and
effort for us to sort out such emails.

Read submitting patches in this regard.

Best regards,
Krzysztof


      parent reply	other threads:[~2025-07-07  6:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07  2:07 [PATCH V6 0/2] leds: pwm: Add optional GPIO enable pin support LI Qingwu
2025-07-07  2:07 ` [PATCH V6 1/2] dt-bindings: leds: pwm: add enable-gpios property LI Qingwu
2025-07-07  2:07 ` [PATCH V6 2/2] leds: pwm: Add optional GPIO enable pin support LI Qingwu
2025-07-07  6:18 ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250707-lovely-practical-chinchilla-fe2d0e@krzk-bin \
    --to=krzk@kernel.org \
    --cc=Qing-wu.Li@leica-geosystems.com.cn \
    --cc=bsp-development.geo@leica-geosystems.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox