Re: [PATCH 4/4] arm64: dts: allwinner: a523: Add power controller device nodes

[Andre Przywara <andre.przywara@arm.com>]

On Fri, 27 Jun 2025 23:29:18 +0800
Chen-Yu Tsai <wens@kernel.org> wrote:

> From: Chen-Yu Tsai <wens@csie.org>
> 
> The A523 SoC family has two power controllers, one based on the existing
> PPU, and one newer one based on ARM's PCK-600.
> 
> Add device nodes for both of them.

Compared against the manual, that matches up. Might be worth to mention
the reliance on your RST_BUS_R_PPU0 patch, otherwise some bots might
scream.

> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>  arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> index 6f62201fd739..255e0ef98219 100644
> --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi
> @@ -7,6 +7,8 @@
>  #include <dt-bindings/clock/sun55i-a523-r-ccu.h>
>  #include <dt-bindings/reset/sun55i-a523-ccu.h>
>  #include <dt-bindings/reset/sun55i-a523-r-ccu.h>
> +#include <dt-bindings/power/allwinner,sun55i-a523-ppu.h>
> +#include <dt-bindings/power/allwinner,sun55i-a523-pck600.h>
>  
>  / {
>  	interrupt-parent = <&gic>;
> @@ -576,6 +578,14 @@ mdio0: mdio {
>  			};
>  		};
>  
> +		ppu: power-controller@7001400 {
> +			compatible = "allwinner,sun55i-a523-ppu";
> +			reg = <0x07001400 0x400>;
> +			clocks = <&r_ccu CLK_BUS_R_PPU1>;
> +			resets = <&r_ccu RST_BUS_R_PPU1>;
> +			#power-domain-cells = <1>;
> +		};
> +
>  		r_ccu: clock-controller@7010000 {
>  			compatible = "allwinner,sun55i-a523-r-ccu";
>  			reg = <0x7010000 0x250>;
> @@ -622,6 +632,14 @@ r_i2c_pins: r-i2c-pins {
>  			};
>  		};
>  
> +		pck600: power-controller@7060000 {
> +			compatible = "allwinner,sun55i-a523-pck-600";
> +			reg = <0x07060000 0x8000>;
> +			clocks = <&r_ccu CLK_BUS_R_PPU0>;
> +			resets = <&r_ccu RST_BUS_R_PPU0>;
> +			#power-domain-cells = <1>;
> +		};
> +
>  		r_i2c0: i2c@7081400 {
>  			compatible = "allwinner,sun55i-a523-i2c",
>  				     "allwinner,sun8i-v536-i2c",