From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 90842155C88; Sun, 6 Jul 2025 23:38:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751845133; cv=none; b=H4gyqO6EkfPrrnJASHzcNF8eQa6yTnTi/X12aRU+qrrjs7JvCKjdA5w4rcMA58bX403UGthtlSTudH1lhSnPKm9I1xTfxo7utd6tQ9aVuO8sqUukLcqhmWRZoJAbuKiOHEZTZG1XihLhPOwkQ35dfsSlQhO5DPm7P3rmrwXqdrg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751845133; c=relaxed/simple; bh=T5BRD9FAcEcLMux46w89iS9a0vl+S93dslNk6xYMWU0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=AaNxm0Y1FqGKcflyf21hg6YVB861MkYexdoXPBez1kXG/ee14z4MsL515TztLzNA1+bNa0K6UO+VGQjFS2oWwb2w9W2+Sh09WyPYY+QKvSBdhjzkjLIEAiIoDrLv9E4LcYGOGq5LFDhn/C356sorG+xxC3zoS7Pf7kwyCYEB988= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 687E71E8D; Sun, 6 Jul 2025 16:38:38 -0700 (PDT) Received: from minigeek.lan (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 84A623F694; Sun, 6 Jul 2025 16:38:49 -0700 (PDT) Date: Mon, 7 Jul 2025 00:37:10 +0100 From: Andre Przywara To: Chen-Yu Tsai Cc: Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 4/4] arm64: dts: allwinner: a523: Add power controller device nodes Message-ID: <20250707003710.1d4a3ed0@minigeek.lan> In-Reply-To: <20250627152918.2606728-5-wens@kernel.org> References: <20250627152918.2606728-1-wens@kernel.org> <20250627152918.2606728-5-wens@kernel.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 27 Jun 2025 23:29:18 +0800 Chen-Yu Tsai wrote: > From: Chen-Yu Tsai > > The A523 SoC family has two power controllers, one based on the existing > PPU, and one newer one based on ARM's PCK-600. > > Add device nodes for both of them. Compared against the manual, that matches up. Might be worth to mention the reliance on your RST_BUS_R_PPU0 patch, otherwise some bots might scream. > Signed-off-by: Chen-Yu Tsai Reviewed-by: Andre Przywara Cheers, Andre > --- > arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi > index 6f62201fd739..255e0ef98219 100644 > --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi > @@ -7,6 +7,8 @@ > #include > #include > #include > +#include > +#include > > / { > interrupt-parent = <&gic>; > @@ -576,6 +578,14 @@ mdio0: mdio { > }; > }; > > + ppu: power-controller@7001400 { > + compatible = "allwinner,sun55i-a523-ppu"; > + reg = <0x07001400 0x400>; > + clocks = <&r_ccu CLK_BUS_R_PPU1>; > + resets = <&r_ccu RST_BUS_R_PPU1>; > + #power-domain-cells = <1>; > + }; > + > r_ccu: clock-controller@7010000 { > compatible = "allwinner,sun55i-a523-r-ccu"; > reg = <0x7010000 0x250>; > @@ -622,6 +632,14 @@ r_i2c_pins: r-i2c-pins { > }; > }; > > + pck600: power-controller@7060000 { > + compatible = "allwinner,sun55i-a523-pck-600"; > + reg = <0x07060000 0x8000>; > + clocks = <&r_ccu CLK_BUS_R_PPU0>; > + resets = <&r_ccu RST_BUS_R_PPU0>; > + #power-domain-cells = <1>; > + }; > + > r_i2c0: i2c@7081400 { > compatible = "allwinner,sun55i-a523-i2c", > "allwinner,sun8i-v536-i2c",