From: Heiko Stuebner <heiko@sntech.de>
To: heiko@sntech.de
Cc: neil.armstrong@linaro.org, quic_jesszhan@quicinc.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, hjc@rock-chips.com, andy.yan@rock-chips.com,
andyshrk@163.com, nicolas.frattaroli@collabora.com,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: [PATCH 01/13] drm/panel: ilitek-ili9881c: turn off power-supply when init fails
Date: Mon, 7 Jul 2025 18:48:54 +0200 [thread overview]
Message-ID: <20250707164906.1445288-2-heiko@sntech.de> (raw)
In-Reply-To: <20250707164906.1445288-1-heiko@sntech.de>
The prepare function turns on the power-supply regulator first, when
preparing the display. But in an error case, just returns the error
code, but does not power off the regulator again, fix that.
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
index 28cd7560e5db..d7a17dca2a9c 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9881c.c
@@ -1292,7 +1292,7 @@ static int ili9881c_prepare(struct drm_panel *panel)
instr->arg.cmd.data);
if (ret)
- return ret;
+ goto disable_power;
}
ret = ili9881c_switch_page(ctx, 0);
@@ -1304,18 +1304,22 @@ static int ili9881c_prepare(struct drm_panel *panel)
&ctx->address_mode,
sizeof(ctx->address_mode));
if (ret < 0)
- return ret;
+ goto disable_power;
}
ret = mipi_dsi_dcs_set_tear_on(ctx->dsi, MIPI_DSI_DCS_TEAR_MODE_VBLANK);
if (ret)
- return ret;
+ goto disable_power;
ret = mipi_dsi_dcs_exit_sleep_mode(ctx->dsi);
if (ret)
- return ret;
+ goto disable_power;
return 0;
+
+disable_power:
+ regulator_disable(ctx->power);
+ return ret;
}
static int ili9881c_enable(struct drm_panel *panel)
--
2.47.2
next prev parent reply other threads:[~2025-07-07 16:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 16:48 [PATCH 00/13] Support DSI output on rk3576 and roc-rk3576-pc board Heiko Stuebner
2025-07-07 16:48 ` Heiko Stuebner [this message]
2025-08-04 15:15 ` [PATCH 01/13] drm/panel: ilitek-ili9881c: turn off power-supply when init fails neil.armstrong
2025-07-07 16:48 ` [PATCH 02/13] drm/panel: ilitek-ili9881c: move display_on/_off dcs calls to (un-)prepare Heiko Stuebner
2025-08-04 15:15 ` neil.armstrong
2025-07-07 16:48 ` [PATCH 03/13] drm/panel: ilitek-ili9881c: convert (un-)prepare to mipi_dsi_multi_context Heiko Stuebner
2025-08-04 15:16 ` neil.armstrong
2025-07-07 16:48 ` [PATCH 04/13] dt-bindings: vendor-prefixes: Add prefix for Shenzhen Bestar Electronic Heiko Stuebner
2025-07-08 20:04 ` Rob Herring (Arm)
2025-07-07 16:48 ` [PATCH 05/13] dt-bindings: display: ili9881c: Add Bestar BSD1218-A101KL68 LCD panel Heiko Stuebner
2025-07-08 20:04 ` Rob Herring (Arm)
2025-07-07 16:48 ` [PATCH 06/13] drm/panel: ilitek-ili9881c: Add Bestar BSD1218-A101KL68 support Heiko Stuebner
2025-08-04 15:16 ` neil.armstrong
2025-07-07 16:49 ` [PATCH 07/13] dt-bindings: soc: rockchip: add rk3576 mipi dcphy syscon Heiko Stuebner
2025-07-08 20:06 ` Rob Herring (Arm)
2025-07-07 16:49 ` [PATCH 08/13] dt-bindings: display: rockchip: Add rk3576 to RK3588 DW DSI2 controller schema Heiko Stuebner
2025-07-08 20:10 ` Rob Herring (Arm)
2025-07-07 16:49 ` [PATCH 09/13] drm/rockchip: dsi2: add support rk3576 Heiko Stuebner
2025-08-13 7:56 ` Andy Yan
2025-07-07 16:49 ` [PATCH 10/13] arm64: dts: rockchip: add mipi-dcphy to rk3576 Heiko Stuebner
2025-07-07 16:49 ` [PATCH 11/13] arm64: dts: rockchip: add the dsi controller " Heiko Stuebner
2025-07-07 16:49 ` [PATCH 12/13] arm64: dts: rockchip: add vcc3v3-lcd-s0 regulator to roc-rk3576-pc Heiko Stuebner
2025-07-07 16:49 ` [PATCH 13/13] arm64: dts: rockchip: add dm-m10r800-v3s overlay for roc-rk3576-pc Heiko Stuebner
2025-07-08 13:23 ` [PATCH 00/13] Support DSI output on rk3576 and roc-rk3576-pc board Rob Herring (Arm)
2025-07-08 13:25 ` Heiko Stübner
2025-08-22 21:08 ` (subset) " Heiko Stuebner
2025-08-22 21:15 ` Heiko Stuebner
2025-08-22 21:22 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250707164906.1445288-2-heiko@sntech.de \
--to=heiko@sntech.de \
--cc=andy.yan@rock-chips.com \
--cc=andyshrk@163.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.frattaroli@collabora.com \
--cc=quic_jesszhan@quicinc.com \
--cc=robh@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).