* [PATCH 1/4] dt-bindings: mfd: qcom,spmi-pmic: Document PMIV0104
2025-06-25 9:18 [PATCH 0/4] Add support for PMIV0104 PMIC Luca Weiss
@ 2025-06-25 9:18 ` Luca Weiss
2025-07-08 8:22 ` Krzysztof Kozlowski
2025-06-25 9:18 ` [PATCH 2/4] dt-bindings: pinctrl: qcom,pmic-gpio: Add PMIV0104 support Luca Weiss
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Luca Weiss @ 2025-06-25 9:18 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Stephen Boyd, Bjorn Andersson, Linus Walleij, Konrad Dybcio
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, linux-gpio, Luca Weiss
Add the PMIV0104 PMIC which is found on e.g. boards with SM7635 SoCs.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
index 078a6886f8b1e9ceb2187e988ce7c9514ff6dc2c..c416f25c90d6d9f8404947d1fadef91cf664e666 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
@@ -84,6 +84,7 @@ properties:
- qcom,pmi8994
- qcom,pmi8998
- qcom,pmih0108
+ - qcom,pmiv0104
- qcom,pmk8002
- qcom,pmk8350
- qcom,pmk8550
--
2.50.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/4] dt-bindings: mfd: qcom,spmi-pmic: Document PMIV0104
2025-06-25 9:18 ` [PATCH 1/4] dt-bindings: mfd: qcom,spmi-pmic: Document PMIV0104 Luca Weiss
@ 2025-07-08 8:22 ` Krzysztof Kozlowski
0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-08 8:22 UTC (permalink / raw)
To: Luca Weiss
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Stephen Boyd, Bjorn Andersson, Linus Walleij, Konrad Dybcio,
~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, linux-gpio
On Wed, Jun 25, 2025 at 11:18:02AM +0200, Luca Weiss wrote:
> Add the PMIV0104 PMIC which is found on e.g. boards with SM7635 SoCs.
s/SM7635/Milos/ SoCs.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/4] dt-bindings: pinctrl: qcom,pmic-gpio: Add PMIV0104 support
2025-06-25 9:18 [PATCH 0/4] Add support for PMIV0104 PMIC Luca Weiss
2025-06-25 9:18 ` [PATCH 1/4] dt-bindings: mfd: qcom,spmi-pmic: Document PMIV0104 Luca Weiss
@ 2025-06-25 9:18 ` Luca Weiss
2025-07-08 8:23 ` Krzysztof Kozlowski
2025-06-25 9:18 ` [PATCH 3/4] pinctrl: qcom: spmi: Add PMIV0104 Luca Weiss
2025-06-25 9:18 ` [PATCH 4/4] arm64: dts: qcom: Add PMIV0104 PMIC Luca Weiss
3 siblings, 1 reply; 9+ messages in thread
From: Luca Weiss @ 2025-06-25 9:18 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Stephen Boyd, Bjorn Andersson, Linus Walleij, Konrad Dybcio
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, linux-gpio, Luca Weiss
Update the Qualcomm Technologies, Inc. PMIC GPIO binding documentation
to include the compatible string for the PMIV0104 PMICs.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
index 055cea5452eb62ab6e251a3a9193d1e5da293ccb..e8a1f524929a710a6a65ba3e716c697f24524496 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
@@ -64,6 +64,7 @@ properties:
- qcom,pmi8994-gpio
- qcom,pmi8998-gpio
- qcom,pmih0108-gpio
+ - qcom,pmiv0104-gpio
- qcom,pmk8350-gpio
- qcom,pmk8550-gpio
- qcom,pmm8155au-gpio
@@ -228,6 +229,7 @@ allOf:
- qcom,pmc8180-gpio
- qcom,pmc8380-gpio
- qcom,pmi8994-gpio
+ - qcom,pmiv0104-gpio
- qcom,pmm8155au-gpio
then:
properties:
--
2.50.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/4] dt-bindings: pinctrl: qcom,pmic-gpio: Add PMIV0104 support
2025-06-25 9:18 ` [PATCH 2/4] dt-bindings: pinctrl: qcom,pmic-gpio: Add PMIV0104 support Luca Weiss
@ 2025-07-08 8:23 ` Krzysztof Kozlowski
0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-08 8:23 UTC (permalink / raw)
To: Luca Weiss
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Stephen Boyd, Bjorn Andersson, Linus Walleij, Konrad Dybcio,
~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, linux-gpio
On Wed, Jun 25, 2025 at 11:18:03AM +0200, Luca Weiss wrote:
> Update the Qualcomm Technologies, Inc. PMIC GPIO binding documentation
> to include the compatible string for the PMIV0104 PMICs.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 2 ++
> 1 file changed, 2 insertions(+)
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/4] pinctrl: qcom: spmi: Add PMIV0104
2025-06-25 9:18 [PATCH 0/4] Add support for PMIV0104 PMIC Luca Weiss
2025-06-25 9:18 ` [PATCH 1/4] dt-bindings: mfd: qcom,spmi-pmic: Document PMIV0104 Luca Weiss
2025-06-25 9:18 ` [PATCH 2/4] dt-bindings: pinctrl: qcom,pmic-gpio: Add PMIV0104 support Luca Weiss
@ 2025-06-25 9:18 ` Luca Weiss
2025-06-28 15:30 ` Dmitry Baryshkov
2025-06-25 9:18 ` [PATCH 4/4] arm64: dts: qcom: Add PMIV0104 PMIC Luca Weiss
3 siblings, 1 reply; 9+ messages in thread
From: Luca Weiss @ 2025-06-25 9:18 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Stephen Boyd, Bjorn Andersson, Linus Walleij, Konrad Dybcio
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, linux-gpio, Luca Weiss
PMIV0104 is a PMIC, featuring 10 GPIOs. Describe it.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
index bc082bfb52ef480941e1804f1142496e1db6413a..40de5554c771d0c034a458fb4d5e8876473b391c 100644
--- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
+++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
@@ -1244,6 +1244,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
{ .compatible = "qcom,pmi8994-gpio", .data = (void *) 10 },
{ .compatible = "qcom,pmi8998-gpio", .data = (void *) 14 },
{ .compatible = "qcom,pmih0108-gpio", .data = (void *) 18 },
+ { .compatible = "qcom,pmiv0104-gpio", .data = (void *) 10 },
{ .compatible = "qcom,pmk8350-gpio", .data = (void *) 4 },
{ .compatible = "qcom,pmk8550-gpio", .data = (void *) 6 },
{ .compatible = "qcom,pmm8155au-gpio", .data = (void *) 10 },
--
2.50.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 3/4] pinctrl: qcom: spmi: Add PMIV0104
2025-06-25 9:18 ` [PATCH 3/4] pinctrl: qcom: spmi: Add PMIV0104 Luca Weiss
@ 2025-06-28 15:30 ` Dmitry Baryshkov
0 siblings, 0 replies; 9+ messages in thread
From: Dmitry Baryshkov @ 2025-06-28 15:30 UTC (permalink / raw)
To: Luca Weiss
Cc: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Stephen Boyd, Bjorn Andersson, Linus Walleij, Konrad Dybcio,
~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, linux-gpio
On Wed, Jun 25, 2025 at 11:18:04AM +0200, Luca Weiss wrote:
> PMIV0104 is a PMIC, featuring 10 GPIOs. Describe it.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 4/4] arm64: dts: qcom: Add PMIV0104 PMIC
2025-06-25 9:18 [PATCH 0/4] Add support for PMIV0104 PMIC Luca Weiss
` (2 preceding siblings ...)
2025-06-25 9:18 ` [PATCH 3/4] pinctrl: qcom: spmi: Add PMIV0104 Luca Weiss
@ 2025-06-25 9:18 ` Luca Weiss
2025-06-25 13:19 ` Konrad Dybcio
3 siblings, 1 reply; 9+ messages in thread
From: Luca Weiss @ 2025-06-25 9:18 UTC (permalink / raw)
To: Lee Jones, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Stephen Boyd, Bjorn Andersson, Linus Walleij, Konrad Dybcio
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, linux-gpio, Luca Weiss
Add a dts for the PMIC used e.g. with SM7635 devices.
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
---
arch/arm64/boot/dts/qcom/pmiv0104.dtsi | 63 ++++++++++++++++++++++++++++++++++
1 file changed, 63 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/pmiv0104.dtsi b/arch/arm64/boot/dts/qcom/pmiv0104.dtsi
new file mode 100644
index 0000000000000000000000000000000000000000..04d929db76f409c49c47ef0147a3de568006973a
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/pmiv0104.dtsi
@@ -0,0 +1,63 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2025, Luca Weiss <luca.weiss@fairphone.com>
+ */
+
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/spmi/spmi.h>
+
+/ {
+ thermal-zones {
+ pmiv0104-thermal {
+ polling-delay-passive = <100>;
+
+ thermal-sensors = <&pmiv0104_temp_alarm>;
+
+ trips {
+ trip0 {
+ temperature = <95000>;
+ hysteresis = <0>;
+ type = "passive";
+ };
+
+ trip1 {
+ temperature = <115000>;
+ hysteresis = <0>;
+ type = "hot";
+ };
+ };
+ };
+ };
+};
+
+&spmi_bus {
+ pmic@PMIV0104_SID {
+ compatible = "qcom,pmiv0104", "qcom,spmi-pmic";
+ reg = <PMIV0104_SID SPMI_USID>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmiv0104_temp_alarm: temp-alarm@a00 {
+ compatible = "qcom,spmi-temp-alarm";
+ reg = <0xa00>;
+ interrupts = <PMIV0104_SID 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
+ #thermal-sensor-cells = <0>;
+ };
+
+ pmiv0104_gpios: gpio@8800 {
+ compatible = "qcom,pmiv0104-gpio", "qcom,spmi-gpio";
+ reg = <0x8800>;
+ gpio-controller;
+ gpio-ranges = <&pmiv0104_gpios 0 0 10>;
+ #gpio-cells = <2>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
+
+ pmiv0104_eusb2_repeater: phy@fd00 {
+ compatible = "qcom,pmiv0104-eusb2-repeater";
+ reg = <0xfd00>;
+ #phy-cells = <0>;
+ };
+ };
+};
--
2.50.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 4/4] arm64: dts: qcom: Add PMIV0104 PMIC
2025-06-25 9:18 ` [PATCH 4/4] arm64: dts: qcom: Add PMIV0104 PMIC Luca Weiss
@ 2025-06-25 13:19 ` Konrad Dybcio
0 siblings, 0 replies; 9+ messages in thread
From: Konrad Dybcio @ 2025-06-25 13:19 UTC (permalink / raw)
To: Luca Weiss, Lee Jones, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Stephen Boyd, Bjorn Andersson, Linus Walleij,
Konrad Dybcio
Cc: ~postmarketos/upstreaming, phone-devel, linux-arm-msm, devicetree,
linux-kernel, linux-gpio
On 6/25/25 11:18 AM, Luca Weiss wrote:
> Add a dts for the PMIC used e.g. with SM7635 devices.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> arch/arm64/boot/dts/qcom/pmiv0104.dtsi | 63 ++++++++++++++++++++++++++++++++++
> 1 file changed, 63 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmiv0104.dtsi b/arch/arm64/boot/dts/qcom/pmiv0104.dtsi
> new file mode 100644
> index 0000000000000000000000000000000000000000..04d929db76f409c49c47ef0147a3de568006973a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/pmiv0104.dtsi
> @@ -0,0 +1,63 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2025, Luca Weiss <luca.weiss@fairphone.com>
> + */
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/spmi/spmi.h>
> +
> +/ {
> + thermal-zones {
> + pmiv0104-thermal {
> + polling-delay-passive = <100>;
> +
> + thermal-sensors = <&pmiv0104_temp_alarm>;
> +
> + trips {
> + trip0 {
> + temperature = <95000>;
> + hysteresis = <0>;
> + type = "passive";
> + };
> +
> + trip1 {
> + temperature = <115000>;
> + hysteresis = <0>;
> + type = "hot";
> + };
Please also include a 145C critical trip, which is probably the
most important one
otherwise:
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 9+ messages in thread