[PATCH 0/8] Reference the common qcom,gcc.yaml schema

[PATCH 0/8] Reference the common qcom,gcc.yaml schema

[Satya Priya Kakitapalli]

For all the possible Qualcomm clock controller bindings
add qcom,gcc.yaml reference to unify the common
parts of the binding.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
Satya Priya Kakitapalli (8):
      dt-bindings: clock: qcom,sm8150-camcc: Reference qcom,gcc.yaml
      dt-bindings: clock: qcom,lcc: Reference qcom,gcc.yaml
      dt-bindings: clock: qcom,mmcc: Reference qcom,gcc.yaml
      dt-bindings: clock: qcom,qcs404-turingcc: Reference qcom,gcc.yaml
      dt-bindings: clock: qcom,qdu1000-ecpricc: Reference qcom,gcc.yaml
      dt-bindings: clock: qcom,sc8280xp-lpasscc: Reference qcom,gcc.yaml
      dt-bindings: clock: qcom,sm4450-camcc: Reference qcom,gcc.yaml
      dt-bindings: clock: qcom,sm4450-dispcc: Reference qcom,gcc.yaml

 .../devicetree/bindings/clock/qcom,lcc.yaml        | 17 +++------------
 .../devicetree/bindings/clock/qcom,mmcc.yaml       | 24 +++-------------------
 .../bindings/clock/qcom,qcs404-turingcc.yaml       | 17 ++++-----------
 .../bindings/clock/qcom,qdu1000-ecpricc.yaml       | 17 ++++-----------
 .../bindings/clock/qcom,sc8280xp-lpasscc.yaml      | 17 ++++-----------
 .../bindings/clock/qcom,sm4450-camcc.yaml          | 20 ++++--------------
 .../bindings/clock/qcom,sm4450-dispcc.yaml         | 20 ++++--------------
 .../bindings/clock/qcom,sm8150-camcc.yaml          | 20 ++++--------------
 8 files changed, 30 insertions(+), 122 deletions(-)
---
base-commit: 26ffb3d6f02cd0935fb9fa3db897767beee1cb2a
change-id: 20250708-gcc-ref-fixes-3f05521a10b1

Best regards,
-- 
Satya Priya Kakitapalli <quic_skakitap@quicinc.com>

[PATCH 1/8] dt-bindings: clock: qcom,sm8150-camcc: Reference qcom,gcc.yaml

[Satya Priya Kakitapalli]

Reference the common qcom,gcc.yaml schema to unify the common
parts of the binding.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
 .../devicetree/bindings/clock/qcom,sm8150-camcc.yaml | 20 ++++----------------
 1 file changed, 4 insertions(+), 16 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8150-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8150-camcc.yaml
index 5e9f62d7866cfc816845e5cd3fc132894bffe5fd..1b505f473e293af77d5158e8e65dac12244133f4 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm8150-camcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm8150-camcc.yaml
@@ -19,9 +19,6 @@ properties:
   compatible:
     const: qcom,sm8150-camcc
 
-  reg:
-    maxItems: 1
-
   clocks:
     items:
       - description: Board XO source
@@ -37,26 +34,17 @@ properties:
     description:
       A phandle to an OPP node describing required MMCX performance point.
 
-  '#clock-cells':
-    const: 1
-
-  '#reset-cells':
-    const: 1
-
-  '#power-domain-cells':
-    const: 1
-
 required:
   - compatible
-  - reg
   - clocks
   - power-domains
   - required-opps
-  - '#clock-cells'
-  - '#reset-cells'
   - '#power-domain-cells'
 
-additionalProperties: false
+allOf:
+  - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
 
 examples:
   - |

-- 
2.25.1

Re: [PATCH 1/8] dt-bindings: clock: qcom,sm8150-camcc: Reference qcom,gcc.yaml

[Krzysztof Kozlowski]

On 09/07/2025 11:37, Satya Priya Kakitapalli wrote:
> Reference the common qcom,gcc.yaml schema to unify the common
> parts of the binding.
> 
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
> ---

If you copy subject and almost entire commit msg from existing commit,
without writing anything different (!), you could also give
Suggested-by... Saves me time to double check what happened with my
prior patches doing that.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 2/8] dt-bindings: clock: qcom,lcc: Reference qcom,gcc.yaml

[Satya Priya Kakitapalli]

Reference the common qcom,gcc.yaml schema to unify the common
parts of the binding.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
 Documentation/devicetree/bindings/clock/qcom,lcc.yaml | 17 +++--------------
 1 file changed, 3 insertions(+), 14 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,lcc.yaml b/Documentation/devicetree/bindings/clock/qcom,lcc.yaml
index 55985e562a34f8b1f5d8cff88fd733cdbae7d37c..b4b500dea527269a9a282b3f99714d5703dd9215 100644
--- a/Documentation/devicetree/bindings/clock/qcom,lcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,lcc.yaml
@@ -23,24 +23,11 @@ properties:
   clock-names:
     maxItems: 8
 
-  '#clock-cells':
-    const: 1
-
-  '#reset-cells':
-    const: 1
-
-  reg:
-    maxItems: 1
-
 required:
   - compatible
-  - reg
-  - '#clock-cells'
-  - '#reset-cells'
-
-additionalProperties: false
 
 allOf:
+  - $ref: qcom,gcc.yaml#
   - if:
       properties:
         compatible:
@@ -110,6 +97,8 @@ allOf:
         - clocks
         - clock-names
 
+unevaluatedProperties: false
+
 examples:
   - |
     clock-controller@28000000 {

-- 
2.25.1

Re: [PATCH 2/8] dt-bindings: clock: qcom,lcc: Reference qcom,gcc.yaml

[Krzysztof Kozlowski]

On 09/07/2025 11:37, Satya Priya Kakitapalli wrote:
> Reference the common qcom,gcc.yaml schema to unify the common
> parts of the binding.
> 
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
> ---
>  Documentation/devicetree/bindings/clock/qcom,lcc.yaml | 17 +++--------------
>  1 file changed, 3 insertions(+), 14 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,lcc.yaml b/Documentation/devicetree/bindings/clock/qcom,lcc.yaml
> index 55985e562a34f8b1f5d8cff88fd733cdbae7d37c..b4b500dea527269a9a282b3f99714d5703dd9215 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,lcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,lcc.yaml
> @@ -23,24 +23,11 @@ properties:
>    clock-names:
>      maxItems: 8
>  
> -  '#clock-cells':
> -    const: 1
> -
For the same reasons as further patch, no. You do not understand what is
happening here (and commit msg must explain such things)...

Best regards,
Krzysztof

[PATCH 3/8] dt-bindings: clock: qcom,mmcc: Reference qcom,gcc.yaml

[Satya Priya Kakitapalli]

Reference the common qcom,gcc.yaml schema to unify the common
parts of the binding.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
 .../devicetree/bindings/clock/qcom,mmcc.yaml       | 24 +++-------------------
 1 file changed, 3 insertions(+), 21 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
index 59ac288ca5f12de4f14fac3ce0d783d1ee1ebb4f..53ceec9673a810c2230548a47e045959e8159806 100644
--- a/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.yaml
@@ -38,36 +38,16 @@ properties:
     minItems: 7
     maxItems: 13
 
-  '#clock-cells':
-    const: 1
-
-  '#reset-cells':
-    const: 1
-
-  '#power-domain-cells':
-    const: 1
-
-  reg:
-    maxItems: 1
-
-  protected-clocks:
-    description:
-      Protected clock specifier list as per common clock binding
-
   vdd-gfx-supply:
     description:
       Regulator supply for the GPU_GX GDSC
 
 required:
   - compatible
-  - reg
-  - '#clock-cells'
-  - '#reset-cells'
   - '#power-domain-cells'
 
-additionalProperties: false
-
 allOf:
+  - $ref: qcom,gcc.yaml#
   - if:
       properties:
         compatible:
@@ -351,6 +331,8 @@ allOf:
             - const: dp_link_2x_clk_divsel_five
             - const: dp_vco_divided_clk_src_mux
 
+unevaluatedProperties: false
+
 examples:
   # Example for MMCC for MSM8960:
   - |

-- 
2.25.1

[PATCH 4/8] dt-bindings: clock: qcom,qcs404-turingcc: Reference qcom,gcc.yaml

[Satya Priya Kakitapalli]

Reference the common qcom,gcc.yaml schema to unify the common
parts of the binding.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
 .../devicetree/bindings/clock/qcom,qcs404-turingcc.yaml | 17 ++++-------------
 1 file changed, 4 insertions(+), 13 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml b/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml
index 033e010754a26bd03e02a364b0a6f36d87a3af62..794984f563fe3eb253aaf7524205097cf0c62711 100644
--- a/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml
@@ -13,26 +13,17 @@ properties:
   compatible:
     const: qcom,qcs404-turingcc
 
-  reg:
-    maxItems: 1
-
   clocks:
     maxItems: 1
 
-  '#clock-cells':
-    const: 1
-
-  '#reset-cells':
-    const: 1
-
 required:
   - compatible
-  - reg
   - clocks
-  - '#clock-cells'
-  - '#reset-cells'
 
-additionalProperties: false
+allOf:
+  - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
 
 examples:
   - |

-- 
2.25.1

Re: [PATCH 4/8] dt-bindings: clock: qcom,qcs404-turingcc: Reference qcom,gcc.yaml

[Krzysztof Kozlowski]

On 09/07/2025 11:37, Satya Priya Kakitapalli wrote:
> Reference the common qcom,gcc.yaml schema to unify the common
> parts of the binding.
> 
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
> ---
>  .../devicetree/bindings/clock/qcom,qcs404-turingcc.yaml | 17 ++++-------------
>  1 file changed, 4 insertions(+), 13 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml b/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml
> index 033e010754a26bd03e02a364b0a6f36d87a3af62..794984f563fe3eb253aaf7524205097cf0c62711 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml
> @@ -13,26 +13,17 @@ properties:
>    compatible:
>      const: qcom,qcs404-turingcc
>  
> -  reg:
> -    maxItems: 1
> -
>    clocks:
>      maxItems: 1
>  
> -  '#clock-cells':
> -    const: 1
> -
> -  '#reset-cells':
> -    const: 1
> -
>  required:
>    - compatible
> -  - reg
>    - clocks
> -  - '#clock-cells'
> -  - '#reset-cells'
No, this becomes now power domain provider without explanation.

Don't just blindly copy other people's commits without understanding them.

Best regards,
Krzysztof

Re: [PATCH 4/8] dt-bindings: clock: qcom,qcs404-turingcc: Reference qcom,gcc.yaml

[Satya Priya Kakitapalli]

On 7/9/2025 3:37 PM, Krzysztof Kozlowski wrote:
> On 09/07/2025 11:37, Satya Priya Kakitapalli wrote:
>> Reference the common qcom,gcc.yaml schema to unify the common
>> parts of the binding.
>>
>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>> ---
>>   .../devicetree/bindings/clock/qcom,qcs404-turingcc.yaml | 17 ++++-------------
>>   1 file changed, 4 insertions(+), 13 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml b/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml
>> index 033e010754a26bd03e02a364b0a6f36d87a3af62..794984f563fe3eb253aaf7524205097cf0c62711 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml
>> +++ b/Documentation/devicetree/bindings/clock/qcom,qcs404-turingcc.yaml
>> @@ -13,26 +13,17 @@ properties:
>>     compatible:
>>       const: qcom,qcs404-turingcc
>>   
>> -  reg:
>> -    maxItems: 1
>> -
>>     clocks:
>>       maxItems: 1
>>   
>> -  '#clock-cells':
>> -    const: 1
>> -
>> -  '#reset-cells':
>> -    const: 1
>> -
>>   required:
>>     - compatible
>> -  - reg
>>     - clocks
>> -  - '#clock-cells'
>> -  - '#reset-cells'
> No, this becomes now power domain provider without explanation.


My bad, I will drop the files which do not have the power domain cells 
in my next post.


> Don't just blindly copy other people's commits without understanding them.
>
> Best regards,
> Krzysztof

[PATCH 5/8] dt-bindings: clock: qcom,qdu1000-ecpricc: Reference qcom,gcc.yaml

[Satya Priya Kakitapalli]

Reference the common qcom,gcc.yaml schema to unify the common
parts of the binding.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
 .../devicetree/bindings/clock/qcom,qdu1000-ecpricc.yaml | 17 ++++-------------
 1 file changed, 4 insertions(+), 13 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,qdu1000-ecpricc.yaml b/Documentation/devicetree/bindings/clock/qcom,qdu1000-ecpricc.yaml
index fd21df0e76976e6fecd32db5ee4a5eeec2757083..f452529437be8149ed83d95655bf89d34466f83e 100644
--- a/Documentation/devicetree/bindings/clock/qcom,qdu1000-ecpricc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,qdu1000-ecpricc.yaml
@@ -21,9 +21,6 @@ properties:
     enum:
       - qcom,qdu1000-ecpricc
 
-  reg:
-    maxItems: 1
-
   clocks:
     items:
       - description: Board XO source
@@ -34,20 +31,14 @@ properties:
       - description: GPLL4 source from GCC
       - description: GPLL5 source from GCC
 
-  '#clock-cells':
-    const: 1
-
-  '#reset-cells':
-    const: 1
-
 required:
   - compatible
-  - reg
   - clocks
-  - '#clock-cells'
-  - '#reset-cells'
 
-additionalProperties: false
+allOf:
+  - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
 
 examples:
   - |

-- 
2.25.1

Re: [PATCH 5/8] dt-bindings: clock: qcom,qdu1000-ecpricc: Reference qcom,gcc.yaml

[Krzysztof Kozlowski]

On 09/07/2025 11:37, Satya Priya Kakitapalli wrote:
> Reference the common qcom,gcc.yaml schema to unify the common
> parts of the binding.
> 
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
> ---
>  .../devicetree/bindings/clock/qcom,qdu1000-ecpricc.yaml | 17 ++++-------------
>  1 file changed, 4 insertions(+), 13 deletions(-)
> 
NAK

Best regards,
Krzysztof

[PATCH 6/8] dt-bindings: clock: qcom,sc8280xp-lpasscc: Reference qcom,gcc.yaml

[Satya Priya Kakitapalli]

Reference the common qcom,gcc.yaml schema to unify the common
parts of the binding.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
 .../bindings/clock/qcom,sc8280xp-lpasscc.yaml           | 17 ++++-------------
 1 file changed, 4 insertions(+), 13 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml b/Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml
index 273d66e245c5fdc3611a8b0254c2c6434e14cd5e..035d716c19cae0c7fd8a49d46092d2248d821a08 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sc8280xp-lpasscc.yaml
@@ -29,22 +29,13 @@ properties:
           - const: qcom,x1e80100-lpasscc
           - const: qcom,sc8280xp-lpasscc
 
-  reg:
-    maxItems: 1
-
-  '#clock-cells':
-    const: 1
-
-  '#reset-cells':
-    const: 1
-
 required:
   - compatible
-  - reg
-  - '#clock-cells'
-  - '#reset-cells'
 
-additionalProperties: false
+allOf:
+  - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
 
 examples:
   - |

-- 
2.25.1

Re: [PATCH 6/8] dt-bindings: clock: qcom,sc8280xp-lpasscc: Reference qcom,gcc.yaml

[Krzysztof Kozlowski]

On 09/07/2025 11:37, Satya Priya Kakitapalli wrote:
> Reference the common qcom,gcc.yaml schema to unify the common
> parts of the binding.
> 
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
> ---
>  .../bindings/clock/qcom,sc8280xp-lpasscc.yaml           | 17 ++++-------------
>  1 file changed, 4 insertions(+), 13 deletions(-)
> 
NAK...

Here and on all other patches.

Best regards,
Krzysztof

[PATCH 7/8] dt-bindings: clock: qcom,sm4450-camcc: Reference qcom,gcc.yaml

[Satya Priya Kakitapalli]

Reference the common qcom,gcc.yaml schema to unify the common
parts of the binding.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
 .../devicetree/bindings/clock/qcom,sm4450-camcc.yaml | 20 ++++----------------
 1 file changed, 4 insertions(+), 16 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,sm4450-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm4450-camcc.yaml
index f54ce865880dedfb4bb7c38cbd39a6f5690cda31..1464f3d1f48552d0056715340eb1905d7b2b3e1c 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm4450-camcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm4450-camcc.yaml
@@ -20,32 +20,20 @@ properties:
   compatible:
     const: qcom,sm4450-camcc
 
-  reg:
-    maxItems: 1
-
   clocks:
     items:
       - description: Board XO source
       - description: Camera AHB clock source from GCC
 
-  '#clock-cells':
-    const: 1
-
-  '#reset-cells':
-    const: 1
-
-  '#power-domain-cells':
-    const: 1
-
 required:
   - compatible
-  - reg
   - clocks
-  - '#clock-cells'
-  - '#reset-cells'
   - '#power-domain-cells'
 
-additionalProperties: false
+allOf:
+  - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
 
 examples:
   - |

-- 
2.25.1

[PATCH 8/8] dt-bindings: clock: qcom,sm4450-dispcc: Reference qcom,gcc.yaml

[Satya Priya Kakitapalli]

Reference the common qcom,gcc.yaml schema to unify the common
parts of the binding.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
 .../bindings/clock/qcom,sm4450-dispcc.yaml           | 20 ++++----------------
 1 file changed, 4 insertions(+), 16 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,sm4450-dispcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm4450-dispcc.yaml
index 2aa05353eff17326b9f4234ac1c99dcd82a6abdb..03208166689a9305142d619509dd8fb73a2f629c 100644
--- a/Documentation/devicetree/bindings/clock/qcom,sm4450-dispcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,sm4450-dispcc.yaml
@@ -20,9 +20,6 @@ properties:
   compatible:
     const: qcom,sm4450-dispcc
 
-  reg:
-    maxItems: 1
-
   clocks:
     items:
       - description: Board XO source
@@ -32,24 +29,15 @@ properties:
       - description: Byte clock from DSI PHY0
       - description: Pixel clock from DSI PHY0
 
-  '#clock-cells':
-    const: 1
-
-  '#reset-cells':
-    const: 1
-
-  '#power-domain-cells':
-    const: 1
-
 required:
   - compatible
-  - reg
   - clocks
-  - '#clock-cells'
-  - '#reset-cells'
   - '#power-domain-cells'
 
-additionalProperties: false
+allOf:
+  - $ref: qcom,gcc.yaml#
+
+unevaluatedProperties: false
 
 examples:
   - |

-- 
2.25.1