From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>
Cc: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] leds/leds-is31fl32xx: add support for is31fl3236a
Date: Wed, 9 Jul 2025 10:12:25 +0200 [thread overview]
Message-ID: <20250709-primitive-offbeat-toad-08930d@krzk-bin> (raw)
In-Reply-To: <20250708-leds-is31fl3236a-v3-1-d68979b042dd@thegoodpenguin.co.uk>
On Tue, Jul 08, 2025 at 03:59:45PM +0100, Pawel Zalewski wrote:
> +
> for_each_available_child_of_node_scoped(dev_of_node(dev), child) {
> struct led_init_data init_data = {};
> struct is31fl32xx_led_data *led_data =
> @@ -405,6 +438,7 @@ static int is31fl32xx_parse_dt(struct device *dev,
>
> static const struct of_device_id of_is31fl32xx_match[] = {
> { .compatible = "issi,is31fl3236", .data = &is31fl3236_cdef, },
> + { .compatible = "issi,is31fl3236a", .data = &is31fl3236a_cdef, },
Bindings go before the users (see submitting patches in DT).
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-09 8:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 14:59 [PATCH v3 0/3] Add support for is31fl3236a LED controller Pawel Zalewski
2025-07-08 14:59 ` [PATCH v3 1/3] leds/leds-is31fl32xx: add support for is31fl3236a Pawel Zalewski
2025-07-09 8:12 ` Krzysztof Kozlowski [this message]
2025-07-14 9:09 ` Pawel Zalewski
2025-07-14 9:35 ` Krzysztof Kozlowski
2025-07-08 14:59 ` [PATCH v3 2/3] dt-bindings: leds: is31fl32xx: convert the binding to yaml Pawel Zalewski
2025-07-09 8:17 ` Krzysztof Kozlowski
2025-07-14 9:16 ` Pawel Zalewski
2025-07-14 9:36 ` Krzysztof Kozlowski
2025-07-09 8:18 ` Krzysztof Kozlowski
2025-07-08 14:59 ` [PATCH v3 3/3] dt-bindings: leds: issi,is31fl3236: add issi,22kHz-pwm property Pawel Zalewski
2025-07-09 8:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250709-primitive-offbeat-toad-08930d@krzk-bin \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=pavel@ucw.cz \
--cc=pzalewski@thegoodpenguin.co.uk \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox