From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B53AB2D5402; Thu, 10 Jul 2025 09:56:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752141415; cv=none; b=CV3SuY3s9eU7WtmBy9z9sFQ2nuzAjZUIpKG0PUbL7uaG8+/USOwPU+hqiVb1KNVPSbjjGyosHmxWUod9UhRZLtn0u0pPlrj0Tznz6KGIe5jgjh8eLnnMBpm9jrF5cgzm7kp6x41gZQ8PpWbcJDbrmf0qxizpEk/qz/esQ1eKywg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752141415; c=relaxed/simple; bh=mUito/jbA4SgjLb2qRX3cKcksXc5sWgtFL2hulDmMws=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YaAJDO7OKnu+iNF5WYcAGvG78Qzf8SnY8Z13MYdZBuD0euAbckLRM04JMEwmb6coayIoodg1arWHENTUE87kH9nyYrAhFeTEPtsQc9SR1LhOhDrz+q5wjTHxhr0aLJTs6VDu09Hcz42beknUw+Fbpa1tpNJi30Mk3qwRVHJmTvM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XV5wYT8O; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XV5wYT8O" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A715FC4CEF1; Thu, 10 Jul 2025 09:56:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752141415; bh=mUito/jbA4SgjLb2qRX3cKcksXc5sWgtFL2hulDmMws=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XV5wYT8O1fidh5Sr+V3202O/eRFgVKLY/sfmxTdPe2Yrp/CcgeGmXOYEufI2YxgyP XXec9GZnA4A0Mx8phUBpWboHXKztgfrV2HutjlBMShV94iZdwUPeMDDS77de8NC+7V 3xqxvM6Ne5orWGdUtH84sZzwQlZ5bq6GJNiOrVMQwpQETkzeD5/AhJO/1GKUHvoNSL aErflbConbqcwRMz/10YcEzC2EmqzJsYggHixMHeskHjn3mN6BYBU9c+ef8evNFYiw qzrxAUkSh0o09EIUOnH4ezlX8efg2g33SuaqPSNdR0q2BFL6Zg5ttMAByxLWICw475 A0t2hA+TVNCVA== Date: Thu, 10 Jul 2025 11:56:52 +0200 From: Krzysztof Kozlowski To: jiebing chen Cc: Jerome Brunet , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Michael Turquette , Stephen Boyd , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, jian.xu@amlogic.com, shuai.li@amlogic.com, zhe.wang@amlogic.com Subject: Re: [PATCH v5 1/6] dt-bindings: clock: meson: Add audio power domain for s4 soc Message-ID: <20250710-polite-cuddly-platypus-5fe9dc@krzk-bin> References: <20250710-audio_drvier-v5-0-d4155f1e7464@amlogic.com> <20250710-audio_drvier-v5-1-d4155f1e7464@amlogic.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250710-audio_drvier-v5-1-d4155f1e7464@amlogic.com> On Thu, Jul 10, 2025 at 11:35:37AM +0800, jiebing chen wrote: > The audio power domain has been detected on S4 device. > It must be enabled prior to audio operations. > > Signed-off-by: jiebing chen > --- > .../bindings/clock/amlogic,axg-audio-clkc.yaml | 55 +++++++++++++++++++++- > 1 file changed, 54 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml > index fd7982dd4ceab82389167079c2258a9acff51a76..c3f0bb9b2ff050394828ba339a7be0c9c48e9a76 100644 > --- a/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml > +++ b/Documentation/devicetree/bindings/clock/amlogic,axg-audio-clkc.yaml > @@ -21,6 +21,8 @@ properties: > - amlogic,axg-audio-clkc > - amlogic,g12a-audio-clkc > - amlogic,sm1-audio-clkc > + - amlogic,s4-audio-clkc > + - amlogic,clock-pads-clkc Keep the list sorted. > > '#clock-cells': > const: 1 > @@ -100,13 +102,15 @@ properties: > resets: > description: internal reset line > > + power-domains: > + maxItems: 1 > + > required: > - compatible > - '#clock-cells' > - reg > - clocks > - clock-names > - - resets > > allOf: > - if: > @@ -116,12 +120,37 @@ allOf: > enum: > - amlogic,g12a-audio-clkc > - amlogic,sm1-audio-clkc > + - amlogic,s4-audio-clkc Keep it sorted. > then: > required: > - '#reset-cells' > else: > properties: > '#reset-cells': false > + - if: > + properties: > + compatible: > + contains: > + enum: > + - amlogic,s4-audio-clkc > + then: > + required: > + - power-domains > + else: > + properties: > + power-domains: false > + - if: > + properties: > + compatible: > + contains: > + enum: > + - amlogic,clock-pads-clkc > + then: > + properties: > + resets: false > + else: > + required: > + - resets > > additionalProperties: false > > @@ -129,6 +158,7 @@ examples: > - | > #include > #include > + #include > apb { > #address-cells = <2>; > #size-cells = <2>; > @@ -198,4 +228,27 @@ examples: > "slv_lrclk9"; > resets = <&reset RESET_AUDIO>; > }; > + clk_pad: clock-controller@330e80 { Inconsistent indentation. Look at the rest here. Best regards, Krzysztof