From: Rob Herring <robh@kernel.org>
To: Kyle Hendry <kylehendrydev@gmail.com>
Cc: "Philipp Zabel" <p.zabel@pengutronix.de>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Fernández Rojas" <noltari@gmail.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] dt-bindings: reset: add BCM63268 ephy reset definitions
Date: Thu, 10 Jul 2025 16:54:54 -0500 [thread overview]
Message-ID: <20250710215454.GA4033782-robh@kernel.org> (raw)
In-Reply-To: <20250709024740.194520-4-kylehendrydev@gmail.com>
On Tue, Jul 08, 2025 at 07:47:27PM -0700, Kyle Hendry wrote:
> Add definitions for resets in the ephy control register.
>
> Signed-off-by: Kyle Hendry <kylehendrydev@gmail.com>
> ---
> include/dt-bindings/reset/bcm63268-reset.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/dt-bindings/reset/bcm63268-reset.h b/include/dt-bindings/reset/bcm63268-reset.h
> index d87a7882782a..676a62c9777b 100644
> --- a/include/dt-bindings/reset/bcm63268-reset.h
> +++ b/include/dt-bindings/reset/bcm63268-reset.h
> @@ -27,4 +27,8 @@
> #define BCM63268_TRST_HW 30
> #define BCM63268_TRST_POR 31
>
> +#define BCM63268_RST_EPHY1 0
> +#define BCM63268_RST_EPHY2 1
> +#define BCM63268_RST_EPHY3 2
These are kind of pointless IMO. The provider is only for the EPHYs and
your number is just index+1.
Rob
next prev parent reply other threads:[~2025-07-10 21:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 2:47 [PATCH 0/6] reset: bcm6345: add support for internal ephy resets on bcm63xx Kyle Hendry
2025-07-09 2:47 ` [PATCH 1/6] reset: bcm6345: add support for bcm63xx ephy control register Kyle Hendry
2025-08-14 11:12 ` Krzysztof Kozlowski
2025-07-09 2:47 ` [PATCH 2/6] dt-bindings: reset: add compatible for bcm63xx ephy control Kyle Hendry
2025-07-10 21:53 ` Rob Herring (Arm)
2025-08-14 11:13 ` Krzysztof Kozlowski
2025-07-09 2:47 ` [PATCH 3/6] dt-bindings: reset: add BCM63268 ephy reset definitions Kyle Hendry
2025-07-10 21:54 ` Rob Herring [this message]
2025-07-09 2:47 ` [PATCH 4/6] dt-bindings: reset: add BCM6318 " Kyle Hendry
2025-07-09 2:47 ` [PATCH 5/6] dt-bindings: reset: add BCM6362 " Kyle Hendry
2025-07-09 2:47 ` [PATCH 6/6] dt-bindings: reset: add BCM6328 " Kyle Hendry
2025-08-14 10:57 ` [PATCH 0/6] reset: bcm6345: add support for internal ephy resets on bcm63xx Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710215454.GA4033782-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kylehendrydev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).