Re: [PATCH v2 4/6] arm64: dts: rockchip: Add ArmSoM Sige1

Chukun Pan
2025-07-12T04:05:37Z

Hi,

> > Should this label be named as led-0/led-1?

> The nodes must include 'led' anywhere in their name according to schema:
>
> """
> patternProperties:
> # The first form is preferred, but fall back to just 'led' anywhere in the
> # node name to at least catch some child nodes.
> "(^led-[0-9a-f]$|led)":
> """
>
> Using the color name similar to the the pin labels in schematics made
> most sense to me.
>
> Do you want me to change these to conform to the more restricted
> ^led-[0-9a-f]$ pattern?

This will be better.

> I only try to enable controllers for devices that are properly described,
> so I ignored the pwm-fan and its required pwm6 controller. Mostly
> because it make more sense to describe the fan once thermal support is
> completed, work [1] currently being blocked by a rk356x otp series [2]
> and that depends on a rk3576 thermal series [3].

Ok, I got it. Is usb2.0 also stuck?

Thanks,
Chukun

--
2.25.1