Re: [PATCH v2 4/6] arm64: dts: rockchip: Add ArmSoM Sige1

Chukun Pan
2025-07-11T08:00:24Z

Hi,

> + leds {
> + compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&g_led>, <&r_led>;
> +
> + led-green {

Should this label be named as led-0/led-1?

> +&sdio0 {
> + bus-width = <4>;
> + cap-sd-highspeed;
> + cap-sdio-irq;
> + disable-wp;
> + keep-power-in-suspend;
> + mmc-pwrseq = <&sdio_pwrseq>;
> + no-mmc;
> + no-sd;
> + non-removable;
> + pinctrl-names = "default";
> + pinctrl-0 = <&sdio0_bus4>, <&sdio0_clk>, <&sdio0_cmd>;

This pinctrl is the same as that of rk3528.dtsi, we can remove it.

BTW there is a fan connector on the board (connected to pwm6m2),
so pwm6 should be enabled.

> +&uart2 {
> + dma-names = "tx", "rx";
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart2m1_xfer>, <&uart2m1_ctsn>, <&uart2m1_rtsn>;
> + uart-has-rtscts;
> + status = "okay";
> +
> + bluetooth {
> + compatible = "brcm,bcm43438-bt";
> + clocks = <&cru CLK_DEEPSLOW>;
> + clock-names = "lpo";
> + device-wakeup-gpios = <&gpio3 RK_PC3 GPIO_ACTIVE_HIGH>;

Is host-wakeup-gpios needed?

Thanks,
Chukun

--
2.25.1