From: Krzysztof Kozlowski <krzk@kernel.org>
To: Richard Acayan <mailingradian@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Robert Mader <robert.mader@collabora.com>
Subject: Re: [PATCH v2 1/4] dt-bindings: media: i2c: Add Sony IMX355
Date: Tue, 15 Jul 2025 10:27:54 +0200 [thread overview]
Message-ID: <20250715-quick-misty-rottweiler-9ae7f7@krzk-bin> (raw)
In-Reply-To: <20250714210227.714841-7-mailingradian@gmail.com>
On Mon, Jul 14, 2025 at 05:02:29PM -0400, Richard Acayan wrote:
> + avdd-supply:
> + description: Analog power supply.
> +
> + dvdd-supply:
> + description: Digital power supply.
> +
> + dovdd-supply:
> + description: Interface power supply.
> +
> + reset-gpios:
> + maxItems: 1
> +
> + port:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + additionalProperties: false
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml
> + unevaluatedProperties: false
> +
> + required:
> + - link-frequencies
> +
> + required:
> + - endpoint
> +
> +unevaluatedProperties: false
Still wrongly placed. Look at example schema or other bindings, this
goes after required.
> +
> +required:
> + - compatible
> + - reg
> + - clocks
Still missing supplies. Hardware cannot operate without power. Please
check your datasheet which will describe which supplies are optional.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-15 8:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 21:02 [PATCH v2 0/4] media: i2c: IMX355 for the Pixel 3a Richard Acayan
2025-07-14 21:02 ` [PATCH v2 1/4] dt-bindings: media: i2c: Add Sony IMX355 Richard Acayan
2025-07-15 8:27 ` Krzysztof Kozlowski [this message]
2025-07-17 21:51 ` Richard Acayan
2025-07-18 6:24 ` Krzysztof Kozlowski
2025-07-14 21:02 ` [PATCH v2 2/4] media: i2c: imx355: Support devicetree and power management Richard Acayan
2025-07-15 10:04 ` Konrad Dybcio
2025-07-14 21:02 ` [PATCH v2 3/4] arm64: dts: qcom: sdm670: remove camss endpoint nodes Richard Acayan
2025-07-14 21:02 ` [PATCH v2 4/4] arm64: dts: qcom: sdm670-google-sargo: add imx355 front camera Richard Acayan
2025-07-15 10:05 ` Konrad Dybcio
2025-07-15 8:25 ` [PATCH v2 0/4] media: i2c: IMX355 for the Pixel 3a Krzysztof Kozlowski
2025-07-15 8:49 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250715-quick-misty-rottweiler-9ae7f7@krzk-bin \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=mchehab@kernel.org \
--cc=robert.mader@collabora.com \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox