* [PATCH 0/2] i3c: add support for the Renesas controller @ 2025-07-14 9:12 Wolfram Sang 2025-07-14 9:12 ` [PATCH 1/2] dt-bindings: i3c: renesas,i3c: Add binding for Renesas I3C controller Wolfram Sang 0 siblings, 1 reply; 4+ messages in thread From: Wolfram Sang @ 2025-07-14 9:12 UTC (permalink / raw) To: linux-renesas-soc Cc: Wolfram Sang, Alexandre Belloni, Conor Dooley, devicetree, Frank Li, Geert Uytterhoeven, Gustavo A. R. Silva, Kees Cook, Krzysztof Kozlowski, linux-hardening, linux-i3c, Magnus Damm, Philipp Zabel, Rob Herring, Tommaso Merciai Here is a basic driver for the I3C IP found in various Renesas SoCs like RZ/G3S and G3E. Missing features to be added incrementally are IBI, HotJoin and maybe target support. Other than that, this driver has been tested with I3C pure busses (2 targets) and mixed busses (2 I3C + various I2C targets). DAA and reading/writing to the temperature sensors worked reliably at different speeds. Scoping the bus, the output from the protocol analyzer seems reasonable, too. It was created by merging two versions of it from two different BSPs. Then, improved according to code analyzers, cleaned up with regard to coding style, and then refactored to hopefully match I3C subsystem standards. Changes since RFC are described in the individual patches. A branch with enablement patches for RZ/G3S+G3E can be found here: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/g3s/i3c Looking forward to comments, Wolfram Tommaso Merciai (1): dt-bindings: i3c: renesas,i3c: Add binding for Renesas I3C controller Wolfram Sang (1): i3c: add driver for Renesas I3C controller .../devicetree/bindings/i3c/renesas,i3c.yaml | 180 +++ MAINTAINERS | 7 + drivers/i3c/master/Kconfig | 10 + drivers/i3c/master/Makefile | 1 + drivers/i3c/master/renesas-i3c.c | 1433 +++++++++++++++++ 5 files changed, 1631 insertions(+) create mode 100644 Documentation/devicetree/bindings/i3c/renesas,i3c.yaml create mode 100644 drivers/i3c/master/renesas-i3c.c -- 2.47.2 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] dt-bindings: i3c: renesas,i3c: Add binding for Renesas I3C controller 2025-07-14 9:12 [PATCH 0/2] i3c: add support for the Renesas controller Wolfram Sang @ 2025-07-14 9:12 ` Wolfram Sang 2025-07-15 3:44 ` Rob Herring 0 siblings, 1 reply; 4+ messages in thread From: Wolfram Sang @ 2025-07-14 9:12 UTC (permalink / raw) To: linux-renesas-soc Cc: Tommaso Merciai, Wolfram Sang, Alexandre Belloni, Frank Li, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven, Magnus Damm, linux-i3c, devicetree From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com> Available in R9A08G045 (RZ/G3S), R9A09G047 (RZ/G3E) SoCs. Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- Changes since RFC: * resorted the clks, so G3S can only have the first two while G3E needs needs all three .../devicetree/bindings/i3c/renesas,i3c.yaml | 180 ++++++++++++++++++ 1 file changed, 180 insertions(+) create mode 100644 Documentation/devicetree/bindings/i3c/renesas,i3c.yaml diff --git a/Documentation/devicetree/bindings/i3c/renesas,i3c.yaml b/Documentation/devicetree/bindings/i3c/renesas,i3c.yaml new file mode 100644 index 000000000000..f53a176cad2c --- /dev/null +++ b/Documentation/devicetree/bindings/i3c/renesas,i3c.yaml @@ -0,0 +1,180 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/i3c/renesas,i3c.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Renesas RZ/G3S and RZ/G3E I3C Bus Interface + +maintainers: + - Wolfram Sang <wsa+renesas@sang-engineering.com> + - Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com> + +properties: + compatible: + items: + - enum: + - renesas,r9a08g045-i3c # RZ/G3S + - renesas,r9a09g047-i3c # RZ/G3E + - const: renesas,i3c + + reg: + maxItems: 1 + + interrupts: + items: + - description: Non-recoverable internal error interrupt + - description: Normal transfer error interrupt + - description: Normal transfer abort interrupt + - description: Normal response status buffer full interrupt + - description: Normal command buffer empty interrupt + - description: Normal IBI status buffer full interrupt + - description: Normal Rx data buffer full interrupt + - description: Normal Tx data buffer empty interrupt + - description: Normal receive status buffer full interrupt + - description: START condition detection interrupt + - description: STOP condition detection interrupt + - description: Transmit end interrupt + - description: NACK detection interrupt + - description: Arbitration lost interrupt + - description: Timeout detection interrupt + - description: Wake-up condition detection interrupt + - description: HDR Exit Pattern detection interrupt + minItems: 16 + + interrupt-names: + items: + - const: ierr + - const: terr + - const: abort + - const: resp + - const: cmd + - const: ibi + - const: rx + - const: tx + - const: rcv + - const: st + - const: sp + - const: tend + - const: nack + - const: al + - const: tmo + - const: wu + - const: exit + minItems: 16 + + clocks: + items: + - description: APB bus clock + - description: transfer clock + - description: SFRs clock + minItems: 2 + + clock-names: + items: + - const: pclk + - const: tclk + - const: pclkrw + minItems: 2 + + power-domains: + maxItems: 1 + + resets: + items: + - description: Reset signal + - description: APB interface reset signal/SCAN reset signal + + reset-names: + items: + - const: presetn + - const: tresetn + +required: + - compatible + - reg + - interrupts + - interrupt-names + - clock-names + - clocks + - power-domains + - resets + - reset-names + +allOf: + - $ref: i3c.yaml# + + - if: + properties: + compatible: + contains: + const: renesas,r9a08g045-i3c + then: + properties: + clocks: + maxItems: 2 + clock-names: + maxItems: 2 + interrupts: + minItems: 17 + interrupt-names: + minItems: 17 + + - if: + properties: + compatible: + contains: + const: renesas,r9a09g047-i3c + then: + properties: + clocks: + minItems: 3 + clock-names: + minItems: 3 + interrupts: + maxItems: 16 + interrupt-names: + maxItems: 16 + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/clock/r9a08g045-cpg.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + i3c@1005b000 { + compatible = "renesas,r9a08g045-i3c", "renesas,i3c"; + reg = <0x1005b000 0x1000>; + clocks = <&cpg CPG_MOD R9A08G045_I3C_PCLK>, + <&cpg CPG_MOD R9A08G045_I3C_TCLK>; + clock-names = "pclk", "tclk"; + interrupts = <GIC_SPI 289 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 293 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 294 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 295 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 296 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 297 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 298 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 299 IRQ_TYPE_EDGE_RISING>, + <GIC_SPI 304 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 311 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "ierr", "terr", "abort", "resp", + "cmd", "ibi", "rx", "tx", "rcv", + "st", "sp", "tend", "nack", + "al", "tmo", "wu", "exit"; + resets = <&cpg R9A08G045_I3C_PRESETN>, + <&cpg R9A08G045_I3C_TRESETN>; + reset-names = "presetn", "tresetn"; + power-domains = <&cpg>; + #address-cells = <3>; + #size-cells = <0>; + }; +... -- 2.47.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: i3c: renesas,i3c: Add binding for Renesas I3C controller 2025-07-14 9:12 ` [PATCH 1/2] dt-bindings: i3c: renesas,i3c: Add binding for Renesas I3C controller Wolfram Sang @ 2025-07-15 3:44 ` Rob Herring 2025-07-15 8:49 ` Wolfram Sang 0 siblings, 1 reply; 4+ messages in thread From: Rob Herring @ 2025-07-15 3:44 UTC (permalink / raw) To: Wolfram Sang Cc: linux-renesas-soc, Tommaso Merciai, Alexandre Belloni, Frank Li, Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven, Magnus Damm, linux-i3c, devicetree On Mon, Jul 14, 2025 at 11:12:08AM +0200, Wolfram Sang wrote: > From: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com> > > Available in R9A08G045 (RZ/G3S), R9A09G047 (RZ/G3E) SoCs. > > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > > Changes since RFC: > * resorted the clks, so G3S can only have the first two while G3E needs > needs all three > > .../devicetree/bindings/i3c/renesas,i3c.yaml | 180 ++++++++++++++++++ > 1 file changed, 180 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i3c/renesas,i3c.yaml > > diff --git a/Documentation/devicetree/bindings/i3c/renesas,i3c.yaml b/Documentation/devicetree/bindings/i3c/renesas,i3c.yaml > new file mode 100644 > index 000000000000..f53a176cad2c > --- /dev/null > +++ b/Documentation/devicetree/bindings/i3c/renesas,i3c.yaml > @@ -0,0 +1,180 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i3c/renesas,i3c.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas RZ/G3S and RZ/G3E I3C Bus Interface > + > +maintainers: > + - Wolfram Sang <wsa+renesas@sang-engineering.com> > + - Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com> > + > +properties: > + compatible: > + items: > + - enum: > + - renesas,r9a08g045-i3c # RZ/G3S > + - renesas,r9a09g047-i3c # RZ/G3E You already have to have differences between these 2. So how are they the same and compatible with this: > + - const: renesas,i3c Even without a difference, this seems like it will be short lived for how many SoC will be compatible with it (though we get to keep it forever). Rob ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: i3c: renesas,i3c: Add binding for Renesas I3C controller 2025-07-15 3:44 ` Rob Herring @ 2025-07-15 8:49 ` Wolfram Sang 0 siblings, 0 replies; 4+ messages in thread From: Wolfram Sang @ 2025-07-15 8:49 UTC (permalink / raw) To: Rob Herring Cc: linux-renesas-soc, Tommaso Merciai, Alexandre Belloni, Frank Li, Krzysztof Kozlowski, Conor Dooley, Geert Uytterhoeven, Magnus Damm, linux-i3c, devicetree > > + - enum: > > + - renesas,r9a08g045-i3c # RZ/G3S > > + - renesas,r9a09g047-i3c # RZ/G3E > > You already have to have differences between these 2. So how are they > the same and compatible with this: > > > + - const: renesas,i3c > > Even without a difference, this seems like it will be short lived for > how many SoC will be compatible with it (though we get to keep it > forever). Ack, will drop. Thanks for the review! ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-15 8:49 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2025-07-14 9:12 [PATCH 0/2] i3c: add support for the Renesas controller Wolfram Sang 2025-07-14 9:12 ` [PATCH 1/2] dt-bindings: i3c: renesas,i3c: Add binding for Renesas I3C controller Wolfram Sang 2025-07-15 3:44 ` Rob Herring 2025-07-15 8:49 ` Wolfram Sang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).