From: Krzysztof Kozlowski <krzk@kernel.org>
To: Anjelique Melendez <anjelique.melendez@oss.qualcomm.com>
Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
dmitry.baryshkov@oss.qualcomm.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: soc: qcom: qcom,pmic-glink: Add qcom,subsys-restart property
Date: Wed, 16 Jul 2025 10:33:56 +0200 [thread overview]
Message-ID: <20250716-functional-loutish-peccary-dcb4c6@krzk-bin> (raw)
In-Reply-To: <20250716004004.311001-2-anjelique.melendez@oss.qualcomm.com>
On Tue, Jul 15, 2025 at 05:40:03PM -0700, Anjelique Melendez wrote:
> Add new "qcom,subsys-restart" property to enable subsystem restart (SSR)
> notifications.
>
> Signed-off-by: Anjelique Melendez <anjelique.melendez@oss.qualcomm.com>
> ---
> .../devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> index 4c9e78f29523..90011096894e 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,pmic-glink.yaml
> @@ -49,6 +49,10 @@ properties:
> '#size-cells':
> const: 0
>
> + qcom,subsys-restart:
> + description: If property is specified subsystem restart (SSR) notifications will be enabled.
Please wrap according to Linux coding style... if this stays, because
this all sounds like Linux notificatons, so an OS property.
The commit msg explains nothing - just repeats this. You need to
describe the hardware and the reasons behind this change - WHY you are
doing things - in terms of hardware.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-16 8:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 0:40 [PATCH v2 0/2] soc: qcom: pmic_glink: Add support for subsystem restart (SSR) Anjelique Melendez
2025-07-16 0:40 ` [PATCH v2 1/2] dt-bindings: soc: qcom: qcom,pmic-glink: Add qcom,subsys-restart property Anjelique Melendez
2025-07-16 8:33 ` Krzysztof Kozlowski [this message]
2025-07-20 4:15 ` Bjorn Andersson
2025-07-16 0:40 ` [PATCH v2 2/2] soc: qcom: pmic_glink: Add support for subsystem restart (SSR) Anjelique Melendez
2025-07-16 8:35 ` Krzysztof Kozlowski
2025-07-20 4:18 ` Bjorn Andersson
2025-07-16 8:36 ` [PATCH v2 0/2] " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716-functional-loutish-peccary-dcb4c6@krzk-bin \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=anjelique.melendez@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox