From: Greg KH <gregkh@linuxfoundation.org>
To: Abd-Alrhman Masalkhi <abd.masalkhi@gmail.com>
Cc: arnd@arndb.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, luoyifan@cmss.chinamobile.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
christophe.jaillet@wanadoo.fr
Subject: Re: [PATCH v6 2/3] eeprom: add driver for ST M24LR series RFID/NFC EEPROM chips
Date: Wed, 16 Jul 2025 13:53:34 +0200 [thread overview]
Message-ID: <2025071651-pushcart-scapegoat-6155@gregkh> (raw)
In-Reply-To: <20250706105311.395162-3-abd.masalkhi@gmail.com>
On Sun, Jul 06, 2025 at 10:53:10AM +0000, Abd-Alrhman Masalkhi wrote:
> +/**
> + * m24lr_parse_le_value - Parse hex string and convert to little-endian binary
> + * @buf: Input string buffer (hex format)
> + * @reg_size: Size of the register in bytes (must be 1, 2, 4, or 8)
> + * @output: Output buffer to store the value in little-endian format
> + *
> + * Converts a hexadecimal string to a numeric value of the given register size
> + * and writes it in little-endian byte order into the provided buffer.
> + *
> + * Return: 0 on success, or negative error code on failure
> + */
> +static __maybe_unused int m24lr_parse_le_value(const char *buf, u32 reg_size,
> + u8 *output)
Your __maybe_unused marker here hid the fact that it is NOT used
anywhere in this driver :(
Please remove this function as it's not needed.
thanks,
greg k-h
next prev parent reply other threads:[~2025-07-16 11:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-06 10:53 [PATCH v6 0/3] Add support for STMicroelectronics M24LR EEPROM/NFC chips Abd-Alrhman Masalkhi
2025-07-06 10:53 ` [PATCH v6 1/3] dt-bindings: eeprom: Add ST M24LR support Abd-Alrhman Masalkhi
2025-07-06 10:53 ` [PATCH v6 2/3] eeprom: add driver for ST M24LR series RFID/NFC EEPROM chips Abd-Alrhman Masalkhi
2025-07-15 15:36 ` Abd-Alrhman Masalkhi
2025-07-16 11:53 ` Greg KH [this message]
2025-07-16 14:21 ` Abd-Alrhman Masalkhi
2025-07-06 10:53 ` [PATCH v6 3/3] ABI: sysfs: add documentation for ST M24LR EEPROM and control interface Abd-Alrhman Masalkhi
2025-07-15 15:42 ` Abd-Alrhman Masalkhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025071651-pushcart-scapegoat-6155@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=abd.masalkhi@gmail.com \
--cc=arnd@arndb.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luoyifan@cmss.chinamobile.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox