* [PATCH 1/1] arm: dts: rockchip: Add initial support for LinkStar H68K-1432v1 Board with RK3568 SoC
@ 2025-07-18 11:50 Erik Beck
2025-07-18 13:13 ` Heiko Stuebner
0 siblings, 1 reply; 3+ messages in thread
From: Erik Beck @ 2025-07-18 11:50 UTC (permalink / raw)
To: linux-rockchip, linux-arm-kernel, devicetree, linux-kernel, soc; +Cc: heiko
Hello,
Below please find a patch to three files to provide initial support for
the LinkStar H68K-1432v1 board with Rockchip rk3568 SOC.
This has been tested on the hardware and works well in support of
router features. Namely, it supports:
* Two 1 Gbs Ethernet ports
* Two 2.5 Gbs Ethernet ports
* Two USB 3.0 Type A sockets
* One USB 3.0 Type C socket
* One USB 2.0 Type A socket
* WiFi
* LED
* Debug console
I look forward to receiving and responding to questions, comments,
concerns, and critiques.
Thank you for your reviews.
Regards,
Erik
Signed-off-by: Erik Beck <xunil@tahomasoft.com>
Tested-by: Erik Beck <xunil@tahomasoft.com>
.../devicetree/bindings/arm/rockchip.yaml | 5 +
arch/arm64/boot/dts/rockchip/Makefile | 1 +
.../dts/rockchip/rk3568-linkstar-h68k-1432v1.dts | 777
+++++++++++++++++++++ 3 files changed, 783 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
b/Documentation/devicetree/bindings/arm/rockchip.yaml index
28db6bd6aa5b..e48b168cfffe 100644 ---
a/Documentation/devicetree/bindings/arm/rockchip.yaml +++
b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -1137,6
+1137,11 @@ properties:
- const: sakurapi,rk3308-sakurapi-rk3308b
- const: rockchip,rk3308
+ - description: Seeed LinkStar H68K-1432v1 RK3568
+ items:
+ - const: seeed,rk3568-linkstar-h68k-1432v1
+ - const: rockchip,rk3568
+
- description: Sinovoip RK3308 Banana Pi P2 Pro
items:
- const: sinovoip,rk3308-bpi-p2pro
diff --git a/arch/arm64/boot/dts/rockchip/Makefile
b/arch/arm64/boot/dts/rockchip/Makefile index
099520962ffb..00a38d085998 100644 ---
a/arch/arm64/boot/dts/rockchip/Makefile +++
b/arch/arm64/boot/dts/rockchip/Makefile @@ -130,6 +130,7 @@
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-fastrhino-r66s.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-fastrhino-r68s.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-linkstar-h68k-1432v1.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-lubancat-2.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-mecsbc.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-nanopi-r5c.dtb
diff --git
a/arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts
b/arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts new file
mode 100644 index 000000000000..f8f80c7616cd --- /dev/null +++
b/arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts @@ -0,0
+1,777 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +// Copyright
(c) 2022 AmadeusGhost <amadeus@jmu.edu.cn> +//
+// Copyright (c) 2025 TahomaSoft xunil@tahomasoft.com
+//
+// Support for Seeed LinkStar H68K-1432v1
+// Also likely supports LinkStar H68K-1432v2
+// NB: Hinlink H68K is same or very similar under different trade name
+
+/dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/pinctrl/rockchip.h>
+#include <dt-bindings/soc/rockchip,vop2.h>
+#include "rk3568.dtsi"
+
+
+/ {
+ model = "Seeed LinkStar H68K-1432V1 (RK3568) DDR4 Board";
+ compatible = "seeed,rk3568-linkstar-h68k-1432v1",
"rockchip,rk3568"; +
+ aliases {
+ ethernet0 = &gmac0;
+ ethernet1 = &gmac1;
+
+ /* fixed eMMC */
+ mmc0 = &sdhci; /* sdhci:= @fe310000 */ /* mmcblk0...
*/ +
+ /* removable uSD/TF Card */
+ mmc1 = &sdmmc0; /* sdmmc0:= @fe2b0000 */ /* mmcblk1...
*/ +
+ rtc0 = &rk809;
+
+ led-boot = &led_one; /* status LED, green */
+ led-failsafe = &led_three; /* heartbeat LED */
+ led-running = &led_one; /* status LED, green */
+ led-upgrade = &led_two; /* function LED, amber */
+
+ };
+
+ chosen {
+ stdout-path = "serial2:1500000n8";
+ };
+
+ hdmi-con {
+ compatible = "hdmi-connector";
+ type = "a";
+
+ port {
+ hdmi_con_in: endpoint {
+ remote-endpoint = <&hdmi_out_con>;
+ };
+ };
+ };
+
+ gpio-keys {
+ compatible = "gpio-keys";
+ pinctrl-0 = <&reset_button_pin>;
+ pinctrl-names = "default";
+
+ /* Middle inset/recessed button,
+ marked by clockwise arrow/circle */
+
+ button-reset { /* gpiochip=0, line=0 */
+ label = "button:system:reset";
+ gpios = <&gpio0 RK_PA0 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_RESTART>;
+ debounce-interval = <50>;
+ };
+
+ };
+
+ /* gpio chip 0, line 24 responds to console key press */
+
+ gpio-leds {
+ compatible = "gpio-leds";
+ pinctrl-names = "default";
+ pinctrl-0 = <&led_white_pin>, <&led_green_pin>,
+ <&led_amber_pin>, <&led_blue_pin>;
+
+ /* White LED inset in power button */
+
+ led_zero: led_white { /* gpiochip=0, line=14 */
+ color = <LED_COLOR_ID_WHITE>;
+ default-state = "on";
+ function = LED_FUNCTION_POWER;
+ gpios = <&gpio0 RK_PB6 GPIO_ACTIVE_HIGH>;
+ label = "power_button_led:white_led";
+ linux,default-trigger = "default-on";
+
+ };
+
+ led_one: led_green { /* gpiochip=3, line=8 */
+ default-state = "off";
+ color = <LED_COLOR_ID_GREEN>;
+ function = LED_FUNCTION_STATUS;
+ gpios = <&gpio3 RK_PB0 GPIO_ACTIVE_HIGH>;
+ label = "status_led:green_led";
+ };
+
+ led_two: led_amber { /* gpiochip=3, line=7 */
+ default-state = "off";
+ color = <LED_COLOR_ID_AMBER>;
+ function = LED_FUNCTION_INDICATOR;
+ gpios = <&gpio3 RK_PA7 GPIO_ACTIVE_HIGH>;
+ label = "function_led:amber_led";
+ };
+
+ led_three: led_blue { /* gpiochip=3, line=5 */
+ color = <LED_COLOR_ID_BLUE>;
+ gpios = <&gpio3 RK_PA5 GPIO_ACTIVE_HIGH>;
+ default-state = "off";
+ function = LED_FUNCTION_HEARTBEAT;
+ label = "heartbeat_led:blue_led";
+ };
+ };
+
+ vcc12v_dcin: vcc12v-dcin {
+ compatible = "regulator-fixed";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <12000000>;
+ regulator-max-microvolt = <12000000>;
+ regulator-name = "vcc12v_dcin";
+ };
+
+ vcc3v3_sys: vcc3v3-sys {
+ compatible = "regulator-fixed";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc3v3_sys";
+ vin-supply = <&vcc12v_dcin>;
+ };
+
+ vcc5v0_sys: vcc5v0-sys {
+ compatible = "regulator-fixed";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-name = "vcc5v0_sys";
+ vin-supply = <&vcc12v_dcin>;
+ };
+
+ vcc5v0_usb: vcc5v0-usb {
+ compatible = "regulator-fixed";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-name = "vcc5v0_usb";
+ vin-supply = <&vcc12v_dcin>;
+ };
+
+ vcc5v0_usb_host: vcc5v0-usb-host {
+ compatible = "regulator-fixed";
+ enable-active-high;
+ gpio = <&gpio0 RK_PA5 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&vcc5v0_usb_host_en>;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-name = "vcc5v0_usb_host";
+ vin-supply = <&vcc5v0_usb>;
+ };
+
+ vcc3v3_pcie: vcc3v3-pcie {
+ compatible = "regulator-fixed";
+ enable-active-high;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc3v3_pcie";
+ startup-delay-us = <5000>;
+ vin-supply = <&vcc5v0_sys>;
+ };
+
+ rk809-sound {
+ compatible = "simple-audio-card";
+ simple-audio-card,format = "i2s";
+ simple-audio-card,name = "Analog RK809";
+ simple-audio-card,mclk-fs = <256>;
+
+ simple-audio-card,cpu {
+ sound-dai = <&i2s1_8ch>;
+ };
+ simple-audio-card,codec {
+ sound-dai = <&rk809>;
+ };
+ };
+
+};
+
+&gmac0 {
+ assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>;
+ assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>;
+ assigned-clock-rates = <0>, <125000000>;
+ clock_in_out = "output";
+ phy-mode = "rgmii-id";
+ pinctrl-names = "default";
+ pinctrl-0 = <&gmac0_miim
+ &gmac0_tx_bus2
+ &gmac0_rx_bus2
+ &gmac0_rgmii_clk
+ &gmac0_rgmii_bus>;
+ snps,reset-gpio = <&gpio2 RK_PD3 GPIO_ACTIVE_LOW>;
+ snps,reset-active-low;
+ snps,reset-delays-us = <0 20000 100000>;
+ tx_delay = <0x3c>;
+ rx_delay = <0x2f>;
+ phy-handle = <&rgmii_phy0>;
+ status = "okay";
+};
+
+&gmac1 {
+ assigned-clocks = <&cru SCLK_GMAC1_RX_TX>, <&cru SCLK_GMAC1>;
+ assigned-clock-parents = <&cru SCLK_GMAC1_RGMII_SPEED>;
+ assigned-clock-rates = <0>, <125000000>;
+ clock_in_out = "output";
+ phy-mode = "rgmii-id";
+ pinctrl-names = "default";
+ pinctrl-0 = <&gmac1m1_miim
+ &gmac1m1_tx_bus2
+ &gmac1m1_rx_bus2
+ &gmac1m1_rgmii_clk
+ &gmac1m1_rgmii_bus>;
+ snps,reset-gpio = <&gpio1 RK_PB0 GPIO_ACTIVE_LOW>;
+ snps,reset-active-low;
+ snps,reset-delays-us = <0 20000 100000>;
+ tx_delay = <0x4f>;
+ rx_delay = <0x26>;
+ phy-handle = <&rgmii_phy1>;
+ status = "okay";
+};
+
+ /* combphy0/multi-phy0 supports one of: usb3.0 otg, sata0 */
+
+&combphy0 {
+ status = "okay";
+
+};
+
+ /* combphy1/multi-phy1 supports one of:
+ - usb3.0 host
+ - sata1
+ - qsgmii/sgmii
+ */
+
+&combphy1 {
+ status = "okay";
+};
+
+ /* combphy2/multi-phy2 supports one of:
+ - pcie2.1
+ - sata2
+ - qsgmii/sgmii
+ */
+
+&combphy2 {
+ status = "okay";
+};
+
+&cpu0 {
+ cpu-supply = <&vdd_cpu>;
+};
+
+&cpu1 {
+ cpu-supply = <&vdd_cpu>;
+};
+
+&cpu2 {
+ cpu-supply = <&vdd_cpu>;
+};
+
+&cpu3 {
+ cpu-supply = <&vdd_cpu>;
+};
+
+&gpu {
+ mali-supply = <&vdd_gpu>;
+ status = "okay";
+};
+
+&hdmi {
+ avdd-0v9-supply = <&vdda0v9_image>;
+ avdd-1v8-supply = <&vcca1v8_image>;
+ status = "okay";
+};
+
+&hdmi_in {
+ hdmi_in_vp0: endpoint {
+ remote-endpoint = <&vp0_out_hdmi>;
+ };
+};
+
+&hdmi_out {
+ hdmi_out_con: endpoint {
+ remote-endpoint = <&hdmi_con_in>;
+ };
+};
+
+&hdmi_sound {
+ status = "okay";
+};
+
+&i2c0 {
+ status = "okay";
+
+ vdd_cpu: regulator@1c {
+ compatible = "tcs,tcs4525";
+ reg = <0x1c>;
+ fcs,suspend-voltage-selector = <1>;
+ regulator-name = "vdd_cpu";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <1150000>;
+ regulator-ramp-delay = <2300>;
+ vin-supply = <&vcc5v0_sys>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ rk809: pmic@20 {
+ compatible = "rockchip,rk809";
+ reg = <0x20>;
+ interrupt-parent = <&gpio0>;
+ interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;
+ assigned-clocks = <&cru I2S1_MCLKOUT_TX>;
+ assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>;
+ #clock-cells = <1>;
+ clock-names = "mclk";
+ clocks = <&cru I2S1_MCLKOUT_TX>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pmic_int>, <&i2s1m0_mclk>;
+ rockchip,system-power-controller;
+ #sound-dai-cells = <0>;
+ wakeup-source;
+
+ vcc1-supply = <&vcc3v3_sys>;
+ vcc2-supply = <&vcc3v3_sys>;
+ vcc3-supply = <&vcc3v3_sys>;
+ vcc4-supply = <&vcc3v3_sys>;
+ vcc5-supply = <&vcc3v3_sys>;
+ vcc6-supply = <&vcc3v3_sys>;
+ vcc7-supply = <&vcc3v3_sys>;
+ vcc8-supply = <&vcc3v3_sys>;
+ vcc9-supply = <&vcc3v3_sys>;
+
+ regulators {
+ vdd_logic: DCDC_REG1 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-initial-mode = <0x2>;
+ regulator-min-microvolt = <500000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-name = "vdd_logic";
+ regulator-ramp-delay = <6001>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdd_gpu: DCDC_REG2 {
+ regulator-always-on;
+ regulator-initial-mode = <0x2>;
+ regulator-min-microvolt = <500000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-name = "vdd_gpu";
+ regulator-ramp-delay = <6001>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcc_ddr: DCDC_REG3 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-initial-mode = <0x2>;
+ regulator-name = "vcc_ddr";
+
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ };
+ };
+
+ vdd_npu: DCDC_REG4 {
+ regulator-initial-mode = <0x2>;
+ regulator-min-microvolt = <500000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-name = "vdd_npu";
+ regulator-ramp-delay = <6001>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcc_1v8: DCDC_REG5 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcc_1v8";
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdda0v9_image: LDO_REG1 {
+ regulator-name = "vdda0v9_image";
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <900000>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdda_0v9: LDO_REG2 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <900000>;
+ regulator-name = "vdda_0v9";
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdda0v9_pmu: LDO_REG3 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <900000>;
+ regulator-name = "vdda0v9_pmu";
+
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt =
<900000>;
+ };
+ };
+
+ vccio_acodec: LDO_REG4 {
+ regulator-always-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vccio_acodec";
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vccio_sd: LDO_REG5 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vccio_sd";
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcc3v3_pmu: LDO_REG6 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc3v3_pmu";
+
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt =
<3300000>;
+ };
+ };
+
+ vcca_1v8: LDO_REG7 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcca_1v8";
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcca1v8_pmu: LDO_REG8 {
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcca1v8_pmu";
+
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt =
<1800000>;
+ };
+ };
+
+ vcca1v8_image: LDO_REG9 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ regulator-name = "vcca1v8_image";
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcc_3v3: SWITCH_REG1 {
+ regulator-name = "vcc_3v3";
+ regulator-always-on;
+ regulator-boot-on;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcc3v3_sd: SWITCH_REG2 {
+ regulator-name = "vcc3v3_sd";
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+ };
+
+ codec {
+ rockchip,mic-in-differential;
+ };
+ };
+};
+
+&i2s0_8ch {
+ status = "okay";
+};
+
+&i2s1_8ch {
+ rockchip,trcm-sync-tx-only;
+ status = "okay";
+};
+
+&mdio0 {
+ rgmii_phy0: ethernet-phy@0 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <0x0>;
+ };
+};
+
+&mdio1 {
+ rgmii_phy1: ethernet-phy@0 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <0x0>;
+ };
+};
+
+&pcie30phy {
+ data-lanes = <1 2>;
+ status = "okay";
+};
+
+&pcie2x1 {
+ /* bus-range = <0x00 0x0f>; ?wrong? in rk356x.dtsi */
+ reset-gpios = <&gpio2 RK_PD6 GPIO_ACTIVE_HIGH>;
+ vpcie3v3-supply = <&vcc3v3_pcie>;
+ status = "okay";
+};
+
+&pcie3x1 {
+ num-lanes= <1>;
+ bus-range = <0x10 0x1f>;
+ reset-gpios = <&gpio3 RK_PA4 GPIO_ACTIVE_HIGH>;
+ vpcie3v3-supply = <&vcc3v3_pcie>;
+ status = "okay";
+
+};
+
+&pcie3x2 {
+ num-lanes= <1>;
+ bus-range = <0x20 0x2f>;
+ reset-gpios = <&gpio2 RK_PD0 GPIO_ACTIVE_HIGH>;
+ vpcie3v3-supply = <&vcc3v3_pcie>;
+ status = "okay";
+};
+
+&pinctrl {
+ button {
+ reset_button_pin: reset-button-pin {
+ rockchip,pins = <0 RK_PA0 RK_FUNC_GPIO
&pcfg_pull_up>;
+ };
+ };
+
+ bluetooth {
+ bt_wake_host_h: bt-wake-host-h {
+ rockchip,pins = <3 RK_PA1 RK_FUNC_GPIO
&pcfg_pull_down>;
+ };
+
+ host_wake_bt_h: host-wake-bt-h {
+ rockchip,pins = <3 RK_PA2 RK_FUNC_GPIO
&pcfg_pull_none>;
+ };
+ };
+
+ gpio-leds {
+ led_white_pin: led-white-pin {
+ rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO
&pcfg_pull_none>;
+ };
+
+ led_green_pin: led-green-pin {
+ rockchip,pins = <3 RK_PB0 RK_FUNC_GPIO
&pcfg_pull_none>;
+ };
+
+ led_amber_pin: led-amber-pin {
+ rockchip,pins = <3 RK_PA7 RK_FUNC_GPIO
&pcfg_pull_none>;
+ };
+
+ led_blue_pin: led-blue-pin {
+ rockchip,pins = <3 RK_PA5 RK_FUNC_GPIO
&pcfg_pull_none>;
+ };
+
+ };
+
+ pmic {
+ pmic_int: pmic_int {
+ rockchip,pins = <0 RK_PA3 RK_FUNC_GPIO
&pcfg_pull_up>;
+ };
+ };
+
+ usb {
+ vcc5v0_usb_host_en: vcc5v0_usb_host_en {
+ rockchip,pins = <0 RK_PA5 RK_FUNC_GPIO
&pcfg_pull_none>;
+ };
+ };
+};
+
+&pmu_io_domains {
+ pmuio1-supply = <&vcc3v3_pmu>;
+ pmuio2-supply = <&vcc3v3_pmu>;
+ vccio1-supply = <&vccio_acodec>;
+ vccio2-supply = <&vcc_1v8>;
+ vccio3-supply = <&vccio_sd>;
+ vccio4-supply = <&vcc_1v8>;
+ vccio5-supply = <&vcc_3v3>;
+ vccio6-supply = <&vcc_1v8>;
+ vccio7-supply = <&vcc_3v3>;
+ status = "okay";
+};
+
+&rng {
+ status = "okay";
+};
+
+&saradc {
+ vref-supply = <&vcca_1v8>;
+ status = "okay";
+};
+
+&sata0 { /* sata0 muxed with USB3-OTG */
+ status = "disabled";
+};
+
+&sata1 { /* sata1 muxed with QSGMII and USB3-A 5G LTE Host1 */
+ status = "disabled";
+};
+
+&sata2 { /* sata 2 muxed with pcie2.0 and QSGMII_M1 M2 Wifi */
+ status = "disabled";
+};
+
+&sdhci {
+ bus-width = <8>;
+ max-frequency = <200000000>;
+ non-removable;
+ pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastrobe>;
+ status = "okay";
+};
+
+&sdmmc0 {
+ bus-width = <4>;
+ cap-sd-highspeed;
+ cd-gpios = <&gpio0 RK_PA4 GPIO_ACTIVE_LOW>;
+ disable-wp;
+ pinctrl-names = "default";
+ pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
+ sd-uhs-sdr104;
+ vmmc-supply = <&vcc3v3_sd>;
+ vqmmc-supply = <&vccio_sd>;
+ status = "okay";
+};
+
+&tsadc {
+ rockchip,hw-tshut-mode = <1>;
+ rockchip,hw-tshut-polarity = <0>;
+ status = "okay";
+};
+
+&uart2 {
+ status = "okay";
+};
+
+&usb_host0_ehci {
+ status = "okay";
+};
+
+&usb_host1_ehci {
+ status = "okay";
+};
+
+&usb_host0_ohci {
+ status = "okay";
+};
+
+&usb_host1_ohci {
+ status = "okay";
+};
+
+&usb_host0_xhci {
+ phys = <&combphy0 PHY_TYPE_USB3>;
+ phy-names = "usb3-phy";
+ status = "okay";
+};
+
+&usb_host1_xhci {
+ status = "okay";
+};
+
+&usb2phy0 {
+ status = "okay";
+};
+
+&usb2phy0_host {
+ phy-supply = <&vcc5v0_usb_host>;
+ status = "okay";
+};
+
+&usb2phy1 {
+ status = "okay";
+};
+
+&usb2phy1_host {
+ phy-supply = <&vcc5v0_usb_host>;
+ status = "okay";
+};
+
+&usb2phy1_otg {
+ phy-supply = <&vcc5v0_usb_host>;
+ status = "okay";
+};
+
+&vop {
+ assigned-clocks = <&cru DCLK_VOP0>, <&cru DCLK_VOP1>;
+ assigned-clock-parents = <&pmucru PLL_HPLL>, <&cru PLL_VPLL>;
+ status = "okay";
+};
+
+&vop_mmu {
+ status = "okay";
+};
+
+&vp0 {
+ vp0_out_hdmi: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
+ reg = <ROCKCHIP_VOP2_EP_HDMI0>;
+ remote-endpoint = <&hdmi_in_vp0>;
+ };
+};
+
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] arm: dts: rockchip: Add initial support for LinkStar H68K-1432v1 Board with RK3568 SoC
2025-07-18 11:50 [PATCH 1/1] arm: dts: rockchip: Add initial support for LinkStar H68K-1432v1 Board with RK3568 SoC Erik Beck
@ 2025-07-18 13:13 ` Heiko Stuebner
2025-07-18 13:21 ` Erik Beck
0 siblings, 1 reply; 3+ messages in thread
From: Heiko Stuebner @ 2025-07-18 13:13 UTC (permalink / raw)
To: linux-rockchip, linux-arm-kernel, devicetree, linux-kernel, soc,
Erik Beck
Hi Erik,
Am Freitag, 18. Juli 2025, 13:50:58 Mitteleuropäische Sommerzeit schrieb Erik Beck:
> Hello,
>
> Below please find a patch to three files to provide initial support for
> the LinkStar H68K-1432v1 board with Rockchip rk3568 SOC.
>
> This has been tested on the hardware and works well in support of
> router features. Namely, it supports:
>
> * Two 1 Gbs Ethernet ports
> * Two 2.5 Gbs Ethernet ports
> * Two USB 3.0 Type A sockets
> * One USB 3.0 Type C socket
> * One USB 2.0 Type A socket
> * WiFi
> * LED
> * Debug console
>
> I look forward to receiving and responding to questions, comments,
> concerns, and critiques.
>
> Thank you for your reviews.
>
> Regards,
>
> Erik
The above test reads more like a cover-letter instead of a commit
message. Please take look at how other board additions are worded.
> Signed-off-by: Erik Beck <xunil@tahomasoft.com>
> Tested-by: Erik Beck <xunil@tahomasoft.com>
>
> .../devicetree/bindings/arm/rockchip.yaml | 5 +
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../dts/rockchip/rk3568-linkstar-h68k-1432v1.dts | 777
please split this into two commits, one adding the yaml binding and
one adding the board devicetree.
Also please check scripts/get_maintainer.pl to see who to Cc explicitly
(like the devicetree maintainers)
> +++++++++++++++++++++ 3 files changed, 783 insertions(+)
>
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
> b/Documentation/devicetree/bindings/arm/rockchip.yaml index
> 28db6bd6aa5b..e48b168cfffe 100644 ---
please try to use "git send-email" to send patches, because it looks
like your mail program mangled the patch by adding line breaks
(more of them below). So the patch most likely won't apply.
> diff --git
> a/arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts
> b/arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts new file
> mode 100644 index 000000000000..f8f80c7616cd --- /dev/null +++
> b/arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts @@ -0,0
> +1,777 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +// Copyright
> (c) 2022 AmadeusGhost <amadeus@jmu.edu.cn> +//
> +// Copyright (c) 2025 TahomaSoft xunil@tahomasoft.com
> +//
> +// Support for Seeed LinkStar H68K-1432v1
> +// Also likely supports LinkStar H68K-1432v2
> +// NB: Hinlink H68K is same or very similar under different trade name
please use preferred comment style - see other kernel devicetrees.
> +
> +/dts-v1/;
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/input/input.h>
> +#include <dt-bindings/pinctrl/rockchip.h>
> +#include <dt-bindings/soc/rockchip,vop2.h>
> +#include "rk3568.dtsi"
> +
> +
> +/ {
> + model = "Seeed LinkStar H68K-1432V1 (RK3568) DDR4 Board";
> + compatible = "seeed,rk3568-linkstar-h68k-1432v1",
> "rockchip,rk3568"; +
> + aliases {
> + ethernet0 = &gmac0;
> + ethernet1 = &gmac1;
> +
> + /* fixed eMMC */
> + mmc0 = &sdhci; /* sdhci:= @fe310000 */ /* mmcblk0...
> */
no need for the comments before and after the alias, same below
> +
> + /* removable uSD/TF Card */
> + mmc1 = &sdmmc0; /* sdmmc0:= @fe2b0000 */ /* mmcblk1...
> */ +
> + rtc0 = &rk809;
> +
> + led-boot = &led_one; /* status LED, green */
> + led-failsafe = &led_three; /* heartbeat LED */
> + led-running = &led_one; /* status LED, green */
> + led-upgrade = &led_two; /* function LED, amber */
I don't think those are specified? What is supposed to use those?
> +
unneeded empty line
> + };
> +
[...]
> + gpio-keys {
> + compatible = "gpio-keys";
> + pinctrl-0 = <&reset_button_pin>;
> + pinctrl-names = "default";
> +
> + /* Middle inset/recessed button,
> + marked by clockwise arrow/circle */
> +
> + button-reset { /* gpiochip=0, line=0 */
again unneeded comment ... that content is contained in the gpios
property already
> + label = "button:system:reset";
> + gpios = <&gpio0 RK_PA0 GPIO_ACTIVE_LOW>;
> + linux,code = <KEY_RESTART>;
> + debounce-interval = <50>;
> + };
> +
> + };
> +
> + /* gpio chip 0, line 24 responds to console key press */
> +
> + gpio-leds {
> + compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&led_white_pin>, <&led_green_pin>,
> + <&led_amber_pin>, <&led_blue_pin>;
> +
> + /* White LED inset in power button */
that commment is helpful, so could stay
> +
> + led_zero: led_white { /* gpiochip=0, line=14 */
preferred naming would probably be
led_white: led-0 {}
similar for the other ones
> + color = <LED_COLOR_ID_WHITE>;
> + default-state = "on";
> + function = LED_FUNCTION_POWER;
> + gpios = <&gpio0 RK_PB6 GPIO_ACTIVE_HIGH>;
> + label = "power_button_led:white_led";
> + linux,default-trigger = "default-on";
> +
> + };
> +
> + vcc12v_dcin: vcc12v-dcin {
vcc12v_dcin: regulator-vcc12v-dcin {}
same for the others
> + compatible = "regulator-fixed";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <12000000>;
> + regulator-max-microvolt = <12000000>;
> + regulator-name = "vcc12v_dcin";
> + };
> +
> +&gmac0 {
> + assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>;
> + assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>;
> + assigned-clock-rates = <0>, <125000000>;
> + clock_in_out = "output";
> + phy-mode = "rgmii-id";
> + pinctrl-names = "default";
> + pinctrl-0 = <&gmac0_miim
> + &gmac0_tx_bus2
> + &gmac0_rx_bus2
> + &gmac0_rgmii_clk
> + &gmac0_rgmii_bus>;
> + snps,reset-gpio = <&gpio2 RK_PD3 GPIO_ACTIVE_LOW>;
> + snps,reset-active-low;
> + snps,reset-delays-us = <0 20000 100000>;
> + tx_delay = <0x3c>;
> + rx_delay = <0x2f>;
please see other recent mails about those
The rgmii-id above should not need those delays?
> + phy-handle = <&rgmii_phy0>;
> + status = "okay";
> +};
> +
> + /* combphy0/multi-phy0 supports one of: usb3.0 otg, sata0 */
drop the comments
> +&combphy0 {
> + status = "okay";
> +
> +};
> +
> + /* combphy1/multi-phy1 supports one of:
> + - usb3.0 host
> + - sata1
> + - qsgmii/sgmii
> + */
> +
> +&combphy1 {
> + status = "okay";
> +};
> +
> + /* combphy2/multi-phy2 supports one of:
> + - pcie2.1
> + - sata2
> + - qsgmii/sgmii
> + */
> +
> +&combphy2 {
> + status = "okay";
> +};
> +
I did stop here for now.
Heiko
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] arm: dts: rockchip: Add initial support for LinkStar H68K-1432v1 Board with RK3568 SoC
2025-07-18 13:13 ` Heiko Stuebner
@ 2025-07-18 13:21 ` Erik Beck
0 siblings, 0 replies; 3+ messages in thread
From: Erik Beck @ 2025-07-18 13:21 UTC (permalink / raw)
To: Heiko Stuebner
Cc: linux-rockchip, linux-arm-kernel, devicetree, linux-kernel, soc
Thanks for the prompt feedback Heiko!
I'll get to work on responding to your comments, which are quite
helpful.
Regards,
Erik
On Fri, 18 Jul 2025 15:13:21 +0200
Heiko Stuebner <heiko@sntech.de> wrote:
> Hi Erik,
>
> Am Freitag, 18. Juli 2025, 13:50:58 Mitteleuropäische Sommerzeit
> schrieb Erik Beck:
> > Hello,
> >
> > Below please find a patch to three files to provide initial support
> > for the LinkStar H68K-1432v1 board with Rockchip rk3568 SOC.
> >
> > This has been tested on the hardware and works well in support of
> > router features. Namely, it supports:
> >
> > * Two 1 Gbs Ethernet ports
> > * Two 2.5 Gbs Ethernet ports
> > * Two USB 3.0 Type A sockets
> > * One USB 3.0 Type C socket
> > * One USB 2.0 Type A socket
> > * WiFi
> > * LED
> > * Debug console
> >
> > I look forward to receiving and responding to questions, comments,
> > concerns, and critiques.
> >
> > Thank you for your reviews.
> >
> > Regards,
> >
> > Erik
>
> The above test reads more like a cover-letter instead of a commit
> message. Please take look at how other board additions are worded.
>
> > Signed-off-by: Erik Beck <xunil@tahomasoft.com>
> > Tested-by: Erik Beck <xunil@tahomasoft.com>
> >
> > .../devicetree/bindings/arm/rockchip.yaml | 5 +
> > arch/arm64/boot/dts/rockchip/Makefile | 1 +
> > .../dts/rockchip/rk3568-linkstar-h68k-1432v1.dts | 777
>
> please split this into two commits, one adding the yaml binding and
> one adding the board devicetree.
>
> Also please check scripts/get_maintainer.pl to see who to Cc
> explicitly (like the devicetree maintainers)
>
>
> > +++++++++++++++++++++ 3 files changed, 783 insertions(+)
> >
> >
> > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > b/Documentation/devicetree/bindings/arm/rockchip.yaml index
> > 28db6bd6aa5b..e48b168cfffe 100644 ---
>
> please try to use "git send-email" to send patches, because it looks
> like your mail program mangled the patch by adding line breaks
> (more of them below). So the patch most likely won't apply.
>
>
> > diff --git
> > a/arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts
> > b/arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts new
> > file mode 100644 index 000000000000..f8f80c7616cd --- /dev/null +++
> > b/arch/arm64/boot/dts/rockchip/rk3568-linkstar-h68k-1432v1.dts @@
> > -0,0 +1,777 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +//
> > Copyright (c) 2022 AmadeusGhost <amadeus@jmu.edu.cn> +//
> > +// Copyright (c) 2025 TahomaSoft xunil@tahomasoft.com
> > +//
> > +// Support for Seeed LinkStar H68K-1432v1
> > +// Also likely supports LinkStar H68K-1432v2
> > +// NB: Hinlink H68K is same or very similar under different trade
> > name
>
> please use preferred comment style - see other kernel devicetrees.
>
> > +
> > +/dts-v1/;
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/leds/common.h>
> > +#include <dt-bindings/input/input.h>
> > +#include <dt-bindings/pinctrl/rockchip.h>
> > +#include <dt-bindings/soc/rockchip,vop2.h>
> > +#include "rk3568.dtsi"
> > +
> > +
> > +/ {
> > + model = "Seeed LinkStar H68K-1432V1 (RK3568) DDR4 Board";
> > + compatible = "seeed,rk3568-linkstar-h68k-1432v1",
> > "rockchip,rk3568"; +
> > + aliases {
> > + ethernet0 = &gmac0;
> > + ethernet1 = &gmac1;
> > +
> > + /* fixed eMMC */
> > + mmc0 = &sdhci; /* sdhci:= @fe310000 */ /*
> > mmcblk0... */
>
> no need for the comments before and after the alias, same below
>
> > +
> > + /* removable uSD/TF Card */
> > + mmc1 = &sdmmc0; /* sdmmc0:= @fe2b0000 */ /*
> > mmcblk1... */ +
> > + rtc0 = &rk809;
> > +
> > + led-boot = &led_one; /* status LED, green */
> > + led-failsafe = &led_three; /* heartbeat LED */
> > + led-running = &led_one; /* status LED, green */
> > + led-upgrade = &led_two; /* function LED, amber */
>
> I don't think those are specified? What is supposed to use those?
>
> > +
>
> unneeded empty line
>
> > + };
> > +
>
> [...]
>
> > + gpio-keys {
> > + compatible = "gpio-keys";
> > + pinctrl-0 = <&reset_button_pin>;
> > + pinctrl-names = "default";
> > +
> > + /* Middle inset/recessed button,
> > + marked by clockwise arrow/circle */
> > +
> > + button-reset { /* gpiochip=0, line=0 */
>
> again unneeded comment ... that content is contained in the gpios
> property already
>
> > + label = "button:system:reset";
> > + gpios = <&gpio0 RK_PA0 GPIO_ACTIVE_LOW>;
> > + linux,code = <KEY_RESTART>;
> > + debounce-interval = <50>;
> > + };
> > +
> > + };
> > +
> > + /* gpio chip 0, line 24 responds to console key press */
> > +
> > + gpio-leds {
> > + compatible = "gpio-leds";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&led_white_pin>, <&led_green_pin>,
> > + <&led_amber_pin>, <&led_blue_pin>;
> > +
> > + /* White LED inset in power button */
>
> that commment is helpful, so could stay
>
> > +
> > + led_zero: led_white { /* gpiochip=0, line=14 */
>
> preferred naming would probably be
> led_white: led-0 {}
>
> similar for the other ones
>
> > + color = <LED_COLOR_ID_WHITE>;
> > + default-state = "on";
> > + function = LED_FUNCTION_POWER;
> > + gpios = <&gpio0 RK_PB6 GPIO_ACTIVE_HIGH>;
> > + label = "power_button_led:white_led";
> > + linux,default-trigger = "default-on";
> > +
> > + };
> > +
> > + vcc12v_dcin: vcc12v-dcin {
>
> vcc12v_dcin: regulator-vcc12v-dcin {}
>
> same for the others
>
> > + compatible = "regulator-fixed";
> > + regulator-always-on;
> > + regulator-boot-on;
> > + regulator-min-microvolt = <12000000>;
> > + regulator-max-microvolt = <12000000>;
> > + regulator-name = "vcc12v_dcin";
> > + };
> > +
>
> > +&gmac0 {
> > + assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru
> > SCLK_GMAC0>;
> > + assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>;
> > + assigned-clock-rates = <0>, <125000000>;
> > + clock_in_out = "output";
> > + phy-mode = "rgmii-id";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&gmac0_miim
> > + &gmac0_tx_bus2
> > + &gmac0_rx_bus2
> > + &gmac0_rgmii_clk
> > + &gmac0_rgmii_bus>;
> > + snps,reset-gpio = <&gpio2 RK_PD3 GPIO_ACTIVE_LOW>;
> > + snps,reset-active-low;
> > + snps,reset-delays-us = <0 20000 100000>;
> > + tx_delay = <0x3c>;
> > + rx_delay = <0x2f>;
>
> please see other recent mails about those
> The rgmii-id above should not need those delays?
>
> > + phy-handle = <&rgmii_phy0>;
> > + status = "okay";
> > +};
> > +
> > + /* combphy0/multi-phy0 supports one of: usb3.0 otg, sata0 */
>
> drop the comments
>
> > +&combphy0 {
> > + status = "okay";
> > +
> > +};
> > +
> > + /* combphy1/multi-phy1 supports one of:
> > + - usb3.0 host
> > + - sata1
> > + - qsgmii/sgmii
> > + */
> > +
> > +&combphy1 {
> > + status = "okay";
> > +};
> > +
> > + /* combphy2/multi-phy2 supports one of:
> > + - pcie2.1
> > + - sata2
> > + - qsgmii/sgmii
> > + */
> > +
> > +&combphy2 {
> > + status = "okay";
> > +};
> > +
>
> I did stop here for now.
>
> Heiko
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-18 13:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-18 11:50 [PATCH 1/1] arm: dts: rockchip: Add initial support for LinkStar H68K-1432v1 Board with RK3568 SoC Erik Beck
2025-07-18 13:13 ` Heiko Stuebner
2025-07-18 13:21 ` Erik Beck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox