[PATCH] dt-bindings: gpio: Convert ti,twl4030-gpio to DT schema

[PATCH] dt-bindings: gpio: Convert ti,twl4030-gpio to DT schema

[Rob Herring (Arm)]

Convert the TI TWL4030 PMIC GPIO binding to DT schema format. The number
of #interrupt-cells was wrong compared to what is in use. Correct it to
be 1.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 .../devicetree/bindings/gpio/gpio-twl4030.txt | 29 ---------
 .../bindings/gpio/ti,twl4030-gpio.yaml        | 61 +++++++++++++++++++
 2 files changed, 61 insertions(+), 29 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/gpio/gpio-twl4030.txt
 create mode 100644 Documentation/devicetree/bindings/gpio/ti,twl4030-gpio.yaml

diff --git a/Documentation/devicetree/bindings/gpio/gpio-twl4030.txt b/Documentation/devicetree/bindings/gpio/gpio-twl4030.txt
deleted file mode 100644
index 66788fda1db3..000000000000
--- a/Documentation/devicetree/bindings/gpio/gpio-twl4030.txt
+++ /dev/null
@@ -1,29 +0,0 @@
-twl4030 GPIO controller bindings
-
-Required properties:
-- compatible:
-  - "ti,twl4030-gpio" for twl4030 GPIO controller
-- #gpio-cells : Should be two.
-  - first cell is the pin number
-  - second cell is used to specify optional parameters (unused)
-- gpio-controller : Marks the device node as a GPIO controller.
-- #interrupt-cells : Should be 2.
-- interrupt-controller: Mark the device node as an interrupt controller
-  The first cell is the GPIO number.
-  The second cell is not used.
-- ti,use-leds : Enables LEDA and LEDB outputs if set
-- ti,debounce : if n-th bit is set, debounces GPIO-n
-- ti,mmc-cd : if n-th bit is set, GPIO-n controls VMMC(n+1)
-- ti,pullups : if n-th bit is set, set a pullup on GPIO-n
-- ti,pulldowns : if n-th bit is set, set a pulldown on GPIO-n
-
-Example:
-
-twl_gpio: gpio {
-    compatible = "ti,twl4030-gpio";
-    #gpio-cells = <2>;
-    gpio-controller;
-    #interrupt-cells = <2>;
-    interrupt-controller;
-    ti,use-leds;
-};
diff --git a/Documentation/devicetree/bindings/gpio/ti,twl4030-gpio.yaml b/Documentation/devicetree/bindings/gpio/ti,twl4030-gpio.yaml
new file mode 100644
index 000000000000..5e3e199fd9a4
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/ti,twl4030-gpio.yaml
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/ti,twl4030-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI TWL4030 GPIO controller
+
+maintainers:
+  - Aaro Koskinen <aaro.koskinen@iki.fi>
+  - Andreas Kemnade <andreas@kemnade.info>
+  - Kevin Hilman <khilman@baylibre.com>
+  - Roger Quadros <rogerq@kernel.org>
+  - Tony Lindgren <tony@atomide.com>
+
+properties:
+  compatible:
+    const: ti,twl4030-gpio
+
+  '#gpio-cells':
+    const: 2
+
+  gpio-controller: true
+
+  '#interrupt-cells':
+    const: 1
+
+  interrupt-controller: true
+
+  ti,debounce:
+    description: Debounce control bits. Each bit corresponds to a GPIO pin.
+    $ref: /schemas/types.yaml#/definitions/uint32
+
+  ti,mmc-cd:
+    description: MMC card detect control bits. Each bit corresponds to a GPIO pin for VMMC(n+1).
+    $ref: /schemas/types.yaml#/definitions/uint32
+
+  ti,pullups:
+    description: Pull-up control bits. Each bit corresponds to a GPIO pin.
+    $ref: /schemas/types.yaml#/definitions/uint32
+
+  ti,pulldowns:
+    description: Pull-down control bits. Each bit corresponds to a GPIO pin.
+    $ref: /schemas/types.yaml#/definitions/uint32
+
+  ti,use-leds:
+    type: boolean
+    description: Enables LEDA and LEDB outputs if set
+
+additionalProperties: false
+
+examples:
+  - |
+    gpio {
+        compatible = "ti,twl4030-gpio";
+        #gpio-cells = <2>;
+        gpio-controller;
+        #interrupt-cells = <1>;
+        interrupt-controller;
+        ti,use-leds;
+    };
-- 
2.47.2

Re: [PATCH] dt-bindings: gpio: Convert ti,twl4030-gpio to DT schema

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Mon, 14 Jul 2025 15:28:28 -0500, Rob Herring (Arm) wrote:
> Convert the TI TWL4030 PMIC GPIO binding to DT schema format. The number
> of #interrupt-cells was wrong compared to what is in use. Correct it to
> be 1.
> 
> 

Applied, thanks!

[1/1] dt-bindings: gpio: Convert ti,twl4030-gpio to DT schema
      https://git.kernel.org/brgl/linux/c/a12b566ba571aab82f969bc3b137487e61afc976

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH] dt-bindings: gpio: Convert ti,twl4030-gpio to DT schema

[Andreas Kemnade]

Am Mon, 14 Jul 2025 15:28:28 -0500
schrieb "Rob Herring (Arm)" <robh@kernel.org>:

> Convert the TI TWL4030 PMIC GPIO binding to DT schema format. The number
> of #interrupt-cells was wrong compared to what is in use. Correct it to
> be 1.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>

Thanks for taking care of it. Now it is in, but anyway:

Reviewed-by: Andreas Kemnade <andreas@kemnade.info>

Re: [PATCH] dt-bindings: gpio: Convert ti,twl4030-gpio to DT schema

[Bartosz Golaszewski]

On Fri, Jul 18, 2025 at 10:11 AM Andreas Kemnade <andreas@kemnade.info> wrote:
>
> Am Mon, 14 Jul 2025 15:28:28 -0500
> schrieb "Rob Herring (Arm)" <robh@kernel.org>:
>
> > Convert the TI TWL4030 PMIC GPIO binding to DT schema format. The number
> > of #interrupt-cells was wrong compared to what is in use. Correct it to
> > be 1.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
>
> Thanks for taking care of it. Now it is in, but anyway:
>
> Reviewed-by: Andreas Kemnade <andreas@kemnade.info>

No worries, I updated the tree with your tag.

Bart