From: Yixun Lan <dlan@gentoo.org>
To: Vivian Wang <wangruikang@iscas.ac.cn>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: dts: spacemit: uart: set dummy clock to silent dt warning
Date: Sat, 19 Jul 2025 18:23:06 +0800 [thread overview]
Message-ID: <20250719102306-GYA705838@gentoo> (raw)
In-Reply-To: <22fd8b89-b937-48db-a5bf-4e468441b206@iscas.ac.cn>
hi Vivian,
On 15:48 Sat 19 Jul , Vivian Wang wrote:
> On 7/18/25 23:13, Yixun Lan wrote:
> > sec_uart1 is reserved in DT, and no clock is implemented in the CCF
> > framework, thus 'make dtbs_check' will eject this warning message:
> > serial@f0612000: 'clock-names' is a required property
> >
> > So, adding a dummy clock to the device tree to fulfill the clock
> > requirement, then silent this dt check warning.
>
> NAK. This is definitely worse than the warning.
>
> Honestly, if you don't like this warning, I think we should just drop
> the node. If not...
>
right, I realised this wasn't a good approach..
I will try in next version to comment out the sec_uart1 node,
unless people have better suggestion..
--
Yixun Lan (dlan)
prev parent reply other threads:[~2025-07-19 10:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 15:13 [PATCH] riscv: dts: spacemit: uart: set dummy clock to silent dt warning Yixun Lan
2025-07-19 7:48 ` Vivian Wang
2025-07-19 10:23 ` Yixun Lan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250719102306-GYA705838@gentoo \
--to=dlan@gentoo.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=wangruikang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox