From: Ryan Walklin <ryan@testtoast.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>
Cc: Andre Przywara <andre.przywara@arm.com>,
Chris Morgan <macroalpha82@gmail.com>,
Hironori KIKUCHI <kikuchan98@gmail.com>,
Philippe Simons <simons.philippe@gmail.com>,
linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org,
Ryan Walklin <ryan@testtoast.com>
Subject: [PATCH v2 09/12] arm64: dts: allwinner: h616: add display engine, bus and mixer nodes
Date: Sun, 20 Jul 2025 20:48:47 +1200 [thread overview]
Message-ID: <20250720085047.5340-10-ryan@testtoast.com> (raw)
In-Reply-To: <20250720085047.5340-1-ryan@testtoast.com>
The Allwinner H616 and variants (H618, H700 and T507) have a new display
engine variant (DE33). Support has been added to the existing DE2/DE3
sun4i driver in a previous patch series [1]. The variant is selected via
the appropriate mixer device tree compatible string.
Add the respective device-tree nodes for the DE, bus, clock and mixer to
the H616 DTSI, and the matching SRAM section for the DE.
Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Ryan Walklin <ryan@testtoast.com>
[1] https://lore.kernel.org/linux-sunxi/20250528092431.28825-1-ryan@testtoast.com
--
Changelog v1..v2:
- Use A64 fallback for bus driver rather than add additional compatible in driver, enum added to dt-binding in previous patch.
- amend order of display clocks (bus/mod) to match dt binding.
- add mixer register names.
- removed IOMMU binding due to late binding warning likely reflecting sunxi IOMMU driver bug. This is not required for RGB LCD output.
- use H616 compatibles
- Update SRAM name to DE33
---
.../arm64/boot/dts/allwinner/sun50i-h616.dtsi | 58 +++++++++++++++++++
1 file changed, 58 insertions(+)
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
index ceedae9e399b..7347332f54a7 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h616.dtsi
@@ -94,6 +94,12 @@ l2_cache: l2-cache {
};
};
+ de: display-engine {
+ compatible = "allwinner,sun50i-h616-display-engine";
+ allwinner,pipelines = <&mixer0>;
+ status = "disabled";
+ };
+
reserved-memory {
#address-cells = <2>;
#size-cells = <2>;
@@ -150,6 +156,52 @@ soc {
#size-cells = <1>;
ranges = <0x0 0x0 0x0 0x40000000>;
+ bus: bus@1000000 {
+ compatible = "allwinner,sun50i-h616-de33",
+ "allwinner,sun50i-a64-de2";
+ reg = <0x1000000 0x400000>;
+ allwinner,sram = <&de33_sram 1>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0 0x1000000 0x400000>;
+
+ display_clocks: clock@8000 {
+ compatible = "allwinner,sun50i-h616-de33-clk";
+ reg = <0x8000 0x100>;
+ clocks = <&ccu CLK_BUS_DE>,
+ <&ccu CLK_DE>;
+ clock-names = "bus", "mod";
+ resets = <&ccu RST_BUS_DE>;
+ #clock-cells = <1>;
+ #reset-cells = <1>;
+ };
+
+ mixer0: mixer@100000 {
+ compatible = "allwinner,sun50i-h616-de33-mixer-0";
+ reg = <0x100000 0x100000>,
+ <0x8100 0x40>,
+ <0x280000 0x20000>;
+ reg-names = "layers", "top", "display";
+ clocks = <&display_clocks CLK_BUS_MIXER0>,
+ <&display_clocks CLK_MIXER0>;
+ clock-names = "bus", "mod";
+ resets = <&display_clocks RST_MIXER0>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ mixer0_out: port@1 {
+ reg = <1>;
+
+ mixer0_out_tcon_top: endpoint {
+ remote-endpoint = <&tcon_top_mixer0_in_mixer0>;
+ };
+ };
+ };
+ };
+ };
+
gpu: gpu@1800000 {
compatible = "allwinner,sun50i-h616-mali",
"arm,mali-bifrost";
@@ -188,6 +240,12 @@ sram_c: sram@28000 {
#address-cells = <1>;
#size-cells = <1>;
ranges = <0 0x00028000 0x30000>;
+
+ de33_sram: sram-section@0 {
+ compatible = "sun50i-h616-sram-c",
+ "allwinner,sun50i-a64-sram-c";
+ reg = <0x0000 0x1e000>;
+ };
};
};
--
2.50.1
next prev parent reply other threads:[~2025-07-20 8:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-20 8:48 [PATCH v2 00/12] arm64: dts: allwinner: h616: add LCD timing controller and display engine support Ryan Walklin
2025-07-20 8:48 ` [PATCH v2 01/12] dt-bindings: allwinner: Add TCON_TOP_LCD clock defines Ryan Walklin
2025-07-21 14:59 ` Chen-Yu Tsai
2025-07-20 8:48 ` [PATCH v2 02/12] dt-bindings: allwinner: add H616 DE33 bus binding Ryan Walklin
2025-07-21 8:29 ` Krzysztof Kozlowski
2025-07-20 8:48 ` [PATCH v2 03/12] dt-bindings: display: sun4i: Add compatible strings for H616 DE Ryan Walklin
2025-07-20 8:48 ` [PATCH v2 04/12] dt-bindings: display: sun4i: Add compatible strings for H616 TCON TOP Ryan Walklin
2025-07-21 9:03 ` Krzysztof Kozlowski
2025-07-20 8:48 ` [PATCH v2 05/12] dt-bindings: display: sun4i: add allwinner R40 and H616 tcon compatible strings Ryan Walklin
2025-07-20 8:48 ` [PATCH v2 06/12] dt-bindings: sram: sunxi-sram: Add H616 SRAM C compatible Ryan Walklin
2025-07-21 9:05 ` Krzysztof Kozlowski
2025-07-20 8:48 ` [PATCH v2 07/12] drm/sun4i: tcon: add support for R40 Ryan Walklin
2025-07-20 8:48 ` [PATCH v2 08/12] drm: sun4i: add compatible for h616 display engine Ryan Walklin
2025-07-20 8:48 ` Ryan Walklin [this message]
2025-07-20 8:48 ` [PATCH v2 10/12] arm64: dts: allwinner: h616: Add LCD timing controller nodes Ryan Walklin
2025-07-20 8:48 ` [PATCH v2 11/12] arm64: dts: allwinner: h616: add LCD and LVDS pins Ryan Walklin
2025-07-20 8:48 ` [PATCH v2 12/12] arm64: dts: allwinner: rg35xx: Enable LCD output Ryan Walklin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250720085047.5340-10-ryan@testtoast.com \
--to=ryan@testtoast.com \
--cc=andre.przywara@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=kikuchan98@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=macroalpha82@gmail.com \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=simons.philippe@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).