From: Jakub Kicinski <kuba@kernel.org>
To: Lukasz Majewski <lukma@denx.de>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
davem@davemloft.net, Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
Stefan Wahren <wahrenst@gmx.net>, Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [net-next v16 04/12] net: mtip: The L2 switch driver for imx287
Date: Sat, 26 Jul 2025 13:38:35 -0700 [thread overview]
Message-ID: <20250726133835.6e28a717@kernel.org> (raw)
In-Reply-To: <20250726221323.0754f3cd@wsk>
On Sat, 26 Jul 2025 22:13:23 +0200 Lukasz Majewski wrote:
> > > + ret = register_netdev(fep->ndev[i]);
> > > + if (ret) {
> > > + dev_err(&fep->ndev[i]->dev,
> > > + "%s: ndev %s register err: %d\n",
> > > __func__,
> > > + fep->ndev[i]->name, ret);
> > > + break;
> > > + }
> >
> > Error handling in case of register_netdev() still buggy, AFAICT.
>
> I've added the code to set fep->ndev[i] = NULL to mtip_ndev_cleanup().
> IMHO this is the correct place to add it.
If register_netdev() fails you will try to unregister it and hit
a BUG_ON().
next prev parent reply other threads:[~2025-07-26 20:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 22:33 [net-next v16 00/12] net: mtip: Add support for MTIP imx287 L2 switch driver Lukasz Majewski
2025-07-24 22:33 ` [net-next v16 01/12] dt-bindings: net: Add MTIP L2 switch description Lukasz Majewski
2025-07-24 22:33 ` [net-next v16 02/12] ARM: dts: nxp: mxs: Adjust the imx28.dtsi " Lukasz Majewski
2025-07-24 22:33 ` [net-next v16 03/12] ARM: dts: nxp: mxs: Adjust XEA board's DTS to support L2 switch Lukasz Majewski
2025-07-24 22:33 ` [net-next v16 04/12] net: mtip: The L2 switch driver for imx287 Lukasz Majewski
2025-07-25 22:18 ` Jakub Kicinski
2025-07-26 20:13 ` Lukasz Majewski
2025-07-26 20:38 ` Jakub Kicinski [this message]
2025-07-27 8:05 ` Lukasz Majewski
2025-07-24 22:33 ` [net-next v16 05/12] net: mtip: Add buffers management functions to the L2 switch driver Lukasz Majewski
2025-07-24 22:33 ` [net-next v16 06/12] net: mtip: Add net_device_ops " Lukasz Majewski
2025-07-25 15:54 ` Simon Horman
2025-07-25 17:27 ` Lukasz Majewski
2025-07-25 22:16 ` Jakub Kicinski
2025-07-26 21:09 ` Lukasz Majewski
2025-07-24 22:33 ` [net-next v16 07/12] net: mtip: Add mtip_switch_{rx|tx} " Lukasz Majewski
2025-07-24 22:33 ` [net-next v16 08/12] net: mtip: Extend the L2 switch driver with management operations Lukasz Majewski
2025-07-24 22:33 ` [net-next v16 09/12] net: mtip: Extend the L2 switch driver for imx287 with bridge operations Lukasz Majewski
2025-07-24 22:33 ` [net-next v16 10/12] ARM: mxs_defconfig: Enable CONFIG_NFS_FSCACHE Lukasz Majewski
2025-07-24 22:33 ` [net-next v16 11/12] ARM: mxs_defconfig: Update mxs_defconfig to 6.16-rc5 Lukasz Majewski
2025-07-24 22:33 ` [net-next v16 12/12] ARM: mxs_defconfig: Enable CONFIG_FEC_MTIP_L2SW to support MTIP L2 switch Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250726133835.6e28a717@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=horms@kernel.org \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukma@denx.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).