devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] dt-bindings: iio: pressure: add invensense,icp10100
@ 2025-07-28  0:32 Rodrigo Gobbi
  2025-07-28  5:19 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 2+ messages in thread
From: Rodrigo Gobbi @ 2025-07-28  0:32 UTC (permalink / raw)
  To: jic23, dlechner, nuno.sa, andy, conor+dt, krzk+dt,
	jean-baptiste.maneyrol, robh
  Cc: ~lkcamp/patches, linux-iio, linux-kernel, devicetree

There is no txt file for it, add yaml for invensense,icp10100
which is already used in the driver. Also, document other compatibles
for ICP-101xx family and add invensense,icp10100 as a fallback.

Acked-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
---
Just for the record from v2:

On 7/3/25 04:38, Krzysztof Kozlowski wrote:
> On Tue, Jul 01, 2025 at 07:05:43PM -0300, Rodrigo Gobbi wrote:
>> +$id: http://devicetree.org/schemas/iio/pressure/invensense,icp10100.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: InvenSense ICP-101xx Barometric Pressure Sensors
>> +
>> +maintainers:
>> +  - Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
>> +
>> +description: |
>> +  Support for ICP-101xx family: ICP-10100, ICP-10101, ICP-10110, ICP-10111.
> 
> The problem with title and description here is that they do not match
> compatible. oneOf:
> 
> 1. Your statement is correct, but then compatibles are incomplete and
> will encourage people to use incomplete compatibles for e.g. ICP-10111.
> 2. Compatible is correct but your statement is not correct, so then fix
> the statement - drop other devices.
> 
> Assuming 1 is closer to truth, then I suggest to express it with
> documenting these compatibles and using invensense,icp10100 as fallback.
> 
> 
> Best regards,
> Krzysztof
> 
...reviewed the datasheet again and I think we should go with 1. I`ve changed that,
documented the rest of the family and added a fallback for it.
Tks and regards.

Changelog:
v3: add other compatible names and add a fallback for it
v2: https://lore.kernel.org/linux-devicetree/20250701221700.34921-1-rodrigo.gobbi.7@gmail.com/
v1: https://lore.kernel.org/all/20250626212742.7986-1-rodrigo.gobbi.7@gmail.com/
---
 .../iio/pressure/invensense,icp10100.yaml     | 50 +++++++++++++++++++
 1 file changed, 50 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/pressure/invensense,icp10100.yaml

diff --git a/Documentation/devicetree/bindings/iio/pressure/invensense,icp10100.yaml b/Documentation/devicetree/bindings/iio/pressure/invensense,icp10100.yaml
new file mode 100644
index 000000000000..df875d6d03dc
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/pressure/invensense,icp10100.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/pressure/invensense,icp10100.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: InvenSense ICP-101xx Barometric Pressure Sensors
+
+maintainers:
+  - Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
+
+description: |
+  Support for ICP-101xx family: ICP-10100, ICP-10101, ICP-10110, ICP-10111.
+  Those devices uses a simple I2C communication bus, measuring the pressure
+  in a ultra-low noise at the lowest power.
+  Datasheet: https://product.tdk.com/system/files/dam/doc/product/sensor/pressure/capacitive-pressure/data_sheet/ds-000186-icp-101xx.pdf
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - invensense,icp10101
+          - invensense,icp10110
+          - invensense,icp10111
+      - const: invensense,icp10100
+
+  reg:
+    maxItems: 1
+
+  vdd-supply: true
+
+required:
+  - compatible
+  - reg
+  - vdd-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        pressure@63 {
+            compatible = "invensense,icp10101", "invensense,icp10100";
+            reg = <0x63>;
+            vdd-supply = <&vdd_1v8>;
+        };
+    };
+...
-- 
2.48.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] dt-bindings: iio: pressure: add invensense,icp10100
  2025-07-28  0:32 [PATCH v3] dt-bindings: iio: pressure: add invensense,icp10100 Rodrigo Gobbi
@ 2025-07-28  5:19 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2025-07-28  5:19 UTC (permalink / raw)
  To: Rodrigo Gobbi
  Cc: jic23, dlechner, nuno.sa, andy, conor+dt, krzk+dt,
	jean-baptiste.maneyrol, robh, ~lkcamp/patches, linux-iio,
	linux-kernel, devicetree

On Sun, Jul 27, 2025 at 09:32:02PM -0300, Rodrigo Gobbi wrote:
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - invensense,icp10101
> +          - invensense,icp10110
> +          - invensense,icp10111
> +      - const: invensense,icp10100

This does not allow using invensense,icp10100 alone. Try it yourself on
DTS - you will see warnings.

You need oneOf, just takek a peak at some random bindings.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-07-28  5:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-28  0:32 [PATCH v3] dt-bindings: iio: pressure: add invensense,icp10100 Rodrigo Gobbi
2025-07-28  5:19 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).