Re: [PATCH 1/2] dt-bindings: hwmon: ti,ina780a: Add INA780 device

[Krzysztof Kozlowski <krzk@kernel.org>]

On Thu, Aug 07, 2025 at 08:46:46PM +0000, Chris Packham wrote:
> 
> On 06/08/2025 18:32, Krzysztof Kozlowski wrote:
> > On 06/08/2025 02:51, Chris Packham wrote:
> >> +
> >> +properties:
> >> +  compatible:
> >> +    enum:
> >> +      - ti,ina780a
> >> +      - ti,ina780b
> >> +
> >> +  reg:
> >> +    maxItems: 1
> >
> > This looks a bit incomplete. Where is a supply? No shunt resistor
> > choice? No other properties from ina2xx apply?
> This chip doesn't need a shunt so pretty much all that is required is 
> compatible + reg. Guenter did mention rolling this into the existing 
> ina238 driver (and ina2xx binding) so I'm looking at that right now. I'm 
> also thinking about dropping the A vs B distinction. They are ordering 
> options that do impact the accuracy of the ADC but driver wise they 
> behave the same.

Then I suggest to skip a/b. Usually we do not have compatibles for
packaging differences or even consumer/industrial thermal choices.

Best regards,
Krzysztof