public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andreas Klinger <ak@it-klinger.de>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	lars@metafoo.de, javier.carrasco.cruz@gmail.com,
	mazziesaccount@gmail.com, andriy.shevchenko@linux.intel.com,
	arthur.becker@sentec.com, perdaniel.olsson@axis.com,
	mgonellabolduc@dimonoff.com, muditsharma.info@gmail.com,
	clamor95@gmail.com, emil.gedenryd@axis.com,
	devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 0/3] iio:light: add driver for veml6046x00 RGBIR color sensor
Date: Sun, 10 Aug 2025 19:30:17 +0100	[thread overview]
Message-ID: <20250810193017.571cdf40@jic23-huawei> (raw)
In-Reply-To: <20250728075447.338725-1-ak@it-klinger.de>

On Mon, 28 Jul 2025 09:54:43 +0200
Andreas Klinger <ak@it-klinger.de> wrote:

> This patchset adds an IIO driver for Vishay veml6046x00 RGBIR color sensor.
Tweaks as per comments on patch 2 and applied to the testing branch of iio.git.

I'll rebase on rc1 in the next few days and then push this out as a tree linux-next
picks up.

Thanks,

Jonathan

> 
> Changes in v7:
> - Thanks to the reviews of Jonathan and Andy improvements in the PM could be
>   implemented like removal of pm_runtime_mark_last_busy() and consistency in PM
>   handling in some functions.
> 
> Changes in v6:
> - Thanks to the in-depth review of Andy many datatype improvements were
>   realized.
> - According to Jonathans review change the channel types from IIO_LIGHT to
>   IIO_INTENSITY.
> 
> Changes in v5:
> - Thanks to the feedback of Andy and further explanations of Jonathan many
>   improvements could be implemented.
> - add documentation in kernel-doc format
> - iio_push_to_buffers_with_ts() is not used as also testing against
>   linux-stable where it is not available so far.
> 
> Changes in v4:
> - implement feedback from Andy and Jonathan
> - implement feedback from vendor (reading interrupt register as bulk read)
> 
> Changes in v3:
> - implement a lot of feedback from Jonathan
> - change scale value to real factor of lux per raw count instead of hardware
>   gain  
> - optimize code by using more lookup tables
> - remove unimplemented threshold functionality
> 
> Changes in v2:
> - fix missing include for example in vishay,veml6046x00.yaml
> 
> Andreas Klinger (3):
>   dt-bindings: iio: light: veml6046x00: add color sensor
>   iio: light: add support for veml6046x00 RGBIR color sensor
>   MAINTAINER: add maintainer for veml6046x00
> 
>  .../iio/light/vishay,veml6046x00.yaml         |   51 +
>  MAINTAINERS                                   |    6 +
>  drivers/iio/light/Kconfig                     |   13 +
>  drivers/iio/light/Makefile                    |    1 +
>  drivers/iio/light/veml6046x00.c               | 1031 +++++++++++++++++
>  5 files changed, 1102 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/light/vishay,veml6046x00.yaml
>  create mode 100644 drivers/iio/light/veml6046x00.c
> 


      parent reply	other threads:[~2025-08-10 18:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-28  7:54 [PATCH v7 0/3] iio:light: add driver for veml6046x00 RGBIR color sensor Andreas Klinger
2025-07-28  7:54 ` [PATCH v7 1/3] dt-bindings: iio: light: veml6046x00: add " Andreas Klinger
2025-07-28  7:54 ` [PATCH v7 2/3] iio: light: add support for veml6046x00 RGBIR " Andreas Klinger
2025-07-28 18:20   ` Jonathan Cameron
2025-07-28  7:54 ` [PATCH v7 3/3] MAINTAINER: add maintainer for veml6046x00 Andreas Klinger
2025-08-10 18:30 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250810193017.571cdf40@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=ak@it-klinger.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arthur.becker@sentec.com \
    --cc=clamor95@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=emil.gedenryd@axis.com \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=mgonellabolduc@dimonoff.com \
    --cc=muditsharma.info@gmail.com \
    --cc=perdaniel.olsson@axis.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox