From: Krzysztof Kozlowski <krzk@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: "Matti Vaittinen" <matti.vaittinen@fi.rohmeurope.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 08/11] dt-bindings: iio: adc: ad7476: Drop redundant prop: true
Date: Thu, 14 Aug 2025 09:25:58 +0200 [thread overview]
Message-ID: <20250814-authentic-silky-lyrebird-05cbdd@kuoka> (raw)
In-Reply-To: <bee66444bf628ba9a34a02738a1842e2abc14290.1754901948.git.mazziesaccount@gmail.com>
On Mon, Aug 11, 2025 at 11:51:50AM +0300, Matti Vaittinen wrote:
> The ad7476 supports a few variants with different power-supplies and
> control GPIOs. The binding first unconditionally introduces all the
> properties, and later sets them 'true' or 'false' based on the
> combatible.
>
> The 'true' seems to be implied by the initial property introduction so
> the 'true' -branches in later conditional handling (based on the
> compatible) can be omitted.
>
> Drop the redundant true -branches.
>
> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-14 7:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 8:50 [PATCH v4 00/11] Support ROHM BD79105 ADC Matti Vaittinen
2025-08-11 8:50 ` [PATCH v4 01/11] iio: adc: ad7476: Simplify chip type detection Matti Vaittinen
2025-08-11 8:50 ` [PATCH v4 02/11] iio: adc: ad7476: Simplify scale handling Matti Vaittinen
2025-08-11 8:50 ` [PATCH v4 03/11] iio: adc: ad7476: Use mV for internal reference Matti Vaittinen
2025-08-11 8:51 ` [PATCH v4 04/11] iio: adc: ad7476: Use correct channel for bit info Matti Vaittinen
2025-08-11 8:51 ` [PATCH v4 05/11] iio: adc: ad7476: use *_cansleep GPIO APIs Matti Vaittinen
2025-08-11 8:51 ` [PATCH v4 06/11] iio: adc: ad7476: Drop convstart chan_spec Matti Vaittinen
2025-08-11 8:51 ` [PATCH v4 07/11] iio: adc: ad7476: Conditionally call convstart Matti Vaittinen
2025-08-11 8:51 ` [PATCH v4 08/11] dt-bindings: iio: adc: ad7476: Drop redundant prop: true Matti Vaittinen
2025-08-14 7:25 ` Krzysztof Kozlowski [this message]
2025-08-11 8:52 ` [PATCH v4 09/11] dt-bindings: iio: adc: ad7476: Add ROHM bd79105 Matti Vaittinen
2025-08-14 7:29 ` Krzysztof Kozlowski
2025-08-11 8:52 ` [PATCH v4 10/11] iio: adc: ad7476: Support ROHM BD79105 Matti Vaittinen
2025-08-11 8:52 ` [PATCH v4 11/11] MAINTAINERS: A driver for simple 1-channel SPI ADCs Matti Vaittinen
2025-08-16 12:22 ` [PATCH v4 00/11] Support ROHM BD79105 ADC Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250814-authentic-silky-lyrebird-05cbdd@kuoka \
--to=krzk@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox