From: Stephan Gerhold <stephan.gerhold@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Aleksandrs Vinarskis <alex.vinarskis@gmail.com>,
Abel Vesa <abel.vesa@linaro.org>,
Xilin Wu <wuxilin123@gmail.com>,
Jens Glathe <jens.glathe@oldschoolsolutions.biz>,
Srinivas Kandagatla <srini@kernel.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
Rajendra Nayak <quic_rjendra@quicinc.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>,
Christopher Obbard <christopher.obbard@linaro.org>
Subject: [PATCH 8/9] arm64: dts: qcom: x1e80100-microsoft-romulus: Add missing pinctrl for eDP HPD
Date: Thu, 14 Aug 2025 15:30:35 +0200 [thread overview]
Message-ID: <20250814-x1e80100-add-edp-hpd-v1-8-a52804db53f6@linaro.org> (raw)
In-Reply-To: <20250814-x1e80100-add-edp-hpd-v1-0-a52804db53f6@linaro.org>
At the moment, we indirectly rely on the boot firmware to set up the
pinctrl for the eDP HPD line coming from the internal display. If the boot
firmware does not configure the display (e.g. because a different display
is selected for output in the UEFI settings), then the display fails to
come up and there are several errors in the kernel log:
[drm:dpu_encoder_phys_vid_wait_for_commit_done:544] [dpu error]vblank timeout: 80020041
[drm:dpu_kms_wait_for_commit_done:524] [dpu error]wait for commit done returned -110
[drm:dpu_encoder_frame_done_timeout:2715] [dpu error]enc40 frame done timeout
...
Fix this by adding the missing pinctrl for gpio119 (func1/edp0_hot and
bias-disable according to the ACPI DSDT).
Fixes: 09d77be56093 ("arm64: dts: qcom: Add support for X1-based Surface Laptop 7 devices")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
index 27dd5e4e9939124360544ee9c59900ebb01f3f49..688db57a472844fccb143c45ecf66155477286bf 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi
@@ -965,6 +965,9 @@ &mdss_dp1_out {
&mdss_dp3 {
/delete-property/ #sound-dai-cells;
+ pinctrl-0 = <&edp_hpd_default>;
+ pinctrl-names = "default";
+
status = "okay";
aux-bus {
@@ -1207,6 +1210,12 @@ &tlmm {
gpio-reserved-ranges = <44 4>, /* SPI (TPM) */
<238 1>; /* UFS Reset */
+ edp_hpd_default: edp-hpd-default-state {
+ pins = "gpio119";
+ function = "edp0_hot";
+ bias-disable;
+ };
+
hall_int_n_default: hall-int-n-state {
pins = "gpio2";
function = "gpio";
--
2.50.1
next prev parent reply other threads:[~2025-08-14 13:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 13:30 [PATCH 0/9] arm64: dts: qcom: x1: Add missing pinctrl for eDP HPD Stephan Gerhold
2025-08-14 13:30 ` [PATCH 1/9] arm64: dts: qcom: x1-asus-zenbook-a14: " Stephan Gerhold
2025-08-15 9:26 ` Aleksandrs Vinarskis
2025-08-15 22:06 ` Dmitry Baryshkov
2025-08-18 7:44 ` Stephan Gerhold
2025-08-18 10:33 ` Dmitry Baryshkov
2025-08-18 10:37 ` Stephan Gerhold
2025-08-18 10:39 ` Dmitry Baryshkov
2025-08-18 10:43 ` Stephan Gerhold
2025-08-14 13:30 ` [PATCH 2/9] arm64: dts: qcom: x1-crd: " Stephan Gerhold
2025-08-14 13:30 ` [PATCH 3/9] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: " Stephan Gerhold
2025-08-14 20:08 ` Christopher Obbard
2025-08-14 13:30 ` [PATCH 4/9] arm64: dts: qcom: x1e80100-asus-vivobook-s15: " Stephan Gerhold
2025-08-15 6:24 ` Maud Spierings
2025-08-14 13:30 ` [PATCH 5/9] arm64: dts: qcom: x1e80100-dell-xps13-9345: " Stephan Gerhold
2025-08-15 9:24 ` Aleksandrs Vinarskis
2025-08-14 13:30 ` [PATCH 6/9] arm64: dts: qcom: x1e80100-hp-omnibook-x14: " Stephan Gerhold
2025-08-14 13:30 ` [PATCH 7/9] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: " Stephan Gerhold
2025-08-14 13:30 ` Stephan Gerhold [this message]
2025-08-14 13:30 ` [PATCH 9/9] arm64: dts: qcom: x1e80100-qcp: " Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250814-x1e80100-add-edp-hpd-v1-8-a52804db53f6@linaro.org \
--to=stephan.gerhold@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=alex.vinarskis@gmail.com \
--cc=andersson@kernel.org \
--cc=christopher.obbard@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jens.glathe@oldschoolsolutions.biz \
--cc=johan@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=srini@kernel.org \
--cc=wuxilin123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).