From: Markus Heidelberg <m.heidelberg@cab.de>
To: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<devicetree@vger.kernel.org>
Cc: Markus Heidelberg <m.heidelberg@cab.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Christian Eggers <ceggers@arri.de>,
Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Jiri Prchal <jiri.prchal@aksignal.cz>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH 3/3] eeprom: at25: make FRAM device ID error message more precise
Date: Thu, 14 Aug 2025 13:15:32 +0200 [thread overview]
Message-ID: <20250814111546.617131-4-m.heidelberg@cab.de> (raw)
In-Reply-To: <20250814111546.617131-1-m.heidelberg@cab.de>
The error description would be wrong in case the "size" Devicetree
property is missing for an FRAM without device ID.
Signed-off-by: Markus Heidelberg <m.heidelberg@cab.de>
---
drivers/misc/eeprom/at25.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/eeprom/at25.c b/drivers/misc/eeprom/at25.c
index c90150f72836..e2868f7bdb03 100644
--- a/drivers/misc/eeprom/at25.c
+++ b/drivers/misc/eeprom/at25.c
@@ -399,7 +399,7 @@ static int at25_fram_to_chip(struct device *dev, struct spi_eeprom *chip)
id[j] = tmp;
}
if (id[6] != 0xc2) {
- dev_err(dev, "Error: no Cypress FRAM (id %02x)\n", id[6]);
+ dev_err(dev, "Error: no Cypress FRAM with device ID (manufacturer ID bank 7: %02x)\n", id[6]);
return -ENODEV;
}
--
2.43.0
next prev parent reply other threads:[~2025-08-14 11:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 11:15 [PATCH 0/3] eeprom: at25: support Cypress FRAMs without device ID Markus Heidelberg
2025-08-14 11:15 ` [PATCH 1/3] dt-bindings: eeprom: at25: use "size" for " Markus Heidelberg
2025-08-14 20:47 ` Conor Dooley
2025-08-14 11:15 ` [PATCH 2/3] eeprom: at25: support Cypress " Markus Heidelberg
2025-08-14 12:24 ` Alexander Sverdlin
2025-08-14 11:15 ` Markus Heidelberg [this message]
2025-08-14 12:25 ` [PATCH 3/3] eeprom: at25: make FRAM device ID error message more precise Alexander Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250814111546.617131-4-m.heidelberg@cab.de \
--to=m.heidelberg@cab.de \
--cc=alexander.sverdlin@gmail.com \
--cc=arnd@arndb.de \
--cc=ceggers@arri.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jiri.prchal@aksignal.cz \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox