Re: [PATCH v7 05/13] PCI: cadence: Split PCIe RP support into common and specific functions

[Bjorn Helgaas <helgaas@kernel.org>]

On Wed, Aug 13, 2025 at 12:23:23PM +0800, hans.zhang@cixtech.com wrote:
> From: Manikandan K Pillai <mpillai@cadence.com>
> 
> Split the Cadence PCIe controller RP functionality into common
> functions and functions for legacy PCIe RP controller.

I guess this is simply a move, with no actual code changes?

> +++ b/drivers/pci/controller/cadence/pcie-cadence-ep-common.h
> @@ -1,10 +1,10 @@
>  /* SPDX-License-Identifier: GPL-2.0 */
>  // Copyright (c) 2017 Cadence
> -// Cadence PCIe Endpoint controller driver.
> +// Cadence PCIe Endpoint controller driver
>  // Author: Manikandan K Pillai <mpillai@cadence.com>
>  
> -#ifndef _PCIE_CADENCE_EP_COMMON_H_
> -#define _PCIE_CADENCE_EP_COMMON_H_
> +#ifndef _PCIE_CADENCE_EP_COMMON_H
> +#define _PCIE_CADENCE_EP_COMMON_H
>  
>  #include <linux/kernel.h>
>  #include <linux/pci.h>
> @@ -33,4 +33,4 @@ const struct pci_epc_features *cdns_pcie_ep_get_features(struct pci_epc *epc,
>  							 u8 func_no,
>  							 u8 vfunc_no);
>  
> -#endif /* _PCIE_CADENCE_EP_COMMON_H_ */
> +#endif /* _PCIE_CADENCE_EP_COMMON_H */

All these changes should be in the patch that creates
pcie-cadence-ep-common.h so we don't have to touch it twice.

> diff --git a/drivers/pci/controller/cadence/pcie-cadence-host-common.c b/drivers/pci/controller/cadence/pcie-cadence-host-common.c
> new file mode 100644
> index 000000000000..5625c64c7974
> --- /dev/null
> +++ b/drivers/pci/controller/cadence/pcie-cadence-host-common.c
> @@ -0,0 +1,181 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2017 Cadence
> +// Cadence PCIe host controller driver.
> +// Author: Manikandan K Pillai <mpillai@cadence.com>

Not sure about the author here.  The authorship info is usually all
there in the git history, so there's less value in including it in the
file itself than there used to be.