Re: [PATCH 1/2] dt-bindings: mips: lantiq: Document Lantiq Xway GPTU

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1740 bytes --]

On Sat, Aug 16, 2025 at 02:04:09PM +0200, Aleksander Jan Bajkowski wrote:
> 
> On 8/14/25 22:50, Conor Dooley wrote:
> > On Thu, Aug 14, 2025 at 11:36:59AM +0200, Aleksander Jan Bajkowski wrote:
> > > The Lantiq SoC has six built-in 16-bit general purpose timers (GPTU).
> > > 
> > > Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> > > ---
> > >   .../mips/lantiq/lantiq,gptu-xway.yaml         | 39 +++++++++++++++++++
> > >   1 file changed, 39 insertions(+)
> > >   create mode 100644 Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml
> > > 
> > > diff --git a/Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml b/Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml
> > > new file mode 100644
> > > index 000000000000..fcfc634dd391
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mips/lantiq/lantiq,gptu-xway.yaml
> > > @@ -0,0 +1,39 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/mips/lantiq/lantiq,gptu-xway.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Lantiq Xway SoC series General Purpose Timer Unit (GPTU)
> > "SoC series" implies that you're using the same compatible for multiple
> > devices. Why are you not using device-specific compatibles?
> 
> This IP Core didn't change in subsequent generations of SoCs, so it had
> one compatible string. In the next iteration, I will add device-specific
> compatibles.

You can (and should) use a fallback when you do that, probably to
whatever the first device to contain the IP is. The driver need only
contain the one fallback compatible.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]