devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC PATCH 0/3] Add DSI and Raspberry Pi panel support
@ 2025-08-18 15:47 Harikrishna Shenoy
  2025-08-18 15:47 ` [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible Harikrishna Shenoy
                   ` (2 more replies)
  0 siblings, 3 replies; 17+ messages in thread
From: Harikrishna Shenoy @ 2025-08-18 15:47 UTC (permalink / raw)
  To: neil.armstrong, jessica.zhang, airlied, simona, maarten.lankhorst,
	mripard, tzimmermann, robh, krzk+dt, conor+dt, nm, vigneshr,
	kristo, thierry.reding, sam, dri-devel, devicetree,
	linux-arm-kernel
  Cc: s-jain1, devarsht, u-kumar1

This series adds support for enabling DSI output and attaching a Raspberry
Pi 7-inch panel on the BeagleBone AI-64 (J721e).
The patches include:
1. Bindings- Extend panel-simple bindings to allow the
Raspberry Pi panel to bedescribed.
2. SoC integration- Add DSI and DPHY TX nodes for J721e main domain.
3. Board integration -Hook up the Raspberry Pi 7-inch panel to the 
BeagleBone AI-64 using the DSI interface.

Harikrishna Shenoy (2):
  devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry
    pi dsi panel compatible
  arm64: dts: ti: k3-j721e-beagleboneai64: Add DSI RPi Panel

Rahul T R (1):
  arm64: dts: ti: k3-j721e-main: Add DSI and DPHY-TX

 .../bindings/display/panel/panel-simple.yaml  |   2 +
 arch/arm64/boot/dts/ti/Makefile               |   4 +
 ...1e-beagleboneai64-dsi-rpi-7inch-panel.dtso | 141 ++++++++++++++++++
 .../boot/dts/ti/k3-j721e-beagleboneai64.dts   |   7 +-
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi     |  31 ++++
 5 files changed, 184 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64-dsi-rpi-7inch-panel.dtso

-- 
2.34.1


^ permalink raw reply	[flat|nested] 17+ messages in thread

* [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible
  2025-08-18 15:47 [RFC PATCH 0/3] Add DSI and Raspberry Pi panel support Harikrishna Shenoy
@ 2025-08-18 15:47 ` Harikrishna Shenoy
  2025-08-19  1:24   ` Dmitry Baryshkov
                     ` (2 more replies)
  2025-08-18 15:47 ` [RFC PATCH 2/3] arm64: dts: ti: k3-j721e-main: Add DSI and DPHY-TX Harikrishna Shenoy
  2025-08-18 15:47 ` [RFC PATCH 3/3] arm64: dts: ti: k3-j721e-beagleboneai64: Add DSI RPi Panel Harikrishna Shenoy
  2 siblings, 3 replies; 17+ messages in thread
From: Harikrishna Shenoy @ 2025-08-18 15:47 UTC (permalink / raw)
  To: neil.armstrong, jessica.zhang, airlied, simona, maarten.lankhorst,
	mripard, tzimmermann, robh, krzk+dt, conor+dt, nm, vigneshr,
	kristo, thierry.reding, sam, dri-devel, devicetree,
	linux-arm-kernel
  Cc: s-jain1, devarsht, u-kumar1

Add RPi DSI panel[0] as a valid compatible for simple-panel.

[0]: https://www.raspberrypi.com/products/raspberry-pi-touch-display/

Signed-off-by: Harikrishna Shenoy <h-shenoy@ti.com>
---
 .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index 1ac1f0219079..65f486f2bc9d 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -268,6 +268,8 @@ properties:
       - rocktech,rk070er9427
         # Rocktech Display Ltd. RK043FN48H 4.3" 480x272 LCD-TFT panel
       - rocktech,rk043fn48h
+        # Raspberry, 7" dsi panel
+      - rpi,7inch-dsi
         # Samsung Electronics 10.1" WXGA (1280x800) TFT LCD panel
       - samsung,ltl101al01
         # Samsung Electronics 10.1" WSVGA TFT LCD panel
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [RFC PATCH 2/3] arm64: dts: ti: k3-j721e-main: Add DSI and DPHY-TX
  2025-08-18 15:47 [RFC PATCH 0/3] Add DSI and Raspberry Pi panel support Harikrishna Shenoy
  2025-08-18 15:47 ` [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible Harikrishna Shenoy
@ 2025-08-18 15:47 ` Harikrishna Shenoy
  2025-08-19  5:02   ` Kumar, Udit
  2025-08-18 15:47 ` [RFC PATCH 3/3] arm64: dts: ti: k3-j721e-beagleboneai64: Add DSI RPi Panel Harikrishna Shenoy
  2 siblings, 1 reply; 17+ messages in thread
From: Harikrishna Shenoy @ 2025-08-18 15:47 UTC (permalink / raw)
  To: neil.armstrong, jessica.zhang, airlied, simona, maarten.lankhorst,
	mripard, tzimmermann, robh, krzk+dt, conor+dt, nm, vigneshr,
	kristo, thierry.reding, sam, dri-devel, devicetree,
	linux-arm-kernel
  Cc: s-jain1, devarsht, u-kumar1

From: Rahul T R <r-ravikumar@ti.com>

TI's J721E SoC supports a DPI to DSI video signal conversion bridge on
it's platform bus. The IP is from Cadence, and it has a custom TI
wrapper around it to facilitate integration.

This IP takes the DPI video signals from DSS and alongwith the DPHY IP,
it transmits DSI video signals out of the SoC.

Add support for DSI bridge and the DPHY-TX.

Signed-off-by: Rahul T R <r-ravikumar@ti.com>
Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
Signed-off-by: Harikrishna Shenoy <h-shenoy@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 31 +++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index 5bd0d36bf33e..ce34d68a70f2 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -1881,6 +1881,37 @@ port@4 {
 		};
 	};
 
+	dphy2: phy@4480000 {
+		compatible = "ti,j721e-dphy";
+		reg = <0x0 0x04480000 0x0 0x1000>;
+		clocks = <&k3_clks 296 1>, <&k3_clks 296 3>;
+		clock-names = "psm", "pll_ref";
+		#phy-cells = <0>;
+		power-domains = <&k3_pds 296 TI_SCI_PD_EXCLUSIVE>;
+		assigned-clocks = <&k3_clks 296 3>;
+		assigned-clock-parents = <&k3_clks 296 4>;
+		assigned-clock-rates = <19200000>;
+		status = "disabled";
+	};
+
+	dsi0: dsi@4800000 {
+		compatible = "ti,j721e-dsi";
+		reg = <0x0 0x04800000 0x0 0x100000>, <0x0 0x04710000 0x0 0x100>;
+		clocks = <&k3_clks 150 1>, <&k3_clks 150 5>;
+		clock-names = "dsi_p_clk", "dsi_sys_clk";
+		power-domains = <&k3_pds 150 TI_SCI_PD_EXCLUSIVE>;
+		interrupt-parent = <&gic500>;
+		interrupts = <GIC_SPI 600 IRQ_TYPE_LEVEL_HIGH>;
+		phys = <&dphy2>;
+		phy-names = "dphy";
+		status = "disabled";
+
+		dsi0_ports: ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+		};
+	};
+
 	dss: dss@4a00000 {
 		compatible = "ti,j721e-dss";
 		reg =
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [RFC PATCH 3/3] arm64: dts: ti: k3-j721e-beagleboneai64: Add DSI RPi Panel
  2025-08-18 15:47 [RFC PATCH 0/3] Add DSI and Raspberry Pi panel support Harikrishna Shenoy
  2025-08-18 15:47 ` [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible Harikrishna Shenoy
  2025-08-18 15:47 ` [RFC PATCH 2/3] arm64: dts: ti: k3-j721e-main: Add DSI and DPHY-TX Harikrishna Shenoy
@ 2025-08-18 15:47 ` Harikrishna Shenoy
  2025-08-19  5:13   ` Kumar, Udit
  2 siblings, 1 reply; 17+ messages in thread
From: Harikrishna Shenoy @ 2025-08-18 15:47 UTC (permalink / raw)
  To: neil.armstrong, jessica.zhang, airlied, simona, maarten.lankhorst,
	mripard, tzimmermann, robh, krzk+dt, conor+dt, nm, vigneshr,
	kristo, thierry.reding, sam, dri-devel, devicetree,
	linux-arm-kernel
  Cc: s-jain1, devarsht, u-kumar1

Add support for R-Pi DSI Panel for BBAI64.

The RPi DSI panel[0] uses Toshiba TC358762 for decoding the DSI video
signals back to DPI for its consumption. It has an ATTINY88-based
regulator and backlight controller, and also features an EDT-FT5406
touch controller.

Fix DSS ports node in BeagkeBone AI-64 DTS by adding explicit `port@0`
child node instead of an unlabelled port, to align with dss_ports schema
used in overlay.

[0]: https://www.raspberrypi.com/products/raspberry-pi-touch-display/

Signed-off-by: Rahul T R <r-ravikumar@ti.com>
Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
Signed-off-by: Harikrishna Shenoy <h-shenoy@ti.com>
---
 arch/arm64/boot/dts/ti/Makefile               |   4 +
 ...1e-beagleboneai64-dsi-rpi-7inch-panel.dtso | 141 ++++++++++++++++++
 .../boot/dts/ti/k3-j721e-beagleboneai64.dts   |   7 +-
 3 files changed, 151 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64-dsi-rpi-7inch-panel.dtso

diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
index aad9177930e6..25cf12ebccce 100644
--- a/arch/arm64/boot/dts/ti/Makefile
+++ b/arch/arm64/boot/dts/ti/Makefile
@@ -114,6 +114,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-j7200-evm-pcie1-ep.dtbo
 # Boards with J721e SoC
 k3-j721e-evm-dtbs := k3-j721e-common-proc-board.dtb k3-j721e-evm-quad-port-eth-exp.dtbo
 dtb-$(CONFIG_ARCH_K3) += k3-j721e-beagleboneai64.dtb
+dtb-$(CONFIG_ARCH_K3) += k3-j721e-beagleboneai64-dsi-rpi-7inch-panel.dtbo
 dtb-$(CONFIG_ARCH_K3) += k3-j721e-common-proc-board-infotainment.dtbo
 dtb-$(CONFIG_ARCH_K3) += k3-j721e-evm.dtb
 dtb-$(CONFIG_ARCH_K3) += k3-j721e-evm-gesi-exp-board.dtbo
@@ -220,6 +221,8 @@ k3-am69-sk-pcie0-ep-dtbs := k3-am69-sk.dtb \
 	k3-am69-sk-pcie0-ep.dtbo
 k3-j7200-evm-pcie1-ep-dtbs := k3-j7200-common-proc-board.dtb \
 	k3-j7200-evm-pcie1-ep.dtbo
+k3-j721e-beagleboneai64-dsi-rpi-7inch-panel-dtbs := k3-j721e-beagleboneai64.dtb \
+	k3-j721e-beagleboneai64-dsi-rpi-7inch-panel.dtbo
 k3-j721e-common-proc-board-infotainment-dtbs := k3-j721e-common-proc-board.dtb \
 	k3-j721e-common-proc-board-infotainment.dtbo
 k3-j721e-evm-pcie0-ep-dtbs := k3-j721e-common-proc-board.dtb \
@@ -267,6 +270,7 @@ dtb- += k3-am625-beagleplay-csi2-ov5640.dtb \
 	k3-am69-sk-csi2-dual-imx219.dtb \
 	k3-am69-sk-pcie0-ep.dtb \
 	k3-j7200-evm-pcie1-ep.dtb \
+	k3-j721e-beagleboneai64-dsi-rpi-7inch-panel.dtb \
 	k3-j721e-common-proc-board-infotainment.dtb \
 	k3-j721e-evm-pcie0-ep.dtb \
 	k3-j721e-evm-pcie1-ep.dtb \
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64-dsi-rpi-7inch-panel.dtso b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64-dsi-rpi-7inch-panel.dtso
new file mode 100644
index 000000000000..c3506ccf60a4
--- /dev/null
+++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64-dsi-rpi-7inch-panel.dtso
@@ -0,0 +1,141 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/**
+ * DT Overlay for RPi 7inch touchscreen panel interfaced with DSI on
+ * J721E based BeagleBone AI-64 (BBAI-64) platform.
+ *
+ * BBAI-64: https://www.beagleboard.org/boards/beaglebone-ai-64
+ * RPi DSI Panel: https://www.raspberrypi.com/products/raspberry-pi-touch-display/
+ *
+ * Copyright (C) 2024 Texas Instruments Incorporated - https://www.ti.com/
+ */
+
+/dts-v1/;
+/plugin/;
+
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/interrupt-controller/irq.h>
+
+#include "k3-pinctrl.h"
+
+&{/} {
+	bridge_reg: bridge-regulator {
+		compatible = "regulator-fixed";
+		regulator-name = "bridge-reg";
+		vin-supply = <&display_reg>;
+		enable-active-high;
+	};
+
+	panel0 {
+		compatible = "rpi,7inch-dsi";
+		power-supply = <&display_reg>;
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&panel_bridge_out>;
+			};
+		};
+	};
+};
+
+&main_pmx0 {
+	dsi_main_i2c4_pins: dsi-main-i2c4-pins {
+		pinctrl-single,pins = <
+			J721E_IOPAD(0xa8, PIN_INPUT_PULLUP, 2) /* (AD19) PRG1_MDIO0_MDIO.I2C4_SCL */
+			J721E_IOPAD(0xac, PIN_INPUT_PULLUP, 2) /* (AD18) PRG1_MDIO0_MDC.I2C4_SDA */
+		>;
+	};
+};
+
+&main_i2c4 {
+	clock-frequency = <400000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&dsi_main_i2c4_pins>;
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	display_reg: regulator@45 {
+		compatible = "raspberrypi,7inch-touchscreen-panel-regulator";
+		reg = <0x45>;
+	};
+
+	touch-controller@38 {
+		compatible = "edt,edt-ft5406";
+		reg = <0x38>;
+
+		touchscreen-size-x = < 800 >;
+		touchscreen-size-y = < 480 >;
+
+		vcc-supply = <&display_reg>;
+		interrupts-extended = <&main_gpio0 0 IRQ_TYPE_NONE>;
+
+		touchscreen-inverted-x;
+		touchscreen-inverted-y;
+	};
+};
+
+&dss_ports {
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	port@2 {
+		reg = <2>;
+
+		dpi2_out: endpoint {
+			remote-endpoint = <&dsi0_in>;
+		};
+	};
+};
+
+&dphy2 {
+	status = "okay";
+};
+
+&dsi0 {
+	status = "okay";
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		port@0 {
+			reg = <0>;
+			dsi0_out: endpoint {
+				remote-endpoint = <&panel_bridge_in>;
+			};
+		};
+
+		port@1 {
+			reg = <1>;
+			dsi0_in: endpoint {
+				remote-endpoint = <&dpi2_out>;
+			};
+		};
+	};
+
+	bridge@0 {
+		compatible = "toshiba,tc358762";
+		reg = <0>;
+		vddc-supply = <&bridge_reg>;
+		ports {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			port@0 {
+				reg = <0>;
+				panel_bridge_in: endpoint {
+					remote-endpoint = <&dsi0_out>;
+				};
+			};
+
+			port@1 {
+				reg = <1>;
+				panel_bridge_out: endpoint {
+					remote-endpoint = <&panel_in>;
+				};
+			};
+		};
+	};
+};
+
+
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
index fb899c99753e..c85317cbff7d 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
@@ -804,7 +804,12 @@ &dss {
 };
 
 &dss_ports {
-	port {
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	port@0 {
+		reg= <0>;
+
 		dpi0_out: endpoint {
 			remote-endpoint = <&dp0_in>;
 		};
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 17+ messages in thread

* Re: [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible
  2025-08-18 15:47 ` [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible Harikrishna Shenoy
@ 2025-08-19  1:24   ` Dmitry Baryshkov
  2025-08-20  5:36     ` Harikrishna Shenoy
  2025-08-19  4:54   ` Kumar, Udit
  2025-08-19  6:45   ` Krzysztof Kozlowski
  2 siblings, 1 reply; 17+ messages in thread
From: Dmitry Baryshkov @ 2025-08-19  1:24 UTC (permalink / raw)
  To: Harikrishna Shenoy
  Cc: neil.armstrong, jessica.zhang, airlied, simona, maarten.lankhorst,
	mripard, tzimmermann, robh, krzk+dt, conor+dt, nm, vigneshr,
	kristo, thierry.reding, sam, dri-devel, devicetree,
	linux-arm-kernel, s-jain1, devarsht, u-kumar1

On Mon, Aug 18, 2025 at 09:17:44PM +0530, Harikrishna Shenoy wrote:
> Add RPi DSI panel[0] as a valid compatible for simple-panel.
> 
> [0]: https://www.raspberrypi.com/products/raspberry-pi-touch-display/
> 
> Signed-off-by: Harikrishna Shenoy <h-shenoy@ti.com>
> ---
>  .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 1ac1f0219079..65f486f2bc9d 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -268,6 +268,8 @@ properties:
>        - rocktech,rk070er9427
>          # Rocktech Display Ltd. RK043FN48H 4.3" 480x272 LCD-TFT panel
>        - rocktech,rk043fn48h
> +        # Raspberry, 7" dsi panel
> +      - rpi,7inch-dsi

It's powertip,ph800480t013-idf02

>          # Samsung Electronics 10.1" WXGA (1280x800) TFT LCD panel
>        - samsung,ltl101al01
>          # Samsung Electronics 10.1" WSVGA TFT LCD panel
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible
  2025-08-18 15:47 ` [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible Harikrishna Shenoy
  2025-08-19  1:24   ` Dmitry Baryshkov
@ 2025-08-19  4:54   ` Kumar, Udit
  2025-08-19  5:16     ` Raghavendra, Vignesh
  2025-08-19  6:45     ` Krzysztof Kozlowski
  2025-08-19  6:45   ` Krzysztof Kozlowski
  2 siblings, 2 replies; 17+ messages in thread
From: Kumar, Udit @ 2025-08-19  4:54 UTC (permalink / raw)
  To: Harikrishna Shenoy, neil.armstrong, jessica.zhang, airlied,
	simona, maarten.lankhorst, mripard, tzimmermann, robh, krzk+dt,
	conor+dt, nm, vigneshr, kristo, thierry.reding, sam, dri-devel,
	devicetree, linux-arm-kernel
  Cc: s-jain1, devarsht, u-kumar1


On 8/18/2025 9:17 PM, Harikrishna Shenoy wrote:
> Add RPi DSI panel[0] as a valid compatible for simple-panel.
>
> [0]: https://www.raspberrypi.com/products/raspberry-pi-touch-display/
>
> Signed-off-by: Harikrishna Shenoy <h-shenoy@ti.com>
> ---
>   .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index 1ac1f0219079..65f486f2bc9d 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -268,6 +268,8 @@ properties:
>         - rocktech,rk070er9427
>           # Rocktech Display Ltd. RK043FN48H 4.3" 480x272 LCD-TFT panel
>         - rocktech,rk043fn48h
> +        # Raspberry, 7" dsi panel
> +      - rpi,7inch-dsi

Hello Hari,

Driver changes should come first to match new compatible before device 
tree changes.


>           # Samsung Electronics 10.1" WXGA (1280x800) TFT LCD panel
>         - samsung,ltl101al01
>           # Samsung Electronics 10.1" WSVGA TFT LCD panel

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC PATCH 2/3] arm64: dts: ti: k3-j721e-main: Add DSI and DPHY-TX
  2025-08-18 15:47 ` [RFC PATCH 2/3] arm64: dts: ti: k3-j721e-main: Add DSI and DPHY-TX Harikrishna Shenoy
@ 2025-08-19  5:02   ` Kumar, Udit
  0 siblings, 0 replies; 17+ messages in thread
From: Kumar, Udit @ 2025-08-19  5:02 UTC (permalink / raw)
  To: Harikrishna Shenoy, neil.armstrong, jessica.zhang, airlied,
	simona, maarten.lankhorst, mripard, tzimmermann, robh, krzk+dt,
	conor+dt, nm, vigneshr, kristo, thierry.reding, sam, dri-devel,
	devicetree, linux-arm-kernel
  Cc: s-jain1, devarsht, u-kumar1


On 8/18/2025 9:17 PM, Harikrishna Shenoy wrote:
> From: Rahul T R <r-ravikumar@ti.com>
>
> TI's J721E SoC supports a DPI to DSI video signal conversion bridge on
> it's platform bus. The IP is from Cadence, and it has a custom TI
> wrapper around it to facilitate integration.
>
> This IP takes the DPI video signals from DSS and alongwith the DPHY IP,
> it transmits DSI video signals out of the SoC.
>
> Add support for DSI bridge and the DPHY-TX.
>
> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> Signed-off-by: Harikrishna Shenoy <h-shenoy@ti.com>
> ---
>   arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 31 +++++++++++++++++++++++
>   1 file changed, 31 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> index 5bd0d36bf33e..ce34d68a70f2 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> @@ -1881,6 +1881,37 @@ port@4 {
>   		};
>   	};
>   
> +	dphy2: phy@4480000 {
> +		compatible = "ti,j721e-dphy";
> +		reg = <0x0 0x04480000 0x0 0x1000>;

Please check format change to <0x00 0x04480000 0x00 0x1000> >


> +		clocks = <&k3_clks 296 1>, <&k3_clks 296 3>;
> +		clock-names = "psm", "pll_ref";
> +		#phy-cells = <0>;
> +		power-domains = <&k3_pds 296 TI_SCI_PD_EXCLUSIVE>;
> +		assigned-clocks = <&k3_clks 296 3>;
> +		assigned-clock-parents = <&k3_clks 296 4>;
> +		assigned-clock-rates = <19200000>;
> +		status = "disabled";
> +	};
> +
> +	dsi0: dsi@4800000 {
> +		compatible = "ti,j721e-dsi";
> +		reg = <0x0 0x04800000 0x0 0x100000>, <0x0 0x04710000 0x0 0x100>;
> +		clocks = <&k3_clks 150 1>, <&k3_clks 150 5>;
> +		clock-names = "dsi_p_clk", "dsi_sys_clk";
> +		power-domains = <&k3_pds 150 TI_SCI_PD_EXCLUSIVE>;
> +		interrupt-parent = <&gic500>;

I think default parent is gic, may be you can avoid above line


> +		interrupts = <GIC_SPI 600 IRQ_TYPE_LEVEL_HIGH>;
> +		phys = <&dphy2>;
> +		phy-names = "dphy";
> +		status = "disabled";
> +
> +		dsi0_ports: ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +		};
> +	};
> +
>   	dss: dss@4a00000 {
>   		compatible = "ti,j721e-dss";
>   		reg =

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC PATCH 3/3] arm64: dts: ti: k3-j721e-beagleboneai64: Add DSI RPi Panel
  2025-08-18 15:47 ` [RFC PATCH 3/3] arm64: dts: ti: k3-j721e-beagleboneai64: Add DSI RPi Panel Harikrishna Shenoy
@ 2025-08-19  5:13   ` Kumar, Udit
  0 siblings, 0 replies; 17+ messages in thread
From: Kumar, Udit @ 2025-08-19  5:13 UTC (permalink / raw)
  To: Harikrishna Shenoy, neil.armstrong, jessica.zhang, airlied,
	simona, maarten.lankhorst, mripard, tzimmermann, robh, krzk+dt,
	conor+dt, nm, vigneshr, kristo, thierry.reding, sam, dri-devel,
	devicetree, linux-arm-kernel
  Cc: s-jain1, devarsht, u-kumar1


On 8/18/2025 9:17 PM, Harikrishna Shenoy wrote:
> Add support for R-Pi DSI Panel for BBAI64.
>
> The RPi DSI panel[0] uses Toshiba TC358762 for decoding the DSI video
> signals back to DPI for its consumption. It has an ATTINY88-based
> regulator and backlight controller, and also features an EDT-FT5406
> touch controller.
>
> Fix DSS ports node in BeagkeBone AI-64 DTS by adding explicit `port@0`

Please post Fix as different patch and use Fixes tag


> child node instead of an unlabelled port, to align with dss_ports schema
> used in overlay.
>
> [0]: https://www.raspberrypi.com/products/raspberry-pi-touch-display/
>
> Signed-off-by: Rahul T R <r-ravikumar@ti.com>
> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
> Signed-off-by: Harikrishna Shenoy <h-shenoy@ti.com>
> ---
>   arch/arm64/boot/dts/ti/Makefile               |   4 +
>   ...1e-beagleboneai64-dsi-rpi-7inch-panel.dtso | 141 ++++++++++++++++++
>   .../boot/dts/ti/k3-j721e-beagleboneai64.dts   |   7 +-
>   3 files changed, 151 insertions(+), 1 deletion(-)
>   create mode 100644 arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64-dsi-rpi-7inch-panel.dtso
>
> diff --git a/arch/arm64/boot/dts/ti/Makefile b/arch/arm64/boot/dts/ti/Makefile
> index aad9177930e6..25cf12ebccce 100644
> --- a/arch/arm64/boot/dts/ti/Makefile
> +++ b/arch/arm64/boot/dts/ti/Makefile
> @@ -114,6 +114,7 @@ dtb-$(CONFIG_ARCH_K3) += k3-j7200-evm-pcie1-ep.dtbo
>   # Boards with J721e SoC
>   k3-j721e-evm-dtbs := k3-j721e-common-proc-board.dtb k3-j721e-evm-quad-port-eth-exp.dtbo
>   dtb-$(CONFIG_ARCH_K3) += k3-j721e-beagleboneai64.dtb
> +dtb-$(CONFIG_ARCH_K3) += k3-j721e-beagleboneai64-dsi-rpi-7inch-panel.dtbo
>   dtb-$(CONFIG_ARCH_K3) += k3-j721e-common-proc-board-infotainment.dtbo
>   dtb-$(CONFIG_ARCH_K3) += k3-j721e-evm.dtb
>   dtb-$(CONFIG_ARCH_K3) += k3-j721e-evm-gesi-exp-board.dtbo
> @@ -220,6 +221,8 @@ k3-am69-sk-pcie0-ep-dtbs := k3-am69-sk.dtb \
>   	k3-am69-sk-pcie0-ep.dtbo
>   k3-j7200-evm-pcie1-ep-dtbs := k3-j7200-common-proc-board.dtb \
>   	k3-j7200-evm-pcie1-ep.dtbo
> +k3-j721e-beagleboneai64-dsi-rpi-7inch-panel-dtbs := k3-j721e-beagleboneai64.dtb \
> +	k3-j721e-beagleboneai64-dsi-rpi-7inch-panel.dtbo
>   k3-j721e-common-proc-board-infotainment-dtbs := k3-j721e-common-proc-board.dtb \
>   	k3-j721e-common-proc-board-infotainment.dtbo
>   k3-j721e-evm-pcie0-ep-dtbs := k3-j721e-common-proc-board.dtb \
> @@ -267,6 +270,7 @@ dtb- += k3-am625-beagleplay-csi2-ov5640.dtb \
>   	k3-am69-sk-csi2-dual-imx219.dtb \
>   	k3-am69-sk-pcie0-ep.dtb \
>   	k3-j7200-evm-pcie1-ep.dtb \
> +	k3-j721e-beagleboneai64-dsi-rpi-7inch-panel.dtb \
>   	k3-j721e-common-proc-board-infotainment.dtb \
>   	k3-j721e-evm-pcie0-ep.dtb \
>   	k3-j721e-evm-pcie1-ep.dtb \
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64-dsi-rpi-7inch-panel.dtso b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64-dsi-rpi-7inch-panel.dtso
> new file mode 100644
> index 000000000000..c3506ccf60a4
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64-dsi-rpi-7inch-panel.dtso
> @@ -0,0 +1,141 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/**
> + * DT Overlay for RPi 7inch touchscreen panel interfaced with DSI on
> + * J721E based BeagleBone AI-64 (BBAI-64) platform.
> + *
> + * BBAI-64: https://www.beagleboard.org/boards/beaglebone-ai-64
> + * RPi DSI Panel: https://www.raspberrypi.com/products/raspberry-pi-touch-display/
> + *
> + * Copyright (C) 2024 Texas Instruments Incorporated - https://www.ti.com/

2025


> + */
> +
> +/dts-v1/;
> +/plugin/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
> +
> +#include "k3-pinctrl.h"
> +
> +&{/} {
> +	bridge_reg: bridge-regulator {
> +		compatible = "regulator-fixed";
> +		regulator-name = "bridge-reg";
> +		vin-supply = <&display_reg>;
> +		enable-active-high;
> +	};
> +
> +	panel0 {
> +		compatible = "rpi,7inch-dsi";
> +		power-supply = <&display_reg>;
> +		port {
> +			panel_in: endpoint {
> +				remote-endpoint = <&panel_bridge_out>;
> +			};
> +		};
> +	};
> +};
> +
> +&main_pmx0 {
> +	dsi_main_i2c4_pins: dsi-main-i2c4-pins {
> +		pinctrl-single,pins = <
> +			J721E_IOPAD(0xa8, PIN_INPUT_PULLUP, 2) /* (AD19) PRG1_MDIO0_MDIO.I2C4_SCL */

Clock is out signal from SOC, Please check second parameter


> +			J721E_IOPAD(0xac, PIN_INPUT_PULLUP, 2) /* (AD18) PRG1_MDIO0_MDC.I2C4_SDA */
> +		>;
> +	};
> +};
> +
> +&main_i2c4 {
> +	clock-frequency = <400000>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&dsi_main_i2c4_pins>;
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	display_reg: regulator@45 {
> +		compatible = "raspberrypi,7inch-touchscreen-panel-regulator";
> +		reg = <0x45>;
> +	};
> +
> +	touch-controller@38 {
> +		compatible = "edt,edt-ft5406";
> +		reg = <0x38>;
> +
> +		touchscreen-size-x = < 800 >;
> +		touchscreen-size-y = < 480 >;

space in 800 and 480


> +
> +		vcc-supply = <&display_reg>;

see, if you need reset-gpio as well


> +		interrupts-extended = <&main_gpio0 0 IRQ_TYPE_NONE>;
> +
> +		touchscreen-inverted-x;
> +		touchscreen-inverted-y;
> +	};
> +};
> +
> +&dss_ports {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	port@2 {
> +		reg = <2>;
> +
> +		dpi2_out: endpoint {
> +			remote-endpoint = <&dsi0_in>;
> +		};
> +	};
> +};
> +
> +&dphy2 {
> +	status = "okay";
> +};
> +
> +&dsi0 {
> +	status = "okay";
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	ports {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		port@0 {
> +			reg = <0>;
> +			dsi0_out: endpoint {
> +				remote-endpoint = <&panel_bridge_in>;
> +			};
> +		};
> +
> +		port@1 {
> +			reg = <1>;
> +			dsi0_in: endpoint {
> +				remote-endpoint = <&dpi2_out>;
> +			};
> +		};
> +	};
> +
> +	bridge@0 {
> +		compatible = "toshiba,tc358762";
> +		reg = <0>;
> +		vddc-supply = <&bridge_reg>;
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
> +				reg = <0>;
> +				panel_bridge_in: endpoint {
> +					remote-endpoint = <&dsi0_out>;
> +				};
> +			};
> +
> +			port@1 {
> +				reg = <1>;
> +				panel_bridge_out: endpoint {
> +					remote-endpoint = <&panel_in>;
> +				};
> +			};
> +		};
> +	};
> +};
> +
> +
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> index fb899c99753e..c85317cbff7d 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dts
> @@ -804,7 +804,12 @@ &dss {
>   };
>   
>   &dss_ports {
> -	port {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	port@0 {
> +		reg= <0>;
> +
>   		dpi0_out: endpoint {
>   			remote-endpoint = <&dp0_in>;
>   		};

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible
  2025-08-19  4:54   ` Kumar, Udit
@ 2025-08-19  5:16     ` Raghavendra, Vignesh
  2025-08-19  5:52       ` Kumar, Udit
  2025-08-19  6:45     ` Krzysztof Kozlowski
  1 sibling, 1 reply; 17+ messages in thread
From: Raghavendra, Vignesh @ 2025-08-19  5:16 UTC (permalink / raw)
  To: Kumar, Udit, Harikrishna Shenoy, neil.armstrong, jessica.zhang,
	airlied, simona, maarten.lankhorst, mripard, tzimmermann, robh,
	krzk+dt, conor+dt, nm, kristo, thierry.reding, sam, dri-devel,
	devicetree, linux-arm-kernel
  Cc: s-jain1, devarsht



On 8/19/2025 10:24 AM, Kumar, Udit wrote:
> 
> On 8/18/2025 9:17 PM, Harikrishna Shenoy wrote:
>> Add RPi DSI panel[0] as a valid compatible for simple-panel.
>>
>> [0]: https://www.raspberrypi.com/products/raspberry-pi-touch-display/

$subject has typo s/dsiplay/display and s/dsi/DSI
(use a spellcheck with your editor).

Also follow the existing prefix convention for the file (run
git log --oneline to figure out the right prefix)

>>
>> Signed-off-by: Harikrishna Shenoy <h-shenoy@ti.com>
>> ---
>>   .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/panel-
>> simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-
>> simple.yaml
>> index 1ac1f0219079..65f486f2bc9d 100644
>> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> @@ -268,6 +268,8 @@ properties:
>>         - rocktech,rk070er9427
>>           # Rocktech Display Ltd. RK043FN48H 4.3" 480x272 LCD-TFT panel
>>         - rocktech,rk043fn48h
>> +        # Raspberry, 7" dsi panel
>> +      - rpi,7inch-dsi
> 
> Hello Hari,
> 
> Driver changes should come first to match new compatible before device
> tree changes.

No, there isnt a driver update that I can see in the current series. But
if there was one, then such a patch should be slotted after binding
updates as Bindings represent HW. Besides checkpatch will complain

> 
> 
>>           # Samsung Electronics 10.1" WXGA (1280x800) TFT LCD panel
>>         - samsung,ltl101al01
>>           # Samsung Electronics 10.1" WSVGA TFT LCD panel


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible
  2025-08-19  5:16     ` Raghavendra, Vignesh
@ 2025-08-19  5:52       ` Kumar, Udit
  2025-08-19  6:46         ` Krzysztof Kozlowski
  2025-08-20 23:35         ` Rob Herring
  0 siblings, 2 replies; 17+ messages in thread
From: Kumar, Udit @ 2025-08-19  5:52 UTC (permalink / raw)
  To: Raghavendra, Vignesh, Harikrishna Shenoy, neil.armstrong,
	jessica.zhang, airlied, simona, maarten.lankhorst, mripard,
	tzimmermann, robh, krzk+dt, conor+dt, nm, kristo, thierry.reding,
	sam, dri-devel, devicetree, linux-arm-kernel
  Cc: s-jain1, devarsht, u-kumar1


On 8/19/2025 10:46 AM, Raghavendra, Vignesh wrote:
>
> On 8/19/2025 10:24 AM, Kumar, Udit wrote:
>> On 8/18/2025 9:17 PM, Harikrishna Shenoy wrote:
>>> Add RPi DSI panel[0] as a valid compatible for simple-panel.
>>>
>>> [0]: https://www.raspberrypi.com/products/raspberry-pi-touch-display/
> $subject has typo s/dsiplay/display and s/dsi/DSI
> (use a spellcheck with your editor).
>
> Also follow the existing prefix convention for the file (run
> git log --oneline to figure out the right prefix)
>
>>> Signed-off-by: Harikrishna Shenoy <h-shenoy@ti.com>
>>> ---
>>>    .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
>>>    1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/panel/panel-
>>> simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-
>>> simple.yaml
>>> index 1ac1f0219079..65f486f2bc9d 100644
>>> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>>> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>>> @@ -268,6 +268,8 @@ properties:
>>>          - rocktech,rk070er9427
>>>            # Rocktech Display Ltd. RK043FN48H 4.3" 480x272 LCD-TFT panel
>>>          - rocktech,rk043fn48h
>>> +        # Raspberry, 7" dsi panel
>>> +      - rpi,7inch-dsi
>> Hello Hari,
>>
>> Driver changes should come first to match new compatible before device
>> tree changes.
> No, there isnt a driver update that I can see in the current series. But

correct current series does not have driver changes.

I would expect driver changes as well, which should come before device tree.


> if there was one, then such a patch should be slotted after binding
> updates as Bindings represent HW. Besides checkpatch will complain
>
>>
>>>            # Samsung Electronics 10.1" WXGA (1280x800) TFT LCD panel
>>>          - samsung,ltl101al01
>>>            # Samsung Electronics 10.1" WSVGA TFT LCD panel

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible
  2025-08-18 15:47 ` [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible Harikrishna Shenoy
  2025-08-19  1:24   ` Dmitry Baryshkov
  2025-08-19  4:54   ` Kumar, Udit
@ 2025-08-19  6:45   ` Krzysztof Kozlowski
  2 siblings, 0 replies; 17+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-19  6:45 UTC (permalink / raw)
  To: Harikrishna Shenoy, neil.armstrong, jessica.zhang, airlied,
	simona, maarten.lankhorst, mripard, tzimmermann, robh, krzk+dt,
	conor+dt, nm, vigneshr, kristo, thierry.reding, sam, dri-devel,
	devicetree, linux-arm-kernel
  Cc: s-jain1, devarsht, u-kumar1

On 18/08/2025 17:47, Harikrishna Shenoy wrote:
> Add RPi DSI panel[0] as a valid compatible for simple-panel.
> 
> [0]: https://www.raspberrypi.com/products/raspberry-pi-touch-display/
> 
> Signed-off-by: Harikrishna Shenoy <h-shenoy@ti.com>
> ---


Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Plus typos...

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible
  2025-08-19  4:54   ` Kumar, Udit
  2025-08-19  5:16     ` Raghavendra, Vignesh
@ 2025-08-19  6:45     ` Krzysztof Kozlowski
  1 sibling, 0 replies; 17+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-19  6:45 UTC (permalink / raw)
  To: Kumar, Udit, Harikrishna Shenoy, neil.armstrong, jessica.zhang,
	airlied, simona, maarten.lankhorst, mripard, tzimmermann, robh,
	krzk+dt, conor+dt, nm, vigneshr, kristo, thierry.reding, sam,
	dri-devel, devicetree, linux-arm-kernel
  Cc: s-jain1, devarsht

On 19/08/2025 06:54, Kumar, Udit wrote:
>> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> index 1ac1f0219079..65f486f2bc9d 100644
>> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> @@ -268,6 +268,8 @@ properties:
>>         - rocktech,rk070er9427
>>           # Rocktech Display Ltd. RK043FN48H 4.3" 480x272 LCD-TFT panel
>>         - rocktech,rk043fn48h
>> +        # Raspberry, 7" dsi panel
>> +      - rpi,7inch-dsi
> 
> Hello Hari,
> 
> Driver changes should come first to match new compatible before device 
> tree changes.

Read submitting patches before giving advices.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible
  2025-08-19  5:52       ` Kumar, Udit
@ 2025-08-19  6:46         ` Krzysztof Kozlowski
  2025-08-20 23:35         ` Rob Herring
  1 sibling, 0 replies; 17+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-19  6:46 UTC (permalink / raw)
  To: Kumar, Udit, Raghavendra, Vignesh, Harikrishna Shenoy,
	neil.armstrong, jessica.zhang, airlied, simona, maarten.lankhorst,
	mripard, tzimmermann, robh, krzk+dt, conor+dt, nm, kristo,
	thierry.reding, sam, dri-devel, devicetree, linux-arm-kernel
  Cc: s-jain1, devarsht

On 19/08/2025 07:52, Kumar, Udit wrote:
> 
> I would expect driver changes as well, which should come before device tree.

Stop advising this nonsense.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible
  2025-08-19  1:24   ` Dmitry Baryshkov
@ 2025-08-20  5:36     ` Harikrishna Shenoy
  2025-08-20 10:04       ` Raghavendra, Vignesh
  0 siblings, 1 reply; 17+ messages in thread
From: Harikrishna Shenoy @ 2025-08-20  5:36 UTC (permalink / raw)
  To: Dmitry Baryshkov, Harikrishna Shenoy
  Cc: neil.armstrong, jessica.zhang, airlied, simona, maarten.lankhorst,
	mripard, tzimmermann, robh, krzk+dt, conor+dt, nm, vigneshr,
	kristo, thierry.reding, sam, dri-devel, devicetree,
	linux-arm-kernel, s-jain1, devarsht, u-kumar1


On 8/19/25 06:54, Dmitry Baryshkov wrote:
> On Mon, Aug 18, 2025 at 09:17:44PM +0530, Harikrishna Shenoy wrote:
>> Add RPi DSI panel[0] as a valid compatible for simple-panel.
>>
>> [0]: https://www.raspberrypi.com/products/raspberry-pi-touch-display/
>>
>> Signed-off-by: Harikrishna Shenoy <h-shenoy@ti.com>
>> ---
>>   .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> index 1ac1f0219079..65f486f2bc9d 100644
>> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>> @@ -268,6 +268,8 @@ properties:
>>         - rocktech,rk070er9427
>>           # Rocktech Display Ltd. RK043FN48H 4.3" 480x272 LCD-TFT panel
>>         - rocktech,rk043fn48h
>> +        # Raspberry, 7" dsi panel
>> +      - rpi,7inch-dsi
> It's powertip,ph800480t013-idf02
Could you please point to any documentation for this?
>
>>           # Samsung Electronics 10.1" WXGA (1280x800) TFT LCD panel
>>         - samsung,ltl101al01
>>           # Samsung Electronics 10.1" WSVGA TFT LCD panel
>> -- 
>> 2.34.1
>>

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible
  2025-08-20  5:36     ` Harikrishna Shenoy
@ 2025-08-20 10:04       ` Raghavendra, Vignesh
       [not found]         ` <c1edadf5-538c-43f6-aea4-8fa9f9c5aa13@ti.com>
  0 siblings, 1 reply; 17+ messages in thread
From: Raghavendra, Vignesh @ 2025-08-20 10:04 UTC (permalink / raw)
  To: Harikrishna Shenoy, Dmitry Baryshkov, Harikrishna Shenoy
  Cc: neil.armstrong, jessica.zhang, airlied, simona, maarten.lankhorst,
	mripard, tzimmermann, robh, krzk+dt, conor+dt, nm, kristo,
	thierry.reding, sam, dri-devel, devicetree, linux-arm-kernel,
	s-jain1, devarsht, u-kumar1



On 8/20/2025 11:06 AM, Harikrishna Shenoy wrote:
> 
> On 8/19/25 06:54, Dmitry Baryshkov wrote:
>> On Mon, Aug 18, 2025 at 09:17:44PM +0530, Harikrishna Shenoy wrote:
>>> Add RPi DSI panel[0] as a valid compatible for simple-panel.
>>>
>>> [0]: https://www.raspberrypi.com/products/raspberry-pi-touch-display/
>>>
>>> Signed-off-by: Harikrishna Shenoy <h-shenoy@ti.com>
>>> ---
>>>   .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/panel/panel-
>>> simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-
>>> simple.yaml
>>> index 1ac1f0219079..65f486f2bc9d 100644
>>> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>>> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
>>> @@ -268,6 +268,8 @@ properties:
>>>         - rocktech,rk070er9427
>>>           # Rocktech Display Ltd. RK043FN48H 4.3" 480x272 LCD-TFT panel
>>>         - rocktech,rk043fn48h
>>> +        # Raspberry, 7" dsi panel
>>> +      - rpi,7inch-dsi
>> It's powertip,ph800480t013-idf02
> Could you please point to any documentation for this?

Git log would point you to it: 

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=051e95ee7ec10050154e4c8f48be4d99ac83f8fc

>>
>>>           # Samsung Electronics 10.1" WXGA (1280x800) TFT LCD panel
>>>         - samsung,ltl101al01
>>>           # Samsung Electronics 10.1" WSVGA TFT LCD panel
>>> -- 
>>> 2.34.1
>>>


^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible
  2025-08-19  5:52       ` Kumar, Udit
  2025-08-19  6:46         ` Krzysztof Kozlowski
@ 2025-08-20 23:35         ` Rob Herring
  1 sibling, 0 replies; 17+ messages in thread
From: Rob Herring @ 2025-08-20 23:35 UTC (permalink / raw)
  To: Kumar, Udit
  Cc: Raghavendra, Vignesh, Harikrishna Shenoy, neil.armstrong,
	jessica.zhang, airlied, simona, maarten.lankhorst, mripard,
	tzimmermann, krzk+dt, conor+dt, nm, kristo, thierry.reding, sam,
	dri-devel, devicetree, linux-arm-kernel, s-jain1, devarsht

On Tue, Aug 19, 2025 at 11:22:42AM +0530, Kumar, Udit wrote:
> 
> On 8/19/2025 10:46 AM, Raghavendra, Vignesh wrote:
> > 
> > On 8/19/2025 10:24 AM, Kumar, Udit wrote:
> > > On 8/18/2025 9:17 PM, Harikrishna Shenoy wrote:
> > > > Add RPi DSI panel[0] as a valid compatible for simple-panel.
> > > > 
> > > > [0]: https://www.raspberrypi.com/products/raspberry-pi-touch-display/
> > $subject has typo s/dsiplay/display and s/dsi/DSI
> > (use a spellcheck with your editor).
> > 
> > Also follow the existing prefix convention for the file (run
> > git log --oneline to figure out the right prefix)
> > 
> > > > Signed-off-by: Harikrishna Shenoy <h-shenoy@ti.com>
> > > > ---
> > > >    .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
> > > >    1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-
> > > > simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-
> > > > simple.yaml
> > > > index 1ac1f0219079..65f486f2bc9d 100644
> > > > --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > > > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > > > @@ -268,6 +268,8 @@ properties:
> > > >          - rocktech,rk070er9427
> > > >            # Rocktech Display Ltd. RK043FN48H 4.3" 480x272 LCD-TFT panel
> > > >          - rocktech,rk043fn48h
> > > > +        # Raspberry, 7" dsi panel
> > > > +      - rpi,7inch-dsi
> > > Hello Hari,
> > > 
> > > Driver changes should come first to match new compatible before device
> > > tree changes.
> > No, there isnt a driver update that I can see in the current series. But
> 
> correct current series does not have driver changes.
> 
> I would expect driver changes as well, which should come before device tree.

If you rely on that, then you are likely breaking the ABI. Please don't 
submit any DT related patches until you understand that.

You must define the ABI first, then add users of that ABI. Users are 
both .dts files and drivers. It is that simple.

Rob

^ permalink raw reply	[flat|nested] 17+ messages in thread

* Re: [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible
       [not found]         ` <c1edadf5-538c-43f6-aea4-8fa9f9c5aa13@ti.com>
@ 2025-08-21 10:46           ` Dmitry Baryshkov
  0 siblings, 0 replies; 17+ messages in thread
From: Dmitry Baryshkov @ 2025-08-21 10:46 UTC (permalink / raw)
  To: Harikrishna Shenoy
  Cc: Raghavendra, Vignesh, Harikrishna Shenoy, neil.armstrong,
	jessica.zhang, airlied, simona, maarten.lankhorst, mripard,
	tzimmermann, robh, krzk+dt, conor+dt, nm, kristo, thierry.reding,
	sam, dri-devel, devicetree, linux-arm-kernel, s-jain1, devarsht,
	u-kumar1

On Thu, Aug 21, 2025 at 10:33:43AM +0530, Harikrishna Shenoy wrote:
> 
> On 8/20/25 15:34, Raghavendra, Vignesh wrote:
> > 
> > On 8/20/2025 11:06 AM, Harikrishna Shenoy wrote:
> > > On 8/19/25 06:54, Dmitry Baryshkov wrote:
> > > > On Mon, Aug 18, 2025 at 09:17:44PM +0530, Harikrishna Shenoy wrote:
> > > > > Add RPi DSI panel[0] as a valid compatible for simple-panel.
> > > > > 
> > > > > [0]:https://www.raspberrypi.com/products/raspberry-pi-touch-display/
> > > > > 
> > > > > Signed-off-by: Harikrishna Shenoy<h-shenoy@ti.com>
> > > > > ---
> > > > >    .../devicetree/bindings/display/panel/panel-simple.yaml         | 2 ++
> > > > >    1 file changed, 2 insertions(+)
> > > > > 
> > > > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-
> > > > > simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-
> > > > > simple.yaml
> > > > > index 1ac1f0219079..65f486f2bc9d 100644
> > > > > --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > > > > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > > > > @@ -268,6 +268,8 @@ properties:
> > > > >          - rocktech,rk070er9427
> > > > >            # Rocktech Display Ltd. RK043FN48H 4.3" 480x272 LCD-TFT panel
> > > > >          - rocktech,rk043fn48h
> > > > > +        # Raspberry, 7" dsi panel
> > > > > +      - rpi,7inch-dsi
> > > > It's powertip,ph800480t013-idf02
> > > Could you please point to any documentation for this?
> > Git log would point you to it:
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=051e95ee7ec10050154e4c8f48be4d99ac83f8fc
> 
> Timing patterns we use differ from powertip,ph800480t013-idf02.
> 
> Link:
> 
> https://github.com/raspberrypi/linux/commit/8648a8c9442b45e85b73423be1b469d10234b4e2
> 
> https://github.com/beagleboard/linux/commit/bde1b4c52cc5a79a2108076b8706e23d5844afa9
> 
> So I think, separate compatible needs to be added.

Then please identify the panel that is actually being used. RaspberryPi
isn't a panel vendor.

> 
> > > > >            # Samsung Electronics 10.1" WXGA (1280x800) TFT LCD panel
> > > > >          - samsung,ltl101al01
> > > > >            # Samsung Electronics 10.1" WSVGA TFT LCD panel
> > > > > -- 
> > > > > 2.34.1
> > > > > 

-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2025-08-21 10:46 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-18 15:47 [RFC PATCH 0/3] Add DSI and Raspberry Pi panel support Harikrishna Shenoy
2025-08-18 15:47 ` [RFC PATCH 1/3] devicetree: bindings: dsiplay: panel: panel-simple.yaml: Add Raspberry pi dsi panel compatible Harikrishna Shenoy
2025-08-19  1:24   ` Dmitry Baryshkov
2025-08-20  5:36     ` Harikrishna Shenoy
2025-08-20 10:04       ` Raghavendra, Vignesh
     [not found]         ` <c1edadf5-538c-43f6-aea4-8fa9f9c5aa13@ti.com>
2025-08-21 10:46           ` Dmitry Baryshkov
2025-08-19  4:54   ` Kumar, Udit
2025-08-19  5:16     ` Raghavendra, Vignesh
2025-08-19  5:52       ` Kumar, Udit
2025-08-19  6:46         ` Krzysztof Kozlowski
2025-08-20 23:35         ` Rob Herring
2025-08-19  6:45     ` Krzysztof Kozlowski
2025-08-19  6:45   ` Krzysztof Kozlowski
2025-08-18 15:47 ` [RFC PATCH 2/3] arm64: dts: ti: k3-j721e-main: Add DSI and DPHY-TX Harikrishna Shenoy
2025-08-19  5:02   ` Kumar, Udit
2025-08-18 15:47 ` [RFC PATCH 3/3] arm64: dts: ti: k3-j721e-beagleboneai64: Add DSI RPi Panel Harikrishna Shenoy
2025-08-19  5:13   ` Kumar, Udit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).