From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 093783314A2; Mon, 18 Aug 2025 18:26:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755541614; cv=none; b=BRmoLQOVDcwd3adG+BCkRI+3K594r5erCXbK+LFv0PBixWMi5WytMo1hf6cXtwWP19VD6jbnAKNkvAnD/wLEWPUAoRqsIwwerz5uQrHUgFtEvtpzcdGTL8LhiOvhbWBTjNhemVQej8U6EdlpOLcw7Ek2oYA3tHn7AzsVMWbL0Gw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755541614; c=relaxed/simple; bh=cJtUW+vi9Bpqx+2oOXE9Ny2QyDh2KiaJnBmjqvxVePw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=i5kc9gA8jQydOBDE9SsAuO/bR+MUd7EPE5zmvED21kXbB++7kvgB/06PQYJbBenRVevHBWyr/L/p4Sxo2WRcULEqp0J7s62xt5CoBDP90MHcgIonmSENuP5WA780q12DWtQlG5sEzLYsbSRI4+rIVqNsh8xwhuX4PEo8jqDvLE0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VU+zvF3C; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VU+zvF3C" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 763A9C4CEEB; Mon, 18 Aug 2025 18:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755541613; bh=cJtUW+vi9Bpqx+2oOXE9Ny2QyDh2KiaJnBmjqvxVePw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VU+zvF3CVjS8P3Ser0xAJh/8tN9iIuRBdsYurn7nbLgTscoJcby5dBZuPwxWS7zWz TJzZCuVkgkn+I9uxz9mKTPl9DRnMWPk1ZAxTYeFuru5OsvXz0NlMMdMsUTCzOPSZl2 b2SCWZfbjnZyMV2/QGokXUc8oBYPLK6Wm5RVYwrEWnJuDfvl/8XoZKTmBHE3Qnmr43 2NKdT7dyFDN4IlcuY6j4wWaMJ92eXzhnml+XqOrcsED4gGFBi6HPCAPvKOs1Xzax3Q xLSwktgrjPbhzS5tjD7Q69X88hG/0CGIWsG6dPHTlZDXagkkSkaNCs1GqfPs0Imboj 8/MmwzRbmNj2w== Date: Mon, 18 Aug 2025 19:26:41 +0100 From: Jonathan Cameron To: Ioana Risteiu Cc: Lars-Peter Clausen , Michael Hennerich , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ramona Nechita , , , Subject: Re: [PATCH v3 1/4] iio: adc: adi-axi-adc: add axi_adc_num_lanes_set Message-ID: <20250818192641.61f9af06@jic23-huawei> In-Reply-To: <20250818131253.8854-2-Ioana.Risteiu@analog.com> References: <20250818131253.8854-1-Ioana.Risteiu@analog.com> <20250818131253.8854-2-Ioana.Risteiu@analog.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 18 Aug 2025 16:12:47 +0300 Ioana Risteiu wrote: > Add axi_adc_num_lanes_set in the adi_axi_adc_ops structure to support > setting number of lanes used by AXI ADC. > > Signed-off-by: Ioana Risteiu So far we only have this set for a specific compatible. Why does it now make sense to set it for the 'generic' case? Please add something to the patch description. Jonathan > --- > drivers/iio/adc/adi-axi-adc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/adc/adi-axi-adc.c b/drivers/iio/adc/adi-axi-adc.c > index 2d86bb0e08a7..20bb59c24acf 100644 > --- a/drivers/iio/adc/adi-axi-adc.c > +++ b/drivers/iio/adc/adi-axi-adc.c > @@ -617,6 +617,7 @@ static const struct iio_backend_ops adi_axi_adc_ops = { > .chan_status = axi_adc_chan_status, > .interface_type_get = axi_adc_interface_type_get, > .oversampling_ratio_set = axi_adc_oversampling_ratio_set, > + .num_lanes_set = axi_adc_num_lanes_set, > .debugfs_reg_access = iio_backend_debugfs_ptr(axi_adc_reg_access), > .debugfs_print_chan_status = iio_backend_debugfs_ptr(axi_adc_debugfs_print_chan_status), > };