From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15AEF2D8DB9 for ; Wed, 20 Aug 2025 08:29:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755678551; cv=none; b=Soec86Aa9JCyA294RXZF61Eyn7jagu4YvSG4aCN+N9fku2iIV9WaATeJVA/NzXo41qXvPQr3UagpHhwKXiE2C+GDjrDttfuAHdUo3ohfr4F+J++t3VjJ3ftu/XuQnF+ABqrJYZ0SF/6+203uOmJIho1gt+QC8Tq2qP2hdDIkofQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755678551; c=relaxed/simple; bh=qbiTA97ecG75CN8dtvPjbRcNXFdrEC8SJKen2afmr8Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hSMfQUzTmaEP+onJTTprZADK92mxleYwv64JkR1/ZsenD04s7crv9GGtny7XAWWqfTUEw5piCLafOtIbRQdlD8jZddrq+DuNfqM5CViwVcAnfHAMq32cNnIETIehwMAf/Lk+GI5GWYHJzp0Jk91Gzj3tnGp+v51iPJEjdkyOzWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DhSXmS1D; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DhSXmS1D" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57K1owwa004061 for ; Wed, 20 Aug 2025 08:29:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wWW4BGFpCWnZEZLf1V0C0XICc4F6I83lE+aOEu8pGoQ=; b=DhSXmS1D2tEcfEs+ 0F1dr8C9vF75Db1WZpcBehjJyqnZDzAmxIQ/2eeLoQGP3x6SaOX9iU1elAFGoZY3 Pd787xDJ86WbgVE8OhdGxRlX+Xt4F6zGna6qkpocWZNJ4s0BjNSxlGG3MCxP1mmt jwioZudGCfVFco/FfO6AqEi7BpmFOVrdoTRbA8FncN/Dvg7ScApr6WwtPnf/S++l Zq+BHogpGSttwdOaZWk4hY1IydOIi2Is880jq365zlQ0o3OWbOdlBkBRA1otn8wa fvaRxnSk/vG+TKCkCNqzgO+cWBXmy5sIwl/Ii/hdtSNUhi5Ka40LJYFtGlgRNnFA K/lB4g== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48n52agyet-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 20 Aug 2025 08:29:08 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2445806dc88so156641055ad.1 for ; Wed, 20 Aug 2025 01:29:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755678547; x=1756283347; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wWW4BGFpCWnZEZLf1V0C0XICc4F6I83lE+aOEu8pGoQ=; b=RyiBNeuZhOGTTTT/0V2zMx1TXtxX3wnlKSLPAs93keVHIw2LvoYHqFffmk3bjXCBqB uuZpRbfXGZgEOnK8eIqrqtOIXFyCvh+eVqeYDZxZ6IU+JWjmgm42ViyDowC+t3IHgN0c RIrmc9Pbo2lmDGiVW1KBbxKC15V8zDIdAqth88SmZiQcyYzSHhUNLZ5QU6BpcF53TRDM xxC7/hfMt9/x8iPR88+vc7wrqBkxljQVRkO8r0KfEiRdyvO4gunbgcA1D4zoHHbPdtxU XdhaXw45HaSr/awKSfG5k3L7RPa+GaPUmWfSv6pVjhYQ0QQwtHoSIlTKLKuIKPmC+18t jgZg== X-Forwarded-Encrypted: i=1; AJvYcCWcUK2AKp4ECtjqed/InNBMxaPA009ssw6yu+g5fFUaMyl3gc1NFwrQMQBo1bBs55Fe9SSWJBUHgSCK@vger.kernel.org X-Gm-Message-State: AOJu0Yy0nlMSlSSCBzAUgAPf8Ainr8S0nkGlGGiVrTtUaKsPOaG//eYh Q/1Cz3ODCmUbkng7KFqpzDjgoS19kwUOjByFHvaB9AjTwnjUifiZtreolPWKl2TCfaEdUpn21Hx azVVyBoFQehB/GJrN1dIJEqEq6cprpYY+WKkPzY+izkgRwm4dQk8wOuVjhC+CAjs3 X-Gm-Gg: ASbGnctWAjNDKXEcxCqsX92pJX5xwxEZigLWXOWhFPs7HoAcE6FzpvAvKnIGVam5VhB PwMHUy+t1DYOr6R4Vc5QGugjp+XFxix4pLgDeKj4k/EmQrkUdUuJu7e4WtEnVlOlJ3oaupUhXZS Ve5z6p5uQN57mqbQpOTU+1DNFGY28GFD7vQ/XlwJgdqf/5UKpLVyQpO7tGwknlgwmq2MpKO7BfX tDx1D+ykAPfQUDTgmgitTgNWUVDnPbKwvjyKBJkrjfg4mCAEujYpRF/cbFtL0o+B4CL5l0oz1CU n95slUMfLHL0SBVUW4AZMhBN8isXDDlR1bWDaDLs2ua0CVr6+hEx951MYIKFSB2STRN3btC//wY = X-Received: by 2002:a17:902:ec88:b0:240:a430:91d with SMTP id d9443c01a7336-245ef0d5915mr22618755ad.10.1755678547500; Wed, 20 Aug 2025 01:29:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFSJ1H1k68/Z9d58rrQY87Pvbazso9gHhcBZnMUte8gdhBHonHKpDa9vvaIPOQgp3qW13nehA== X-Received: by 2002:a17:902:ec88:b0:240:a430:91d with SMTP id d9443c01a7336-245ef0d5915mr22618395ad.10.1755678546826; Wed, 20 Aug 2025 01:29:06 -0700 (PDT) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-245ed53e779sm19037735ad.160.2025.08.20.01.29.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Aug 2025 01:29:06 -0700 (PDT) From: Krishna Chaitanya Chundru Date: Wed, 20 Aug 2025 13:58:48 +0530 Subject: [PATCH v4 2/7] OPP: Move refcount and key update for readability in _opp_table_find_key() Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250820-opp_pcie-v4-2-273b8944eed0@oss.qualcomm.com> References: <20250820-opp_pcie-v4-0-273b8944eed0@oss.qualcomm.com> In-Reply-To: <20250820-opp_pcie-v4-0-273b8944eed0@oss.qualcomm.com> To: Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Krishna Chaitanya Chundru X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1755678529; l=1497; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=qbiTA97ecG75CN8dtvPjbRcNXFdrEC8SJKen2afmr8Y=; b=Y2kKzNaAKkSTFkX+ee44JG1EL0b6zaOZsUtgDls6JWW7HqrCg8Dons6oSWblDqtIqytD7X1iJ PylRDO/5ugsA96VHM0f7uTAOTYikgrV1LorOMCRMWAuPEYWHOKoTpC1 X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Proofpoint-GUID: FKb1bqrqTh_a8PqumxgFio6vU8YrdWu6 X-Proofpoint-ORIG-GUID: FKb1bqrqTh_a8PqumxgFio6vU8YrdWu6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIwMDAxMyBTYWx0ZWRfXxBTKug8qpNl6 X5h46cRNZBU72oEtV8mGACJffsKz1CaE9tQua2W8ySIFdB5QliCQMwJeaP9Fg3d6G/GM1Lt6IwX L/m9M2bIYwonNnyuHsc5xVCHa+mHzI+eHVkcHm2jcCD5/gRZRMq6nFZQ3Y4P1Wt6Cyaoi0vktPM Fu5HLafr5qFqLRYE3XXEb2YmsUqVo53g9UUdN3+55pwCl1ZLsHxmcZ58SHDW1IyNFIYpjRaKwVO WHIufgpMt+0ngkOfj0/PCPhBgu/3a66g9D7vwRvTC2ZjXsDN3vLXQC5gm3ADLPR8hnS0QEtxdM2 yVfdy/dLtQSkFi1/04gooUMPXkiZf+OC20fbwObppXcvqVcy3DA3XiqA6xtZ9xCyxb2L6DPdxon x/9qUurC+kxdcpWpSXFEEH2fHDXirA== X-Authority-Analysis: v=2.4 cv=XfbQDI55 c=1 sm=1 tr=0 ts=68a58754 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=EUspDBNiAAAA:8 a=Zg3aejBZfcS9hqUhyUQA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-20_03,2025-08-20_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2508110000 definitions=main-2508200013 Refactor _opp_table_find_key() to improve readability by moving the reference count increment and key update inside the match condition block. Also make the 'assert' check mandatory instead of treating it as optional. Signed-off-by: Krishna Chaitanya Chundru --- drivers/opp/core.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/opp/core.c b/drivers/opp/core.c index a36c3daac39cd0bdd2a1f7e9bad5b92f0c756153..bf49709b8c39271431772924daf0c003b45eec7f 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@ -544,24 +544,22 @@ static struct dev_pm_opp *_opp_table_find_key(struct opp_table *opp_table, struct dev_pm_opp *temp_opp, *opp = ERR_PTR(-ERANGE); /* Assert that the requirement is met */ - if (assert && !assert(opp_table, index)) + if (!assert(opp_table, index)) return ERR_PTR(-EINVAL); guard(mutex)(&opp_table->lock); list_for_each_entry(temp_opp, &opp_table->opp_list, node) { if (temp_opp->available == available) { - if (compare(&opp, temp_opp, read(temp_opp, index), *key)) + if (compare(&opp, temp_opp, read(temp_opp, index), *key)) { + /* Increment the reference count of OPP */ + *key = read(opp, index); + dev_pm_opp_get(opp); break; + } } } - /* Increment the reference count of OPP */ - if (!IS_ERR(opp)) { - *key = read(opp, index); - dev_pm_opp_get(opp); - } - return opp; } -- 2.34.1