From: Krzysztof Kozlowski <krzk@kernel.org>
To: Chuan Liu <chuan.liu@amlogic.com>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/13] dt-bindings: soc: amlogic: Unify the compatible property for clk-measure
Date: Wed, 20 Aug 2025 10:09:23 +0200 [thread overview]
Message-ID: <20250820-shapeless-devout-pig-defdd7@kuoka> (raw)
In-Reply-To: <20250815-add-more-socs-to-support-clk_measure-v1-5-59f04ba67457@amlogic.com>
On Fri, Aug 15, 2025 at 04:37:31PM +0800, Chuan Liu wrote:
> The clk-measure IPs across Amlogic SoCs have minimal differences, so
> they can be managed with a unified compatible property.
>
> Signed-off-by: Chuan Liu <chuan.liu@amlogic.com>
> ---
> .../bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml
> index 1c9d37eef5f0..a7927acde2fe 100644
> --- a/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml
> +++ b/Documentation/devicetree/bindings/soc/amlogic/amlogic,meson-gx-clk-measure.yaml
> @@ -15,15 +15,7 @@ maintainers:
>
> properties:
> compatible:
> - enum:
> - - amlogic,meson-gx-clk-measure
> - - amlogic,meson8-clk-measure
> - - amlogic,meson8b-clk-measure
> - - amlogic,meson-axg-clk-measure
> - - amlogic,meson-g12a-clk-measure
> - - amlogic,meson-sm1-clk-measure
> - - amlogic,c3-clk-measure
> - - amlogic,s4-clk-measure
> + const: amlogic,clk-measure
Obviously NAK, cannot stress more how wrong your approach is. It defies
all rules for writing bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-20 8:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 8:37 [PATCH 00/13] soc: amlogic: clk-measure: Add more SoCs to support clk-measure Chuan Liu via B4 Relay
2025-08-15 8:37 ` [PATCH 01/13] dt-bindings: soc: amlogic: Add clk-measure related properties Chuan Liu via B4 Relay
2025-08-20 8:08 ` Krzysztof Kozlowski
2025-08-15 8:37 ` [PATCH 02/13] soc: amlogic: clk-measure: Remove the msr_data from clk-measure Chuan Liu via B4 Relay
2025-08-20 8:10 ` Krzysztof Kozlowski
2025-08-15 8:37 ` [PATCH 03/13] ARM: dts: amlogic: add clk-measure IDs and names for meson SoC family Chuan Liu via B4 Relay
2025-08-15 8:37 ` [PATCH 04/13] arm64: dts: amlogic: add clk-measure IDs and names for Amlogic SoCs Chuan Liu via B4 Relay
2025-08-15 8:37 ` [PATCH 05/13] dt-bindings: soc: amlogic: Unify the compatible property for clk-measure Chuan Liu via B4 Relay
2025-08-20 8:09 ` Krzysztof Kozlowski [this message]
2025-08-15 8:37 ` [PATCH 06/13] soc: amlogic: clk-measure: Unify the compatible property Chuan Liu via B4 Relay
2025-08-20 8:11 ` Krzysztof Kozlowski
2025-08-15 8:37 ` [PATCH 07/13] ARM: dts: amlogic: Unify the compatible property for clk-measure Chuan Liu via B4 Relay
2025-08-15 8:37 ` [PATCH 08/13] arm64: " Chuan Liu via B4 Relay
2025-08-20 8:11 ` Krzysztof Kozlowski
2025-08-15 8:37 ` [PATCH 09/13] arm64: dts: amlogic: A4: Add clk-measure controller node Chuan Liu via B4 Relay
2025-08-15 8:37 ` [PATCH 10/13] arm64: dts: amlogic: A5: " Chuan Liu via B4 Relay
2025-08-15 8:37 ` [PATCH 11/13] arm64: dts: amlogic: S7: " Chuan Liu via B4 Relay
2025-08-15 8:37 ` [PATCH 12/13] arm64: dts: amlogic: S7D: " Chuan Liu via B4 Relay
2025-08-15 8:37 ` [PATCH 13/13] arm64: dts: amlogic: S6: " Chuan Liu via B4 Relay
2025-08-18 8:01 ` [PATCH 00/13] soc: amlogic: clk-measure: Add more SoCs to support clk-measure Neil Armstrong
2025-08-19 3:32 ` Chuan Liu
2025-08-20 8:12 ` Krzysztof Kozlowski
2025-08-20 10:05 ` Chuan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250820-shapeless-devout-pig-defdd7@kuoka \
--to=krzk@kernel.org \
--cc=chuan.liu@amlogic.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).