From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D21E2D7DC1; Thu, 21 Aug 2025 20:11:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755807112; cv=none; b=LBxKfmlD6Dj1tU7LUlogj0X8MeMjdUfEmOedS711RtTbMNVxDPuOMZUrb/+W5UPfmJiQXCwY4z0KR7L749qQMwTfnUniXsXBH/w4Ml0n0q56OQfUfcE5IAbm8gUT0to8/A5oJfA3GaGB1tjhtoef0J1MSL8kv8S4/9f/XaXnBmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755807112; c=relaxed/simple; bh=7UOumc/dJtyyg/QHnSWjD+BJvJ9yDJg2TGgCVbIk6CM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lUWfjXs53Ket06dTowXE1WvdWTATldTHmHq0BNp2PmurdlM+8agbSQS5bY1vUblXg3aF/PjQtqAgSQMMNK4ZqKFP9/DQIXgAtxsii8Iwzxm4LXg26j+YLTSkeYNxehT89dF+GIDnSIs0LL7uJgEHWpdIiubuklRaF+iQ+mp9XZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fzzx2DPw; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fzzx2DPw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDEADC113CF; Thu, 21 Aug 2025 20:11:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755807112; bh=7UOumc/dJtyyg/QHnSWjD+BJvJ9yDJg2TGgCVbIk6CM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fzzx2DPw9mcPZMFjVVeE3vDfbB+KsTvTOnjiRss1yZIQQxDOGeQpx3470+JJWdfsO i1sriDdf22FFpp1If8dgdkNQL4vNBD4Cn5YKOPkKmm0KtBBoWaU13VzG/Zmxjehg8Q fNR+hoVptU7F4jnjPJ+lJ0sSYjpd5MOeiMuWnY3UImZtXq1Hrxtx72eDNAKimjhO1F XXth8RidvFkZmsKxU3c1knwY4UBeSmKZYRBZ79V3005xl8WsVLeuk0pzz7zBNps05W Fz2hQUQaw7Vw9LBHELUopkY2fTVbb0uAe+wJNQRaS12AIzxsan3ATUJjt/YmFOA3Y2 RMAIs7/8XrHSA== Date: Thu, 21 Aug 2025 21:11:46 +0100 From: Conor Dooley To: Andy Shevchenko Cc: =?iso-8859-1?Q?Jean-Fran=E7ois?= Lessard , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Andreas =?iso-8859-1?Q?F=E4rber?= , Boris Gjenero , Christian Hewitt , Heiner Kallweit , Paolo Sabatino , Martin Blumenstingl Subject: Re: [PATCH v3 4/4] MAINTAINERS: Add entry for TM16xx driver Message-ID: <20250821-hardener-underpay-e30d1eb6de6b@spud> References: <20250820163120.24997-1-jefflessard3@gmail.com> <20250820163120.24997-5-jefflessard3@gmail.com> <20250820-clock-easiness-850342f716f3@spud> <20250821-diminish-landlord-653a876e3cec@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="knF+Ka0cSC/ofLUy" Content-Disposition: inline In-Reply-To: --knF+Ka0cSC/ofLUy Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 21, 2025 at 10:35:07PM +0300, Andy Shevchenko wrote: > On Thu, Aug 21, 2025 at 10:33=E2=80=AFPM Andy Shevchenko > wrote: > > On Thu, Aug 21, 2025 at 8:40=E2=80=AFPM Conor Dooley = wrote: > > > On Wed, Aug 20, 2025 at 11:29:47PM +0300, Andy Shevchenko wrote: > > > > On Wed, Aug 20, 2025 at 10:52=E2=80=AFPM Conor Dooley wrote: > > > > > On Wed, Aug 20, 2025 at 10:08:06PM +0300, Andy Shevchenko wrote: > > > > > > On Wed, Aug 20, 2025 at 7:31=E2=80=AFPM Jean-Fran=C3=A7ois Less= ard > > > > > > wrote: > > > > > > > > > > > > Besides the missing commit message, the main part of this patch= should > > > > > > be merged with the patch 2 where the YAML file is being added. > > > > > > Otherwise it will be a dangling file. I dunno if DT tooling has= its > > > > > > own concept of a maintainer database, though. > > > > > > > > > > get_maintainer.pl will pull the maintainer out of the file, so it= won't be > > > > > truly dangling without a way to associate Jean-Fran=C3=A7ois with= this file, if > > > > > that;s what you mean. > > > > > > > > Let's assume patch 2 is applied and patch 4 is not, what will be the > > > > result of get_maintainer.pl for the YAML file? > > > > > > Andy Shevchenko (maintainer:AUXILIARY DISPLAY DRIVE= RS) > > > Geert Uytterhoeven (reviewer:AUXILIARY DISPLAY= DRIVERS) > > > Rob Herring (maintainer:OPEN FIRMWARE AND FLATTENED= DEVICE TREE BINDINGS) > > > Krzysztof Kozlowski (maintainer:OPEN FIRMWARE AN= D FLATTENED DEVICE TREE BINDINGS) > > > Conor Dooley (maintainer:OPEN FIRMWARE AND FLAT= TENED DEVICE TREE BINDINGS) > > > "Jean-Fran=C3=A7ois Lessard" (commit_signer:= 1/1=3D100%,authored:1/1=3D100%,added_lines:471/471=3D100%,in file) > > > = ^^^^^^^ > > > > Which is a git lookup heuristics. If you disable that, there is no > > maintainer for the file. Try with --m and --no-git (IIRC the option > > name). Also, I think linewrap might done some fuckery cos it was the "in file" I was pointing to, pretty sure that's not coming from git. I tried ./scripts/get_maintainer.pl --nogit --nogit-fallback -f Documentati= on/devicetree/bindings/auxdisplay/titanmec,tm16xx.yaml (I think --nogit-fallback is the salient option, --nogit is a default actually) and I got: Andy Shevchenko (maintainer:AUXILIARY DISPLAY DRIVERS) Geert Uytterhoeven (reviewer:AUXILIARY DISPLAY DRIVE= RS) Rob Herring (maintainer:OPEN FIRMWARE AND FLATTENED DEVIC= E TREE BINDINGS) Krzysztof Kozlowski (maintainer:OPEN FIRMWARE AND FLAT= TENED DEVICE TREE BINDINGS) Conor Dooley (maintainer:OPEN FIRMWARE AND FLATTENED = DEVICE TREE BINDINGS) "Jean-Fran=C3=A7ois Lessard" (in file) ^^^^^^^ and the in file still appears. devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TR= EE BINDINGS) linux-kernel@vger.kernel.org (open list) AUXILIARY DISPLAY DRIVERS status: Odd Fixes > Actually doesn't checkpatch complain in this case? The usual warning about MAINTAINERS appears ye, the one that appears whenever a file is moved, created or deleted. I personally don't care about that, as long as the end result of a series deals with it since the file will produce the correct maintainer list in a bisection etc anyway. Of course, your subsystem your prerogative. --knF+Ka0cSC/ofLUy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaKd9ggAKCRB4tDGHoIJi 0rumAP9De46/73MOVgngZyV5AK9LyWOXePmU5X0dCUT8/XjpKwEAnsRD5eJ+kjTt lmla59yRJHpp9dIezZkkESz+KLp6rg0= =Lif/ -----END PGP SIGNATURE----- --knF+Ka0cSC/ofLUy--