From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E31732E62B1; Thu, 21 Aug 2025 06:53:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755759190; cv=none; b=RVLHIKuHMmHPAWhZ8as+c4ONAX7MO2DLGcSqjuQKBXejK+amWSgxkiScQqQqOs3fAeGksvirw1QjBySJbvSFg3sEPOmBP4u8QHj/x8vksHK35Cw12Re/8W1dE30filN/UfkMWuAmYMndc2JwC90F2S35tYRsLYFvE1OloKEtVH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755759190; c=relaxed/simple; bh=Bq9tP1dBXwQ3sRC4YKUxmHUFPSXpyXHLlJKSZ1attcQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n78rQaSabD/ScKUnpdTllO9ZlOg/hDxdCc+ldpAowt6f4umkVt5TxhZ8AArkxFRzJinaYlanbIJQWKe0+FhGCd+kGDQAQhPK9H/U8b72NoTMSW3CS4wOv092aogUcb+K2vG42wz4oKsRxYZrpbO/St1YuZzDs5k89jvumpkF2SI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Qs7XcmMv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qs7XcmMv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22860C4CEED; Thu, 21 Aug 2025 06:53:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755759189; bh=Bq9tP1dBXwQ3sRC4YKUxmHUFPSXpyXHLlJKSZ1attcQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qs7XcmMvSsV7ZlsJpkSxU/mY6+27bCRXN2nW1JYMEkIZbbbxqeCb++SHayuZouPBe pXLdV6i4y+uV93jaiaeZXB1iriW3zE/bbKi69plgG3xa5OIs0Qi76qhRmK7VU1E6ss LtnBtwtwFnfX6J44cs071lPZ9x5vD+8uwLd7zPounkMciOpdxkDvBvqh8jlNUP8dii u2f72i1+0PrrVy50oULnOBet9AcjJiPjRXovxGrycQLyhLCkK3Ylvj06fa/HZTKOhm 8BZFUH4yFIxuQlwwigXeCGWanttsE4WFa/g75aoSrNq3PTsRHEf2r+EsWQcMVJMPEe J0JNPZ+l1tSHA== Date: Thu, 21 Aug 2025 08:53:07 +0200 From: Krzysztof Kozlowski To: Ariel D'Alessandro Cc: airlied@gmail.com, amergnat@baylibre.com, andrew+netdev@lunn.ch, andrew-ct.chen@mediatek.com, angelogioacchino.delregno@collabora.com, broonie@kernel.org, chunkuang.hu@kernel.org, ck.hu@mediatek.com, conor+dt@kernel.org, davem@davemloft.net, dmitry.torokhov@gmail.com, edumazet@google.com, flora.fu@mediatek.com, houlong.wei@mediatek.com, jeesw@melfas.com, jmassot@collabora.com, kernel@collabora.com, krzk+dt@kernel.org, kuba@kernel.org, kyrie.wu@mediatek.corp-partner.google.com, lgirdwood@gmail.com, linus.walleij@linaro.org, louisalexis.eyraud@collabora.com, maarten.lankhorst@linux.intel.com, matthias.bgg@gmail.com, mchehab@kernel.org, minghsiu.tsai@mediatek.com, mripard@kernel.org, p.zabel@pengutronix.de, pabeni@redhat.com, robh@kernel.org, sean.wang@kernel.org, simona@ffwll.ch, support.opensource@diasemi.com, tiffany.lin@mediatek.com, tzimmermann@suse.de, yunfei.dong@mediatek.com, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-sound@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v1 10/14] regulator: dt-bindings: Convert Dialog Semiconductor DA9211 Regulators to YAML Message-ID: <20250821-practical-coyote-of-hail-d2fddb@kuoka> References: <20250820171302.324142-1-ariel.dalessandro@collabora.com> <20250820171302.324142-11-ariel.dalessandro@collabora.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250820171302.324142-11-ariel.dalessandro@collabora.com> On Wed, Aug 20, 2025 at 02:12:58PM -0300, Ariel D'Alessandro wrote: > Convert the existing text-based DT bindings for Dialog Semiconductor DA9211 > Voltage Regulators family to a YAML schema. Examples are simplified, as > these are all equal. Also not wrapped... fix your editor to recognize how commits are written. > > Signed-off-by: Ariel D'Alessandro > --- ... > +--- > +$id: http://devicetree.org/schemas/regulator/dlg,da9211.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: | Drop | > + Dialog Semiconductor DA9211/DA9212/DA9213/DA9223/DA9214/DA9224/DA9215/DA9225 > + Voltage Regulator > + > +maintainers: > + - Ariel D'Alessandro > + > +properties: > + compatible: > + enum: > + - "dlg,da9211" > + - "dlg,da9212" > + - "dlg,da9213" > + - "dlg,da9223" > + - "dlg,da9214" > + - "dlg,da9224" > + - "dlg,da9215" > + - "dlg,da9225" No quotes. I don't think this was ever tested. Also, keep it properly ordered > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + regulators: > + type: object > + additionalProperties: false > + description: | Drop | > + List of regulators provided by the device > + > + patternProperties: > + "^BUCK([A-B])$": [AB] > + type: object > + $ref: regulator.yaml# > + description: | > + Properties for a single BUCK regulator > + > + properties: > + regulator-initial-mode: > + items: > + enum: [ 1, 2, 3 ] > + description: Defined in include/dt-bindings/regulator/dlg,da9211-regulator.h > + > + regulator-allowed-modes: > + items: > + enum: [ 1, 2, 3 ] > + description: Defined in include/dt-bindings/regulator/dlg,da9211-regulator.h > + > + enable-gpios: > + maxItems: 1 > + description: Specify a valid GPIO for platform control of the regulator Drop description, obvious. > + > + unevaluatedProperties: false For nested blocks this goes after $ref: regulator. > + > +required: > + - compatible > + - reg > + - interrupts > + - regulators > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + i2c1 { i2c > + #address-cells = <1>; > + #size-cells = <0>; > + > + da9212: da9212@68 { Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof