devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephan Gerhold <stephan.gerhold@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>,
	 Konrad Dybcio <konradybcio@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 Aleksandrs Vinarskis <alex.vinarskis@gmail.com>,
	 Abel Vesa <abel.vesa@linaro.org>,
	Xilin Wu <wuxilin123@gmail.com>,
	 Jens Glathe <jens.glathe@oldschoolsolutions.biz>,
	 Srinivas Kandagatla <srini@kernel.org>,
	 Sibi Sankar <quic_sibis@quicinc.com>,
	 Rajendra Nayak <quic_rjendra@quicinc.com>,
	linux-arm-msm@vger.kernel.org,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,  Johan Hovold <johan@kernel.org>,
	 Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: [PATCH v2 08/10] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add missing pinctrl for eDP HPD
Date: Fri, 22 Aug 2025 11:28:59 +0200	[thread overview]
Message-ID: <20250822-x1e80100-add-edp-hpd-v2-8-6310176239a6@linaro.org> (raw)
In-Reply-To: <20250822-x1e80100-add-edp-hpd-v2-0-6310176239a6@linaro.org>

At the moment, we indirectly rely on the boot firmware to set up the
pinctrl for the eDP HPD line coming from the internal display. If the boot
firmware does not configure the display (e.g. because a different display
is selected for output in the UEFI settings), then the display fails to
come up and there are several errors in the kernel log:

 [drm:dpu_encoder_phys_vid_wait_for_commit_done:544] [dpu error]vblank timeout: 80020041
 [drm:dpu_kms_wait_for_commit_done:524] [dpu error]wait for commit done returned -110
 [drm:dpu_encoder_frame_done_timeout:2715] [dpu error]enc40 frame done timeout
 ...

Fix this by adding the missing pinctrl for gpio119 (func1/edp0_hot and
bias-disable according to the ACPI DSDT), which is defined as
&edp0_hpd_default template in x1e80100.dtsi.

Fixes: 45247fe17db2 ("arm64: dts: qcom: x1e80100: add Lenovo Thinkpad Yoga slim 7x devicetree")
Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
index 71becfc5e6f649299b05b0b93cf74b81dea9fa57..dadbcd66584d7c90a01bfb339e586e4675bf32f5 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
+++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
@@ -1086,6 +1086,9 @@ &mdss_dp2_out {
 &mdss_dp3 {
 	/delete-property/ #sound-dai-cells;
 
+	pinctrl-0 = <&edp0_hpd_default>;
+	pinctrl-names = "default";
+
 	status = "okay";
 
 	aux-bus {

-- 
2.50.1


  parent reply	other threads:[~2025-08-22  9:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-22  9:28 [PATCH v2 00/10] arm64: dts: qcom: x1: Add missing pinctrl for eDP HPD Stephan Gerhold
2025-08-22  9:28 ` [PATCH v2 01/10] arm64: dts: qcom: x1e80100: Add pinctrl template for eDP0 HPD Stephan Gerhold
2025-08-22  9:35   ` Neil Armstrong
2025-08-22  9:40   ` Dmitry Baryshkov
2025-08-22  9:28 ` [PATCH v2 02/10] arm64: dts: qcom: x1-asus-zenbook-a14: Add missing pinctrl for eDP HPD Stephan Gerhold
2025-08-22  9:28 ` [PATCH v2 03/10] arm64: dts: qcom: x1-crd: " Stephan Gerhold
2025-08-22  9:28 ` [PATCH v2 04/10] arm64: dts: qcom: x1e78100-lenovo-thinkpad-t14s: " Stephan Gerhold
2025-08-22  9:35   ` Neil Armstrong
2025-08-22  9:28 ` [PATCH v2 05/10] arm64: dts: qcom: x1e80100-asus-vivobook-s15: " Stephan Gerhold
2025-08-22  9:28 ` [PATCH v2 06/10] arm64: dts: qcom: x1e80100-dell-xps13-9345: " Stephan Gerhold
2025-08-22  9:28 ` [PATCH v2 07/10] arm64: dts: qcom: x1e80100-hp-omnibook-x14: " Stephan Gerhold
2025-08-22  9:28 ` Stephan Gerhold [this message]
2025-08-22  9:29 ` [PATCH v2 09/10] arm64: dts: qcom: x1e80100-microsoft-romulus: " Stephan Gerhold
2025-08-22  9:29 ` [PATCH v2 10/10] arm64: dts: qcom: x1e80100-qcp: " Stephan Gerhold
2025-08-22  9:40 ` [PATCH v2 00/10] arm64: dts: qcom: x1: " Dmitry Baryshkov
2025-09-01 19:46 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250822-x1e80100-add-edp-hpd-v2-8-6310176239a6@linaro.org \
    --to=stephan.gerhold@linaro.org \
    --cc=abel.vesa@linaro.org \
    --cc=alex.vinarskis@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=jens.glathe@oldschoolsolutions.biz \
    --cc=johan@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_rjendra@quicinc.com \
    --cc=quic_sibis@quicinc.com \
    --cc=robh@kernel.org \
    --cc=srini@kernel.org \
    --cc=wuxilin123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).