* [PATCH] dt-bindings: ata: sun4i-a10: Add a reference to ahci-common.yaml
@ 2025-08-22 18:17 Fabio Estevam
2025-08-23 13:54 ` Conor Dooley
0 siblings, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2025-08-22 18:17 UTC (permalink / raw)
To: cassel
Cc: dlemoal, robh, krzk+dt, conor+dt, linux-ide, devicetree, wens,
jernej.skrabec, samuel, Fabio Estevam
The 'target-supply' property is already documented in ahci-common.yaml.
Instead of documenting it locally, add a reference to ahci-common.yaml.
Also change to 'unevaluatedProperties: false' to allow the properties
from ahci-common.yaml to be evaluated.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
.../devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml b/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml
index 2011bd03cdcd..8826aed4ec03 100644
--- a/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml
+++ b/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml
@@ -10,6 +10,9 @@ maintainers:
- Chen-Yu Tsai <wens@csie.org>
- Maxime Ripard <mripard@kernel.org>
+allOf:
+ - $ref: ahci-common.yaml#
+
properties:
compatible:
const: allwinner,sun4i-a10-ahci
@@ -25,16 +28,13 @@ properties:
interrupts:
maxItems: 1
- target-supply:
- description: Regulator for SATA target power
-
required:
- compatible
- reg
- clocks
- interrupts
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: ata: sun4i-a10: Add a reference to ahci-common.yaml
2025-08-22 18:17 [PATCH] dt-bindings: ata: sun4i-a10: Add a reference to ahci-common.yaml Fabio Estevam
@ 2025-08-23 13:54 ` Conor Dooley
2025-08-25 16:46 ` Conor Dooley
0 siblings, 1 reply; 4+ messages in thread
From: Conor Dooley @ 2025-08-23 13:54 UTC (permalink / raw)
To: Fabio Estevam
Cc: cassel, dlemoal, robh, krzk+dt, conor+dt, linux-ide, devicetree,
wens, jernej.skrabec, samuel
[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]
On Fri, Aug 22, 2025 at 03:17:49PM -0300, Fabio Estevam wrote:
> The 'target-supply' property is already documented in ahci-common.yaml.
>
> Instead of documenting it locally, add a reference to ahci-common.yaml.
>
> Also change to 'unevaluatedProperties: false' to allow the properties
> from ahci-common.yaml to be evaluated.
Are the other properties in ahci-common.yaml valid for this device?
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> .../devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml b/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml
> index 2011bd03cdcd..8826aed4ec03 100644
> --- a/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml
> +++ b/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml
> @@ -10,6 +10,9 @@ maintainers:
> - Chen-Yu Tsai <wens@csie.org>
> - Maxime Ripard <mripard@kernel.org>
>
> +allOf:
> + - $ref: ahci-common.yaml#
> +
> properties:
> compatible:
> const: allwinner,sun4i-a10-ahci
> @@ -25,16 +28,13 @@ properties:
> interrupts:
> maxItems: 1
>
> - target-supply:
> - description: Regulator for SATA target power
> -
> required:
> - compatible
> - reg
> - clocks
> - interrupts
>
> -additionalProperties: false
> +unevaluatedProperties: false
>
> examples:
> - |
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: ata: sun4i-a10: Add a reference to ahci-common.yaml
2025-08-23 13:54 ` Conor Dooley
@ 2025-08-25 16:46 ` Conor Dooley
2025-08-25 16:51 ` Fabio Estevam
0 siblings, 1 reply; 4+ messages in thread
From: Conor Dooley @ 2025-08-25 16:46 UTC (permalink / raw)
To: Fabio Estevam
Cc: cassel, dlemoal, robh, krzk+dt, conor+dt, linux-ide, devicetree,
wens, jernej.skrabec, samuel
[-- Attachment #1: Type: text/plain, Size: 1784 bytes --]
On Sat, Aug 23, 2025 at 02:54:40PM +0100, Conor Dooley wrote:
> On Fri, Aug 22, 2025 at 03:17:49PM -0300, Fabio Estevam wrote:
> > The 'target-supply' property is already documented in ahci-common.yaml.
> >
> > Instead of documenting it locally, add a reference to ahci-common.yaml.
> >
> > Also change to 'unevaluatedProperties: false' to allow the properties
> > from ahci-common.yaml to be evaluated.
>
> Are the other properties in ahci-common.yaml valid for this device?
Given the imx patch, are you still pursuing this change?
>
> >
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
> > ---
> > .../devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml b/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml
> > index 2011bd03cdcd..8826aed4ec03 100644
> > --- a/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml
> > +++ b/Documentation/devicetree/bindings/ata/allwinner,sun4i-a10-ahci.yaml
> > @@ -10,6 +10,9 @@ maintainers:
> > - Chen-Yu Tsai <wens@csie.org>
> > - Maxime Ripard <mripard@kernel.org>
> >
> > +allOf:
> > + - $ref: ahci-common.yaml#
> > +
> > properties:
> > compatible:
> > const: allwinner,sun4i-a10-ahci
> > @@ -25,16 +28,13 @@ properties:
> > interrupts:
> > maxItems: 1
> >
> > - target-supply:
> > - description: Regulator for SATA target power
> > -
> > required:
> > - compatible
> > - reg
> > - clocks
> > - interrupts
> >
> > -additionalProperties: false
> > +unevaluatedProperties: false
> >
> > examples:
> > - |
> > --
> > 2.34.1
> >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: ata: sun4i-a10: Add a reference to ahci-common.yaml
2025-08-25 16:46 ` Conor Dooley
@ 2025-08-25 16:51 ` Fabio Estevam
0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2025-08-25 16:51 UTC (permalink / raw)
To: Conor Dooley
Cc: cassel, dlemoal, robh, krzk+dt, conor+dt, linux-ide, devicetree,
wens, jernej.skrabec, samuel
On Mon, Aug 25, 2025 at 1:46 PM Conor Dooley <conor@kernel.org> wrote:
> Given the imx patch, are you still pursuing this change?
Let's discard this one, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-08-25 16:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-22 18:17 [PATCH] dt-bindings: ata: sun4i-a10: Add a reference to ahci-common.yaml Fabio Estevam
2025-08-23 13:54 ` Conor Dooley
2025-08-25 16:46 ` Conor Dooley
2025-08-25 16:51 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).