Devicetree
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: cassel@kernel.org, dlemoal@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
	imx@lists.linux.dev
Subject: Re: [PATCH] dt-bindings: ata: imx: Add a reference to ahci-common.yaml
Date: Sat, 23 Aug 2025 14:55:33 +0100	[thread overview]
Message-ID: <20250823-altitude-scone-fe104905ff48@spud> (raw)
In-Reply-To: <20250822175830.91682-1-festevam@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]

On Fri, Aug 22, 2025 at 02:58:30PM -0300, Fabio Estevam wrote:
> The 'target-supply' property is documented in ahci-common.yaml.
> 
> Add a reference to ahci-common.yaml to fix the following dt-schema
> warning: 

Same here I guess, you're allowing a bunch of other properties now, what
of those are actually permitted ones for this device?

> 
> 'target-supply' does not match any of the regexes: '^pinctrl-[0-9]+$'
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  Documentation/devicetree/bindings/ata/imx-sata.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/ata/imx-sata.yaml b/Documentation/devicetree/bindings/ata/imx-sata.yaml
> index f4eb3550a096..c60866544a53 100644
> --- a/Documentation/devicetree/bindings/ata/imx-sata.yaml
> +++ b/Documentation/devicetree/bindings/ata/imx-sata.yaml
> @@ -88,6 +88,8 @@ required:
>    - clock-names
>  
>  allOf:
> +  - $ref: ahci-common.yaml#
> +
>    - if:
>        properties:
>          compatible:
> @@ -112,7 +114,7 @@ allOf:
>          clock-names:
>            minItems: 2
>  
> -additionalProperties: false
> +unevaluatedProperties: false
>  
>  examples:
>    - |
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2025-08-23 13:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-22 17:58 [PATCH] dt-bindings: ata: imx: Add a reference to ahci-common.yaml Fabio Estevam
2025-08-23 13:55 ` Conor Dooley [this message]
2025-08-23 19:51   ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250823-altitude-scone-fe104905ff48@spud \
    --to=conor@kernel.org \
    --cc=cassel@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox